Re: [Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-21 Thread Jason Molenda via lldb-commits
> On Mar 21, 2020, at 10:25 PM, Jason Molenda via Phabricator via lldb-commits > wrote: > > > 0x11232 <+18>: movq %rax, -0x68(%rbp) > 0x11236 <+22>: callq 0x11350 ; > std::__1::vector > >::vector at vector:497 > 0x1123b <+27>: movabsq $0x1, %rax

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-21 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. (and if you're still seeing mystery reads, put a breakpoint on ProcessGDBRemote::DoReadMemory and see who is doing it) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74398/new/ https://reviews.llvm.org/D74398 __

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-21 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. In D74398#1935431 , @jasonmolenda wrote: > In D74398#1935043 , @jarin wrote: > > > Regarding the packet savings - there are still things that worry me. > > > > First of all, when lldb

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-21 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. In D74398#1935043 , @jarin wrote: > Regarding the packet savings - there are still things that worry me. > > First of all, when lldb CLI stops on a breakpoint, it will first unwind top > of the stack of each thread as part of

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

2020-03-21 Thread Aaron Smith via Phabricator via lldb-commits
asmith added a comment. Herald added a subscriber: JDevlieghere. Curious what the status of this is? Looks like its been ready for almost one year :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 __

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-21 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Regarding the packet savings - there are still things that worry me. First of all, when lldb CLI stops on a breakpoint, it will first unwind top of the stack of each thread as part of ThreadList::ShouldStop. This sends lots of "x" packets to lldb-server and only then issu