[Lldb-commits] [PATCH] D76045: [lldb/API] Make Launch(Simple) use args and env from target properties

friss created this revision. friss added reviewers: jingham, labath. Herald added projects: LLDB, libc++abi. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++abi. friss updated this revision to Diff 249834. friss added a comment. friss removed a reviewer: libc++abi. friss r

[Lldb-commits] [PATCH] D76045: [lldb/API] Make Launch(Simple) use args and env from target properties

friss updated this revision to Diff 249834. friss added a comment. Remove unrelated change commited by accident Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76045/new/ https://reviews.llvm.org/D76045 Files: lldb/include/lldb/API/SBTarget.h ll

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace added a comment. Regarding implementation: The target.inherit-env setting is only effectively used by CommandObjectProcess when launching the target from the command line. lldb-vscode is not following the same codepath and not using that property. What about exposing the Platform's env

[Lldb-commits] [lldb] 5161194 - Revert "Update debugserver test for new ostype names"

Author: Adrian Prantl Date: 2020-03-11T21:32:12-07:00 New Revision: 5161194fad8cdd0b496c63c410855290c5e5190b URL: https://github.com/llvm/llvm-project/commit/5161194fad8cdd0b496c63c410855290c5e5190b DIFF: https://github.com/llvm/llvm-project/commit/5161194fad8cdd0b496c63c410855290c5e5190b.diff

[Lldb-commits] [lldb] cd4c1ad - Add newly-missing include

Author: Adrian Prantl Date: 2020-03-11T19:30:53-07:00 New Revision: cd4c1adabeae8ea2939ee2d00d9d57aba3767960 URL: https://github.com/llvm/llvm-project/commit/cd4c1adabeae8ea2939ee2d00d9d57aba3767960 DIFF: https://github.com/llvm/llvm-project/commit/cd4c1adabeae8ea2939ee2d00d9d57aba3767960.diff

[Lldb-commits] [lldb] ae73ab6 - Update debugserver test for new ostype names

Author: Adrian Prantl Date: 2020-03-11T15:50:03-07:00 New Revision: ae73ab64b66d1889b447303d432f4d217d222def URL: https://github.com/llvm/llvm-project/commit/ae73ab64b66d1889b447303d432f4d217d222def DIFF: https://github.com/llvm/llvm-project/commit/ae73ab64b66d1889b447303d432f4d217d222def.diff

[Lldb-commits] [lldb] 213aea4 - Remove unused Endian.h includes, NFC

Author: Reid Kleckner Date: 2020-03-11T15:45:34-07:00 New Revision: 213aea4c5836934771eb97eb97e4c964053a8596 URL: https://github.com/llvm/llvm-project/commit/213aea4c5836934771eb97eb97e4c964053a8596 DIFF: https://github.com/llvm/llvm-project/commit/213aea4c5836934771eb97eb97e4c964053a8596.diff

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

clayborg added a comment. In D74636#1916356 , @labath wrote: > There's a `target.inherit-env` setting in lldb (which I believe also works > correctly for remote launches). Could you use that instead of reimplementing > the feature in vscode? The real q

[Lldb-commits] [PATCH] D75877: [lldb/Reproducers] Fix replay for process attach workflows

JDevlieghere updated this revision to Diff 249764. JDevlieghere added a comment. Address code review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75877/new/ https://reviews.llvm.org/D75877 Files: lldb/include/lldb/Host/Host.h lldb/include/lldb/Utility/ProcessInfo.h lld

[Lldb-commits] [PATCH] D75925: [lldb] reject `.debug_arange` sections with nonzero segment size

clayborg added a comment. lgtm once all formatting issues are taken care of. Pavel? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75925/new/ https://reviews.llvm.org/D75925 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D75877: [lldb/Reproducers] Fix replay for process attach workflows

JDevlieghere marked 7 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Utility/ProcessInfo.cpp:417-430 + static std::unique_ptr> + loader = repro::MultiLoader::Create( + repro::Reproducer::Instance().GetLoader()); + + if (!loade

[Lldb-commits] [PATCH] D75406: Avoid including FileManager.h from SourceManager.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGe08464fb4504: Avoid including FileManager.h from SourceManager.h (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D75406?vs=247479&id=249752#toc Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

This revision was automatically updated to reflect the committed changes. rnk marked an inline comment as done. Closed by commit rGc915cb957dc3: Avoid including Module.h from ExternalASTSource.h (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk added a comment. Thanks! In D75784#1917181 , @aprantl wrote: > To avoid bot breakage, I would recommend testing -DLLVM_ENABLE_MODULES=1 > stage2 build works before landing this, as it is notoriously sensitive to > header reshuffling. Good idea, I

[Lldb-commits] [lldb] e08464f - Avoid including FileManager.h from SourceManager.h

Author: Reid Kleckner Date: 2020-03-11T13:53:12-07:00 New Revision: e08464fb450456881733c885267b32dc7339cf11 URL: https://github.com/llvm/llvm-project/commit/e08464fb450456881733c885267b32dc7339cf11 DIFF: https://github.com/llvm/llvm-project/commit/e08464fb450456881733c885267b32dc7339cf11.diff

[Lldb-commits] [lldb] c915cb9 - Avoid including Module.h from ExternalASTSource.h

Author: Reid Kleckner Date: 2020-03-11T13:37:41-07:00 New Revision: c915cb957dc37275ce1ca1a0b993239c82f12692 URL: https://github.com/llvm/llvm-project/commit/c915cb957dc37275ce1ca1a0b993239c82f12692 DIFF: https://github.com/llvm/llvm-project/commit/c915cb957dc37275ce1ca1a0b993239c82f12692.diff

[Lldb-commits] [PATCH] D76011: Add a verification mechanism to CompilerType.

aprantl closed this revision. aprantl added a comment. ea960371861acad11b7018a5e280ae7a41ab9c02 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76011/new/ https://reviews.llvm.org/D76011

[Lldb-commits] [lldb] ea96037 - Add a verification mechanism to CompilerType.

Author: Adrian Prantl Date: 2020-03-11T12:43:32-07:00 New Revision: ea960371861acad11b7018a5e280ae7a41ab9c02 URL: https://github.com/llvm/llvm-project/commit/ea960371861acad11b7018a5e280ae7a41ab9c02 DIFF: https://github.com/llvm/llvm-project/commit/ea960371861acad11b7018a5e280ae7a41ab9c02.diff

[Lldb-commits] [PATCH] D76011: Add a verification mechanism to CompilerType.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Seems fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76011/new/ https://reviews.llvm.org/D76011 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D76011: Add a verification mechanism to CompilerType.

aprantl created this revision. aprantl added reviewers: jingham, davide, labath, teemperor. Badly-written code can combine an unrelated TypeSystem and opaque type pointer into a CompilerType. This is particularly an issue in swift-lldb. This patch adds an assertion mechanism that catches these kin

[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

jingham marked an inline comment as done. jingham added inline comments. Comment at: lldb/source/Target/ThreadPlanStack.cpp:373 + } +} labath wrote: > jingham wrote: > > labath wrote: > > > This is the usual place where one would add a llvm_unreachable. Some >

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

friss created this revision. friss added reviewers: jingham, labath. Herald added a project: LLDB. The TargetProperties constructor invokes a series of callbacks to prime the properties from the default ones. The one callback in charge of updating the inferior environment was commented out because

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

shafik added a comment. I want to see how you end up resolving the comments on payload being a plain integer type in D75626 before looking at this again. Maybe it makes more sense to use a type, the use is pretty clever but perhaps makes for opaque code in some

[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

jingham updated this revision to Diff 249674. jingham added a comment. more reformatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75880/new/ https://reviews.llvm.org/D75880 Files: lldb/include/lldb/Target/Process.h lldb/include/lldb/Targe

[Lldb-commits] [PATCH] D75864: Add a decorator option to skip tests based on a default setting

This revision was automatically updated to reflect the committed changes. Closed by commit rG0396aa4c05a4: Add a decorator option to skip tests based on a default setting. (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D75925: [lldb] reject `.debug_arange` sections with nonzero segment size

ldrumm updated this revision to Diff 249663. ldrumm added a comment. I found similar unittests for other DWARF entries which allow me to check more about the parser state, so I went with Pavel's suggestion for the testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D76004: [lldb] Add YAML traits for ArchSpec and ProcessInstanceInfo

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. JDevlieghere added a parent revision: D76002: [lldb] Add YAML traits for ConstString and FileSpec. Add YAML traits for ArchSpec and ProcessInstanceInfo

[Lldb-commits] [lldb] 0396aa4 - Add a decorator option to skip tests based on a default setting.

Author: Adrian Prantl Date: 2020-03-11T10:00:36-07:00 New Revision: 0396aa4c05a4b97101da14b5e813c8ab3a34e9d0 URL: https://github.com/llvm/llvm-project/commit/0396aa4c05a4b97101da14b5e813c8ab3a34e9d0 DIFF: https://github.com/llvm/llvm-project/commit/0396aa4c05a4b97101da14b5e813c8ab3a34e9d0.diff

[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

aprantl added a comment. To avoid bot breakage, I would recommend testing -DLLVM_ENABLE_MODULES=1 stage2 build works before landing this, as it is notoriously sensitive to header reshuffling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75784/new

[Lldb-commits] [PATCH] D75864: Add a decorator option to skip tests based on a default setting

aprantl added a comment. In D75864#1914916 , @labath wrote: > Right, that makes sense, though it makes me cry a bit every time we add a new > option to the test decorators... We call it the Christmas tree approach to testing! CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76002: [lldb] Add YAML traits for ConstString and FileSpec

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a project: LLDB. Add YAML traits for ConstString and FileSpec so they can be serialized as part of ProcessInfo. Repository: rLLDB LLDB https://reviews.llvm.org/D76002 Files: lldb/include/lldb/Utility/C

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1915048 , @mstorsjo wrote: > This broke compiling for mingw, repro.c: > > a(short); > b() { a(1); } > > > `clang -target x86_64-w64-mingw32 -c repro.c -g -O2`, which gives `Assertion > '!MI.isMoveImmediate() && "Une

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1916291 , @djtodoro wrote: > In D73534#1915048 , @mstorsjo wrote: > > > This broke compiling for mingw, repro.c: > > > > a(short); > > b() { a(1); } > > > > > > `clang -target

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin added a comment. In D75929#1916466 , @labath wrote: > In D75929#1916127 , @ikudrin wrote: > > > I believe that this patch is more or less compatible with any approach > > which might be taken. The idea is t

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin added a comment. Thanks for the links! What a coincidence... I believe that this patch is more or less compatible with any approach which might be taken. The idea is that there is a set of constants for internal use and functions to translate them to/from external representation and bot

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

jhenderson added inline comments. Comment at: llvm/include/llvm/Support/ELFAttributes.h:32 + bool HasTagPrefix = true); +Optional attrTypeFromString(StringRef Tag, TagNameMap Map); + HsiangKai wrote: > jhenderson wrote: > > Can this be `

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

labath added a comment. In D75929#1916760 , @ikudrin wrote: > In D75929#1916466 , @labath wrote: > > > That's true, but I'm not sure it is really the best solution. > > > Well, I do not pretend this to be a perfect

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

labath added a comment. In D75929#1916127 , @ikudrin wrote: > I believe that this patch is more or less compatible with any approach which > might be taken. The idea is that there is a set of constants for internal use > and functions to translate them t

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

jhenderson added inline comments. Comment at: llvm/unittests/Support/ELFAttributeParser.cpp:5 +#include "gtest/gtest.h" +#include + jhenderson wrote: > I think it's normal to put a blank line between standard library headers and > other includes. Ignore this. I

[Lldb-commits] [PATCH] D75761: [lldb] Fix to get the AST we generate for function templates to be closer to what clang generates and expects

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I only have some minor comments but otherwise I think this can land. The title could use some updating as "Fix to get the AST we generate for function templates to be closer to what clan

[Lldb-commits] [PATCH] D75979: [lldb] Implement StackFrame::BehavesLikeZerothFrame

labath added a comment. If it's not used anywhere, maybe we should delete it instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75979/new/ https://reviews.llvm.org/D75979 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D75925: [lldb] reject `.debug_arange` sections with nonzero segment size

labath added a comment. In D75925#1915693 , @clayborg wrote: > Change looks good, just needs a test. Should be easy to take a simple binary > that has a .debug_aranges, and run obj2yaml on it, and tweak the segment size > as needed? In this case I thin

[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from minor nits, this seems reasonable to me, LG! Comment at: clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:16 #include "llvm/ADT/StringR

[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

labath added a comment. In D75880#1915999 , @jingham wrote: > We use that all over the place in lldb, and I much prefer it. I'm afraid that's no longer true. I count 30 instances of `&&` or `||` at the beginning of a line versus 2343 instances of it

[Lldb-commits] [PATCH] D75406: Avoid including FileManager.h from SourceManager.h

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D75406: Avoid including FileManager.h from SourceManager.h

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ lld

[Lldb-commits] [PATCH] D75979: [lldb] Implement StackFrame::BehavesLikeZerothFrame

anton.kolesov created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Commit [1] added a declaration of function-member StackFrame::BehavesLikeZerothFrame but hasn't added an implementation for the function. Repository: rG LLVM Github Monorepo https://rev

[Lldb-commits] [PATCH] D75877: [lldb/Reproducers] Fix replay for process attach workflows

labath added a comment. A bunch of comments but nothing really major. Maybe it would be nice to put the code for yamlification of ProcessInfo into a separate patch? Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:499-512 +auto error_or_file = MemoryBuffer:

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

labath added a comment. There's a `target.inherit-env` setting in lldb (which I believe also works correctly for remote launches). Could you use that instead of reimplementing the feature in vscode? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74

[Lldb-commits] [PATCH] D75975: [lldb] Copy m_behaves_like_zeroth_frame on stack frame update

anton.kolesov created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Field StackFrame::m_behaves_like_zeroth_frame was introduced in commit [1], however that commit hasn't added a copying of the field to UpdatePreviousFrameFromCurrentFrame, therefore the valu