[Lldb-commits] [lldb] 80b2e3c - [lldb/Core] Remove more duplicate code in PluginManager (NFCI)

Author: Jonas Devlieghere Date: 2020-02-18T23:58:29-08:00 New Revision: 80b2e3cc531206c6e6f23dcc49b83b9ace641025 URL: https://github.com/llvm/llvm-project/commit/80b2e3cc531206c6e6f23dcc49b83b9ace641025 DIFF: https://github.com/llvm/llvm-project/commit/80b2e3cc531206c6e6f23dcc49b83b9ace641025.d

[Lldb-commits] [PATCH] D74816: [lldb/Core] Remove more duplicate code in PluginManager (NFCI)

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor. Herald added a subscriber: abidh. Herald added a project: LLDB. JDevlieghere edited the summary of this revision. teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready

[Lldb-commits] [PATCH] D74816: [lldb/Core] Remove more duplicate code in PluginManager (NFCI)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, let’s send that code to the shadow realm. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74816/new/ https://reviews.llvm.org/D74816 ___

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the inline comments addressed and a test in `Shell/VSCode`. Comment at: lldb/tools/lldb-vscode/CMakeLists.txt:20 + # We need to include the llvm comp

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

JDevlieghere added a comment. In D74727#1881055 , @hhb wrote: > > Can we maybe rename it to something like that? > > LLDB_RELOCATABLE_PYTHON is misleading. I'd be happy to rename it. But that > may break people who already set this flag. > > Is there a st

[Lldb-commits] [lldb] 7c4b704 - [lldb] Sort forward declarations in lldb-forward.h

Author: Jonas Devlieghere Date: 2020-02-18T20:22:52-08:00 New Revision: 7c4b70402c6679427a5a2d4508355af7d4c61678 URL: https://github.com/llvm/llvm-project/commit/7c4b70402c6679427a5a2d4508355af7d4c61678 DIFF: https://github.com/llvm/llvm-project/commit/7c4b70402c6679427a5a2d4508355af7d4c61678.d

[Lldb-commits] [lldb] d7db094 - [lldb] Move ArchitectureCreateInstance into ldb-private-interfaces

Author: Jonas Devlieghere Date: 2020-02-18T20:19:54-08:00 New Revision: d7db094ef790f16a6252ac83a48958de23851aee URL: https://github.com/llvm/llvm-project/commit/d7db094ef790f16a6252ac83a48958de23851aee DIFF: https://github.com/llvm/llvm-project/commit/d7db094ef790f16a6252ac83a48958de23851aee.d

[Lldb-commits] [lldb] e682058 - [lldb/Docs] Update the features matrix

Author: Jonas Devlieghere Date: 2020-02-18T20:08:43-08:00 New Revision: e68205844db3079116c777f34d273149b8b74cad URL: https://github.com/llvm/llvm-project/commit/e68205844db3079116c777f34d273149b8b74cad DIFF: https://github.com/llvm/llvm-project/commit/e68205844db3079116c777f34d273149b8b74cad.d

[Lldb-commits] [lldb] ae73891 - [lldb/Docs] Update the Windows documentation

Author: Jonas Devlieghere Date: 2020-02-18T19:53:36-08:00 New Revision: ae738911641660a63a102923c2beb070d6cebf39 URL: https://github.com/llvm/llvm-project/commit/ae738911641660a63a102923c2beb070d6cebf39 DIFF: https://github.com/llvm/llvm-project/commit/ae738911641660a63a102923c2beb070d6cebf39.d

[Lldb-commits] [lldb] 80c3ea4 - Re-land "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"

Author: Jonas Devlieghere Date: 2020-02-18T19:16:07-08:00 New Revision: 80c3ea4e633b440cb4bc2c36856d811353e474bb URL: https://github.com/llvm/llvm-project/commit/80c3ea4e633b440cb4bc2c36856d811353e474bb DIFF: https://github.com/llvm/llvm-project/commit/80c3ea4e633b440cb4bc2c36856d811353e474bb.d

[Lldb-commits] [lldb] bad1389 - [lldb/Core] Remove dead Get*PluginCreateCallbackForPluginName (NFC)

Author: Jonas Devlieghere Date: 2020-02-18T17:36:26-08:00 New Revision: bad1389f1252d1b77c5e31f0dadee92eb38d23a1 URL: https://github.com/llvm/llvm-project/commit/bad1389f1252d1b77c5e31f0dadee92eb38d23a1 DIFF: https://github.com/llvm/llvm-project/commit/bad1389f1252d1b77c5e31f0dadee92eb38d23a1.d

[Lldb-commits] [lldb] 7b76767 - [lldb/Core] Remove blatant code duplication by using a template (NFC)

Author: Jonas Devlieghere Date: 2020-02-18T17:19:47-08:00 New Revision: 7b76767dbc4b1894c2c7ff397875cb2285e70446 URL: https://github.com/llvm/llvm-project/commit/7b76767dbc4b1894c2c7ff397875cb2285e70446 DIFF: https://github.com/llvm/llvm-project/commit/7b76767dbc4b1894c2c7ff397875cb2285e70446.d

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

clayborg added a comment. Looks good. I would add a .test file like the command line driver to cover this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74798/new/ https://reviews.llvm.org/D74798 ___ l

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 added a comment. Assuming this looks good, can I get some pointers on how and where I should add a test for this? I based this change on the one for the LLDB driver (https://reviews.llvm.org/D54692) which added lldb/trunk/lit/Driver/TestCommands.test. Should I look into adding

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This change will bring lldb-vscode in line with how several other llvm tools process command line arguments. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D7479

[Lldb-commits] [lldb] 42cab98 - [TestTargetCommand] Remove another reference to a stale rdar.

Author: Davide Italiano Date: 2020-02-18T13:39:37-08:00 New Revision: 42cab985fd95ba4f3f290e7bb26b93805edb447d URL: https://github.com/llvm/llvm-project/commit/42cab985fd95ba4f3f290e7bb26b93805edb447d DIFF: https://github.com/llvm/llvm-project/commit/42cab985fd95ba4f3f290e7bb26b93805edb447d.dif

[Lldb-commits] [lldb] 2560a93 - [TestTargetCommand] `target var` without a process doesn't work on arm64e.

Author: Davide Italiano Date: 2020-02-18T13:38:27-08:00 New Revision: 2560a93b706245b442ac5bf208c48db4912de134 URL: https://github.com/llvm/llvm-project/commit/2560a93b706245b442ac5bf208c48db4912de134 DIFF: https://github.com/llvm/llvm-project/commit/2560a93b706245b442ac5bf208c48db4912de134.dif

[Lldb-commits] [PATCH] D74780: [lldb/Plugin] Reject WASM and Hexagon in DynamicLoaderStatic

This revision was automatically updated to reflect the committed changes. Closed by commit rGebf9a99bbdcd: [lldb/Plugin] Reject WASM and Hexagon in DynamicLoaderStatic (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D74780?vs=245212&id=245252#toc Repository: rG

[Lldb-commits] [lldb] 3f5e050 - [TestGlobalVariables] Remove a reference to a stale rdar.

Author: Davide Italiano Date: 2020-02-18T13:31:14-08:00 New Revision: 3f5e0501b5e28602320df37e740445a7f93bc24f URL: https://github.com/llvm/llvm-project/commit/3f5e0501b5e28602320df37e740445a7f93bc24f DIFF: https://github.com/llvm/llvm-project/commit/3f5e0501b5e28602320df37e740445a7f93bc24f.dif

[Lldb-commits] [lldb] 0159c21 - [TestGlobalVariables] `target var` without a process doesn't work on arm64e.

Author: Davide Italiano Date: 2020-02-18T13:30:51-08:00 New Revision: 0159c21119ed5694c2804ec439e336b5b7e136ec URL: https://github.com/llvm/llvm-project/commit/0159c21119ed5694c2804ec439e336b5b7e136ec DIFF: https://github.com/llvm/llvm-project/commit/0159c21119ed5694c2804ec439e336b5b7e136ec.dif

[Lldb-commits] [lldb] ebf9a99 - [lldb/Plugin] Reject WASM and Hexagon in DynamicLoaderStatic

Author: Jonas Devlieghere Date: 2020-02-18T13:29:34-08:00 New Revision: ebf9a99bbdcd88f15f16480f4d9b8f39d280f105 URL: https://github.com/llvm/llvm-project/commit/ebf9a99bbdcd88f15f16480f4d9b8f39d280f105 DIFF: https://github.com/llvm/llvm-project/commit/ebf9a99bbdcd88f15f16480f4d9b8f39d280f105.d

[Lldb-commits] [PATCH] D74780: [lldb/Plugin] Reject WASM and Hexagon in DynamicLoaderStatic

paolosev accepted this revision. paolosev added a comment. This revision is now accepted and ready to land. In D74780#1881297 , @JDevlieghere wrote: > Sorting the plugins so the static loader is initialized before the WASM > loader should exercise this c

[Lldb-commits] [PATCH] D74780: [lldb/Plugin] Reject WASM and Hexagon in DynamicLoaderStatic

JDevlieghere added a comment. Sorting the plugins so the static loader is initialized before the WASM loader should exercise this code path. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74780/new/ https://reviews.llvm.org/D74780 ___

[Lldb-commits] [PATCH] D74780: [lldb/Plugin] Reject WASM and Hexagon in DynamicLoaderStatic

clayborg added a comment. LGTM. Any way to test this somehow? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74780/new/ https://reviews.llvm.org/D74780 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [lldb] 2d146aa - [lldb/Plugin] Generate LLDB_PLUGIN_DECLARE with CMake

Author: Jonas Devlieghere Date: 2020-02-18T11:29:56-08:00 New Revision: 2d146aa2a2cdef330877b511b54886823e71f92c URL: https://github.com/llvm/llvm-project/commit/2d146aa2a2cdef330877b511b54886823e71f92c DIFF: https://github.com/llvm/llvm-project/commit/2d146aa2a2cdef330877b511b54886823e71f92c.d

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb marked an inline comment as done. hhb added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:298 +llvm::sys::path::append(path, lldb_python_home); +llvm::sys::path::remove_dots(path, /* remove_dot_dots = */

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

JDevlieghere added a comment. I went through the DYLD plugins and only the WASM and Hexagon plugin check the ArchType rather than the OSType, so I've created a patch to explicitly reject those in the DynamicLoaderStatic plugin: https://reviews.llvm.org/D74780 Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D74780: [lldb/Plugin] Reject WASM and Hexagon in DynamicLoaderStatic

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, ted, paolosev. Herald added subscribers: abidh, sunfish, aheejin. Herald added a project: LLDB. The WASM and Hexagon plugin check the ArchType rather than the OSType, so explicitly reject those in the DynamicLoade

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb added a comment. > Can we maybe rename it to something like that? LLDB_RELOCATABLE_PYTHON is misleading. I'd be happy to rename it. But that may break people who already set this flag. Is there a standard procedure to do this? Maybe add the new one and remove the old one a year later? Or m

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245211. hhb added a comment. Fix comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/source/Plugins/ScriptInterpre

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245206. hhb marked 5 inline comments as done. hhb added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

clayborg added a comment. If we switch to auto registration of plug-in in the near future there are many things we need to watch out for and some notion of ordering needs to happen. A few examples: - SymbolFileDWARFDebugMap and SymbolFileDWARF. Right now SymbolFileDWARF comes first and will cl

[Lldb-commits] [lldb] 884a589 - [lldb/Plugin] Unconditionally initialize DynamicLoaderDarwinKernel

Author: Jonas Devlieghere Date: 2020-02-18T10:32:06-08:00 New Revision: 884a58948b1a666910dcf1408d3d792fbd486012 URL: https://github.com/llvm/llvm-project/commit/884a58948b1a666910dcf1408d3d792fbd486012 DIFF: https://github.com/llvm/llvm-project/commit/884a58948b1a666910dcf1408d3d792fbd486012.d

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a comment. In D72751#1880975 , @clayborg wrote: > The triple clearly has an environment set of "wasm" so it should be easy to > detect this in the DynamicLoaderStatic and stop it from saying it can handle > it. The main issue then is do we h

Re: [Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

Yes, I don't think you have to solve this problem to make the suggested change. I think a lot of folks would appreciate the effort it would take to make names in backtraces more readable. Sometimes, particularly when you use function objects and iterators in combination, the names are insane

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

clayborg added a comment. In D72751#1880120 , @labath wrote: > I think we should just have DynamicLoaderStatic disqualify itself for wasm > files -- using it will never work there, so why should it pretend to support > them... The triple clearly has an

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. I am not sure this was the cause of the failure, but other than your patches, there was only one other change in the first failing build. I have not had time to fully investigate yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://re

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. In D73534#1880790 , @stella.stamenova wrote: > I am not sure this was the cause of the failure, but other than your patches, > there was only one other change in the first failing build. I have not had > time to fully i

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro updated this revision to Diff 245123. djtodoro added a comment. -Addressing the latest comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/CC1Option

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. It looks like this broke the windows lldb bot: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13902 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ ll

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Thanks for reporting that, are you sure this was the cause of the failure? I'll revert this while investigate, but it does not seem to me this is related to this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. I’ve already reverted the patch, but I’ll reland it again tomorrow. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D74690: Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie()

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa3e99dc859f: [lldb] [nfc] Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie() (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D74690?vs=244976&id=245185#toc Re

[Lldb-commits] [lldb] aa3e99d - [lldb] [nfc] Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie()

Author: Jan Kratochvil Date: 2020-02-18T18:09:39+01:00 New Revision: aa3e99dc859febba398925afeefb118403e15ab9 URL: https://github.com/llvm/llvm-project/commit/aa3e99dc859febba398925afeefb118403e15ab9 DIFF: https://github.com/llvm/llvm-project/commit/aa3e99dc859febba398925afeefb118403e15ab9.diff

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat updated this revision to Diff 245167. PatriosTheGreat added a comment. In this revision I fix value_regnums and invalidate_regnums serialization in target.xml. However I'm not so sure that this is the cause of problem with ARM tests. >From tests log it seems like there are some u

[Lldb-commits] [lldb] 2bf44d1 - Revert "Reland "[DebugInfo] Enable the debug entry values feature by default""

Author: Djordje Todorovic Date: 2020-02-18T16:38:11+01:00 New Revision: 2bf44d11cb42a952bdeb778210d8b3e737f0b96e URL: https://github.com/llvm/llvm-project/commit/2bf44d11cb42a952bdeb778210d8b3e737f0b96e DIFF: https://github.com/llvm/llvm-project/commit/2bf44d11cb42a952bdeb778210d8b3e737f0b96e.d

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

jarin added a comment. In D74759#1880499 , @labath wrote: > I like this idea a lot, in principle. It is much simpler than a full blown > interval tree, and it should give us similar performance characteristics. > > Have you done a proper complexity analys

[Lldb-commits] [lldb] b807a28 - [lldb] Merge RangeArray and RangeVector

Author: Pavel Labath Date: 2020-02-18T15:22:55+01:00 New Revision: b807a28787638f36a907f6f3ee832b840d1be08c URL: https://github.com/llvm/llvm-project/commit/b807a28787638f36a907f6f3ee832b840d1be08c DIFF: https://github.com/llvm/llvm-project/commit/b807a28787638f36a907f6f3ee832b840d1be08c.diff

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

labath added a comment. I like this idea a lot, in principle. It is much simpler than a full blown interval tree, and it should give us similar performance characteristics. Have you done a proper complexity analysis here? I doubt the `O(log n)` claim is true in general. It would have to be at l

[Lldb-commits] [lldb] a82d3e8 - Reland "[DebugInfo] Enable the debug entry values feature by default"

Author: Djordje Todorovic Date: 2020-02-18T14:41:08+01:00 New Revision: a82d3e8a6e67473c94a5ce6345372748e9b61718 URL: https://github.com/llvm/llvm-project/commit/a82d3e8a6e67473c94a5ce6345372748e9b61718 DIFF: https://github.com/llvm/llvm-project/commit/a82d3e8a6e67473c94a5ce6345372748e9b61718.d

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

jarin added a comment. Thanks for putting this together, some comments below. Let us see what Pavel thinks. Comment at: lldb/include/lldb/Utility/RangeMap.h:634 + // We can treat the vector as a flattened BST, augmenting it with upper bounds (max of + // range endpoints)

[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

This revision was automatically updated to reflect the committed changes. Closed by commit rG40b2c7f29b44: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

teemperor added a comment. In D74478#1874746 , @jingham wrote: > The only hesitation I have about this is if we are still printing this noise > in demangled names, then the name of the type you see for a variable will be > different from what you see whe

[Lldb-commits] [lldb] 40b2c7f - [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

Author: Raphael Isemann Date: 2020-02-18T13:25:31+01:00 New Revision: 40b2c7f29b44e3c3e171a04593ac650aaf7c6ae6 URL: https://github.com/llvm/llvm-project/commit/40b2c7f29b44e3c3e171a04593ac650aaf7c6ae6 DIFF: https://github.com/llvm/llvm-project/commit/40b2c7f29b44e3c3e171a04593ac650aaf7c6ae6.dif

Re: [Lldb-commits] [PATCH] D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

The test was passing unexpectedly, I already removed XFAIL decorator. -Original Message- From: Raphael “Teemperor” Isemann Sent: Tuesday, February 18, 2020 3:20 PM To: reviews+d74556+public+411e87b2a9392...@reviews.llvm.org Cc: Tatyana Krasnukha ; Jonas Devlieghere ; jing...@apple.com;

Re: [Lldb-commits] [PATCH] D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

Thanks! > On Feb 18, 2020, at 1:24 PM, Tatyana Krasnukha > wrote: > > The test was passing unexpectedly, I already removed XFAIL decorator. > > -Original Message- > From: Raphael “Teemperor” Isemann > Sent: Tuesday, February 18, 2020 3:20 PM > To: reviews+d74556+public+411e87b2a9392.

Re: [Lldb-commits] [PATCH] D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

I assume this is causing the test to fail on Windows? http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13896 > On 18. Feb 2020, at 12:26, Tatyana Krasnukha via Phabricator > wrote: > > tatyana-krasnukha closed this revision. > tatyana-krasnukha added a comment. > > Closed by co

[Lldb-commits] [lldb] db23825 - [lldb][test] Remove expected failure decorator from test_copy_from_dummy_target (TestScriptedResolver)

Author: Tatyana Krasnukha Date: 2020-02-18T15:04:29+03:00 New Revision: db23825970b021d0b5302d43aa5355c295c133d9 URL: https://github.com/llvm/llvm-project/commit/db23825970b021d0b5302d43aa5355c295c133d9 DIFF: https://github.com/llvm/llvm-project/commit/db23825970b021d0b5302d43aa5355c295c133d9.d

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar created this revision. unnar added reviewers: labath, teemperor. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Since RangeDataVector is assumed to always be sorted we can treat it as an flattened BST and augment it with additional information about the

[Lldb-commits] [PATCH] D74558: [lldb] Make shared_from_this-related code safer

tatyana-krasnukha closed this revision. tatyana-krasnukha added a comment. Closed by commit b624b7dfd087 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74558/new/ https://reviews.llvm.org/D74

[Lldb-commits] [PATCH] D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

tatyana-krasnukha closed this revision. tatyana-krasnukha added a comment. Closed by commit 185ef697ef5c Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74556/new/ https://reviews.llvm.org/D74

[Lldb-commits] [lldb] 7fb0679 - [lldb][NFC] Remove unused parameter

Author: Tatyana Krasnukha Date: 2020-02-18T13:49:08+03:00 New Revision: 7fb06796abfd54878378b65456d567169d409bb3 URL: https://github.com/llvm/llvm-project/commit/7fb06796abfd54878378b65456d567169d409bb3 DIFF: https://github.com/llvm/llvm-project/commit/7fb06796abfd54878378b65456d567169d409bb3.d

[Lldb-commits] [lldb] b624b7d - [lldb] Make shared_from_this-related code safer

Author: Tatyana Krasnukha Date: 2020-02-18T13:49:07+03:00 New Revision: b624b7dfd087809fb58bff0737750e75375fe450 URL: https://github.com/llvm/llvm-project/commit/b624b7dfd087809fb58bff0737750e75375fe450 DIFF: https://github.com/llvm/llvm-project/commit/b624b7dfd087809fb58bff0737750e75375fe450.d

[Lldb-commits] [lldb] 185ef69 - [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

Author: Tatyana Krasnukha Date: 2020-02-18T13:49:07+03:00 New Revision: 185ef697ef5c60d7a5c801925e6abdad52226c2b URL: https://github.com/llvm/llvm-project/commit/185ef697ef5c60d7a5c801925e6abdad52226c2b DIFF: https://github.com/llvm/llvm-project/commit/185ef697ef5c60d7a5c801925e6abdad52226c2b.d

[Lldb-commits] [lldb] 3f0661b - [lldb][NFC] Fix compilation of SymbolFilePDBTests.cpp after FindNamespace API change

Author: Raphael Isemann Date: 2020-02-18T11:25:12+01:00 New Revision: 3f0661b5e7176e7447ae11ef47195dfe31ab1029 URL: https://github.com/llvm/llvm-project/commit/3f0661b5e7176e7447ae11ef47195dfe31ab1029 DIFF: https://github.com/llvm/llvm-project/commit/3f0661b5e7176e7447ae11ef47195dfe31ab1029.dif

[Lldb-commits] [PATCH] D74310: [lldb] Don't model std::atomic as a transparent data structure in the data formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rG51d8c598331b: [lldb] Don't model std::atomic as a transparent data structure in the data… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D74310: [lldb] Don't model std::atomic as a transparent data structure in the data formatter

teemperor updated this revision to Diff 245109. teemperor added a comment. - Expand tests as suggested by Shafik (thanks!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74310/new/ https://reviews.llvm.org/D74310 Files: lldb/source/Plugins/Language/CPlusPlus/LibCxxAtomic.cpp lldb/t

[Lldb-commits] [lldb] 51d8c59 - [lldb] Don't model std::atomic as a transparent data structure in the data formatter

Author: Raphael Isemann Date: 2020-02-18T11:22:12+01:00 New Revision: 51d8c598331b25568b38691575c39729ae81a059 URL: https://github.com/llvm/llvm-project/commit/51d8c598331b25568b38691575c39729ae81a059 DIFF: https://github.com/llvm/llvm-project/commit/51d8c598331b25568b38691575c39729ae81a059.dif

[Lldb-commits] [PATCH] D74690: Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D74690#1879121 , @jankratochvil wrote: > Sorry for that `DenseMap::insert`, I see it is the same as `std::map`, I > should study `DenseMap` more.

[Lldb-commits] [PATCH] D74723: [lldb/DWARF] Support the debug_str_offsets section in dwp files

This revision was automatically updated to reflect the committed changes. Closed by commit rG00539d8b6425: [lldb/DWARF] Support the debug_str_offsets section in dwp files (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74723/new/

[Lldb-commits] [lldb] 00539d8 - [lldb/DWARF] Support the debug_str_offsets section in dwp files

Author: Pavel Labath Date: 2020-02-18T11:02:34+01:00 New Revision: 00539d8b6425529240d970082c23e6ee1263669b URL: https://github.com/llvm/llvm-project/commit/00539d8b6425529240d970082c23e6ee1263669b DIFF: https://github.com/llvm/llvm-project/commit/00539d8b6425529240d970082c23e6ee1263669b.diff

[Lldb-commits] [lldb] 7d13812 - [lldb] Fix compilation of SymbolFilePDBTests.cpp after FindTypes API change

Author: Raphael Isemann Date: 2020-02-18T10:52:02+01:00 New Revision: 7d13812329ba8aadebc27f30613e79b0ca1bec5f URL: https://github.com/llvm/llvm-project/commit/7d13812329ba8aadebc27f30613e79b0ca1bec5f DIFF: https://github.com/llvm/llvm-project/commit/7d13812329ba8aadebc27f30613e79b0ca1bec5f.dif

[Lldb-commits] [lldb] 0863f67 - [lldb] Remove DataExtractor::GetPointer

Author: Pavel Labath Date: 2020-02-18T10:38:41+01:00 New Revision: 0863f6757953684400162f2ad418f3e8e28af278 URL: https://github.com/llvm/llvm-project/commit/0863f6757953684400162f2ad418f3e8e28af278 DIFF: https://github.com/llvm/llvm-project/commit/0863f6757953684400162f2ad418f3e8e28af278.diff

[Lldb-commits] [lldb] f14680c - [lldb][NFC] Documention that OptionDefinition::completion_type contains enum values

Author: Raphael Isemann Date: 2020-02-18T10:33:38+01:00 New Revision: f14680ce29663d098593e2f4e0eea96dbcaae0fb URL: https://github.com/llvm/llvm-project/commit/f14680ce29663d098593e2f4e0eea96dbcaae0fb DIFF: https://github.com/llvm/llvm-project/commit/f14680ce29663d098593e2f4e0eea96dbcaae0fb.dif

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

labath added a comment. Please update the current one to keep the context together. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] 0ba247b - [lldb] Remove the mutable specifier from DataExtractor's member

Author: Pavel Labath Date: 2020-02-18T10:26:43+01:00 New Revision: 0ba247bc21f8aed000e649882e6e360fb90e81e5 URL: https://github.com/llvm/llvm-project/commit/0ba247bc21f8aed000e649882e6e360fb90e81e5 DIFF: https://github.com/llvm/llvm-project/commit/0ba247bc21f8aed000e649882e6e360fb90e81e5.diff

[Lldb-commits] [lldb] 5783587 - [lldb][NFC] Modernize documentation in lldb-private-types.h

Author: Raphael Isemann Date: 2020-02-18T10:25:27+01:00 New Revision: 57835875bd4346ba00f7f6ded5e1382e26b3fd5c URL: https://github.com/llvm/llvm-project/commit/57835875bd4346ba00f7f6ded5e1382e26b3fd5c DIFF: https://github.com/llvm/llvm-project/commit/57835875bd4346ba00f7f6ded5e1382e26b3fd5c.dif

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

labath added a reviewer: ted. labath added a comment. + ted, who I believe has a stake in the relocatable python game Your use case seems reasonable, but I find it hard to understand the meanings of the options in this patch. IIUC, there are now two ways to create an lldb with a "relocatable" p

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat added a comment. Hi Muhammad, Thank you for finding this issue. After I fix that, could I update current review or should I create new one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217

[Lldb-commits] [lldb] 8ffea27 - [lldb] Refactor and test TypeSystemClang::GetEnumerationIntegerType

Author: Raphael Isemann Date: 2020-02-18T09:52:49+01:00 New Revision: 8ffea27ae42ad210b9162c3afc91c61dfb82acf7 URL: https://github.com/llvm/llvm-project/commit/8ffea27ae42ad210b9162c3afc91c61dfb82acf7 DIFF: https://github.com/llvm/llvm-project/commit/8ffea27ae42ad210b9162c3afc91c61dfb82acf7.dif

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d6da329dee1: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin (authored by JDevlieghere). Herald added a subscriber: jrtc27. Changed prior to commit: https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D74743: [lldb] Make header guards consistent across LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rGcdc514e4c67f: [lldb] Update header guards to be consistent and compliant with LLVM (NFC) (authored by JDevlieghere). Herald added a subscriber: jrtc27. Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [PATCH] D74607: [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9568a95493a: [lldb][NFC] Make all CompilerDeclContext parameters references instead of… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 813ca53 - [lldb][NFC] Document TypeSystemClang

Author: Raphael Isemann Date: 2020-02-18T09:00:03+01:00 New Revision: 813ca53fdea130a23e302ea2afecaa5134def6db URL: https://github.com/llvm/llvm-project/commit/813ca53fdea130a23e302ea2afecaa5134def6db DIFF: https://github.com/llvm/llvm-project/commit/813ca53fdea130a23e302ea2afecaa5134def6db.dif