[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

shafik added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp:23 +}; +static struct { + uint64_t cap = 5; This is much nicer then the previous raw arrays and self-documents

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

shafik added a comment. Since we are doing the same test all over `m_addr_size >= 1 && m_addr_size <= 8` can we just make it a function and avoid the repetition and potential erroneous updating later on that does not fix them all? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73969/new

[Lldb-commits] [lldb] 843a0f9 - Enhance debugserver's err reporting on attach fails

Author: Jason Molenda Date: 2020-02-04T19:46:55-08:00 New Revision: 843a0f97717a006fd21cd89fd229b064506e5d05 URL: https://github.com/llvm/llvm-project/commit/843a0f97717a006fd21cd89fd229b064506e5d05 DIFF: https://github.com/llvm/llvm-project/commit/843a0f97717a006fd21cd89fd229b064506e5d05.diff

[Lldb-commits] [lldb] b453caf - [lldb/Reproducers] Change the way we instrument void* arguments

Author: Jonas Devlieghere Date: 2020-02-04T19:05:13-08:00 New Revision: b453caf1112f0e89eddcd03aa667368fab6d13d6 URL: https://github.com/llvm/llvm-project/commit/b453caf1112f0e89eddcd03aa667368fab6d13d6 DIFF: https://github.com/llvm/llvm-project/commit/b453caf1112f0e89eddcd03aa667368fab6d13d6.d

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. LGTM, but Raphael should have a chance to take another look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73860/new/ https://reviews.llvm.org/D73860 ___ ll

[Lldb-commits] [PATCH] D74018: [lldb/LibCxx] Have ExtractLibcxxStringInfo return an Optional result, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks for doing this! Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:507 size_mode_value = (size_mode->GetValueAsUnsigned(0)); short_m

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev updated this revision to Diff 242494. paolosev added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72751/new/ https://reviews.llvm.org/D72751 Files: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_cl

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

vsk updated this revision to Diff 242495. vsk marked an inline comment as done. vsk added a comment. - Make a bool const. - Split off other refactoring into https://reviews.llvm.org/D74018. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73860/new/ https://reviews.llvm.org/D73860 Files:

[Lldb-commits] [PATCH] D74018: [lldb/LibCxx] Have ExtractLibcxxStringInfo return an Optional result, NFC

vsk created this revision. vsk added a reviewer: JDevlieghere. ... and a few other minor simplifications. https://reviews.llvm.org/D74018 Files: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp Index: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:474 // consume static bool ExtractLibcxxStringInfo(ValueObject &valobj, ValueObjectSP &location_sp, Definitely something for a

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

vsk updated this revision to Diff 242479. vsk added a comment. Per offline feedback from Jonas, label variables `const` where applicable and get rid of the ScopeExits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73860/new/ https://reviews.llvm.org/D73860 Files: lldb/packages/Pyth

[Lldb-commits] [PATCH] D74010: Fix BroadcasterManager::RemoveListener to really remove the listener

This revision was automatically updated to reflect the committed changes. Closed by commit rG50d2d33b8ef5: Fix BroadcasterManager::RemoveListener to really remove the listener (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74010/new

[Lldb-commits] [lldb] 50d2d33 - Fix BroadcasterManager::RemoveListener to really remove the listener

Author: Reid Kleckner Date: 2020-02-04T17:19:44-08:00 New Revision: 50d2d33b8ef530fbee369cbf8e7ea4479597742d URL: https://github.com/llvm/llvm-project/commit/50d2d33b8ef530fbee369cbf8e7ea4479597742d DIFF: https://github.com/llvm/llvm-project/commit/50d2d33b8ef530fbee369cbf8e7ea4479597742d.diff

[Lldb-commits] [PATCH] D74010: Fix BroadcasterManager::RemoveListener to really remove the listener

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 1 errors and 0 warnings . 0 of them are added as review

[Lldb-commits] [PATCH] D74010: Fix BroadcasterManager::RemoveListener to really remove the listener

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks for fixing this, Reid! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74010/new/ https://reviews.llvm.org/D74010 __

[Lldb-commits] [PATCH] D74010: Fix BroadcasterManager::RemoveListener to really remove the listener

rnk created this revision. rnk added reviewers: JDevlieghere, amccarth. Herald added a project: LLDB. This appears to be a real bug caught by -Wunused-value. std::find_if doesn't modify the underlying collection, it just returns an iterator pointing to the matching element. Repository: rG LLVM

[Lldb-commits] [lldb] 7e02dc3 - [lldb] Fix -Wdocumentation warnings

Author: Jonas Devlieghere Date: 2020-02-04T16:44:38-08:00 New Revision: 7e02dc3f2407eacf89c63763fa1f592be1a61dd3 URL: https://github.com/llvm/llvm-project/commit/7e02dc3f2407eacf89c63763fa1f592be1a61dd3 DIFF: https://github.com/llvm/llvm-project/commit/7e02dc3f2407eacf89c63763fa1f592be1a61dd3.d

[Lldb-commits] [PATCH] D74001: Fix after c25938d

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb0d2d455f56: Fix after c25938d (authored by amccarth). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D74001?vs=242440&id=242465#toc Repository: rG LLVM Github Monore

[Lldb-commits] [lldb] fb0d2d4 - Fix after c25938d

Author: Adrian McCarthy Date: 2020-02-04T16:37:22-08:00 New Revision: fb0d2d455f56bca239041c8d7ad7b57da1087b35 URL: https://github.com/llvm/llvm-project/commit/fb0d2d455f56bca239041c8d7ad7b57da1087b35 DIFF: https://github.com/llvm/llvm-project/commit/fb0d2d455f56bca239041c8d7ad7b57da1087b35.dif

[Lldb-commits] [lldb] 7ac9443 - [lldb/Reproducers] Change record logging to mirror replay logging

Author: Jonas Devlieghere Date: 2020-02-04T16:24:38-08:00 New Revision: 7ac9443002949a01c992691760588eaaf88e4f41 URL: https://github.com/llvm/llvm-project/commit/7ac9443002949a01c992691760588eaaf88e4f41 DIFF: https://github.com/llvm/llvm-project/commit/7ac9443002949a01c992691760588eaaf88e4f41.d

[Lldb-commits] [lldb] ddf8146 - [lldb/Reproducers] Add underscore to varaibles in LLDB_RECORD macros

Author: Jonas Devlieghere Date: 2020-02-04T16:27:55-08:00 New Revision: ddf814688bd4b2268e8648999b23352e7c6521cb URL: https://github.com/llvm/llvm-project/commit/ddf814688bd4b2268e8648999b23352e7c6521cb DIFF: https://github.com/llvm/llvm-project/commit/ddf814688bd4b2268e8648999b23352e7c6521cb.d

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

vsk updated this revision to Diff 242461. vsk added a reviewer: LLDB. vsk added a comment. - Enhance test coverage with several more examples of garbage long-mode std::strings. - In several cases, when we detected an invalid string, we would fall back to spewing the "raw mode" representation of

[Lldb-commits] [lldb] 0c86dfb - Fix -Wunused-result warnings in LLDB

Author: Reid Kleckner Date: 2020-02-04T15:58:38-08:00 New Revision: 0c86dfb86de53e74f376c3f2800fc114afaae2ba URL: https://github.com/llvm/llvm-project/commit/0c86dfb86de53e74f376c3f2800fc114afaae2ba DIFF: https://github.com/llvm/llvm-project/commit/0c86dfb86de53e74f376c3f2800fc114afaae2ba.diff

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

labath added a comment. I think this is a much better approach than the other do-in-all-together patch -- we should take this one step at a time. I do have one question though. Will the DataExtractor actually do something reasonable for non-power-of-2 sizes (5,6,7) ? If yes, then great -- if no

[Lldb-commits] [lldb] fc0ba63 - [lldb] Rename Type::ResolveClangType to Type::ResolveCompilerType

Author: Alex Langford Date: 2020-02-04T15:40:48-08:00 New Revision: fc0ba63f8691eb98e9f7d670f23b145c66deec7e URL: https://github.com/llvm/llvm-project/commit/fc0ba63f8691eb98e9f7d670f23b145c66deec7e DIFF: https://github.com/llvm/llvm-project/commit/fc0ba63f8691eb98e9f7d670f23b145c66deec7e.diff

[Lldb-commits] [PATCH] D74001: Fix after c25938d

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks great to me, thanks! If it's easy to add on, could you remove the xfail from lldb/packages/Python/lldbsuite/test/commands/add-dsym/uuid/TestAddDsymCommand.py in the sa

[Lldb-commits] [lldb] 48b8e3b - [lldb] Delete commented-out code

Author: Alex Langford Date: 2020-02-04T15:33:06-08:00 New Revision: 48b8e3be51c7fa2bda904bc495af47c7b368e748 URL: https://github.com/llvm/llvm-project/commit/48b8e3be51c7fa2bda904bc495af47c7b368e748 DIFF: https://github.com/llvm/llvm-project/commit/48b8e3be51c7fa2bda904bc495af47c7b368e748.diff

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

labath added a comment. You should be able to test most (if not all) of this stuff without an actual process. lldb can display global variables, set breakpoints, resolve addresses, etc. without being connected to a debug stub. How do you normally generate the binaries with these kinds of addres

[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin

labath added a comment. This seems ok to me. I am happy with it if Kamil is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73802/new/ https://reviews.llvm.org/D73802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D74001: Fix after c25938d

amccarth created this revision. amccarth added reviewers: jasonmolenda, clayborg. My refactor caused some changes in error reporting that TestAddDsymCommand.py was checking, so this restores some of the changes to preserve the old behavior. Putting this through review rather than committing dire

[Lldb-commits] [lldb] a5f1fff - [lldb/Reproducers] Add missing SBFile methods to the registry

Author: Jonas Devlieghere Date: 2020-02-04T15:10:03-08:00 New Revision: a5f1fff9ddf07755c224ce1e84ed009ad9a232f9 URL: https://github.com/llvm/llvm-project/commit/a5f1fff9ddf07755c224ce1e84ed009ad9a232f9 DIFF: https://github.com/llvm/llvm-project/commit/a5f1fff9ddf07755c224ce1e84ed009ad9a232f9.d

[Lldb-commits] [lldb] 8b79bed - [lldb] Remove unused references to ClangExpressionDeclMap

Author: Alex Langford Date: 2020-02-04T14:41:24-08:00 New Revision: 8b79bed0f3c90c539865f2e55f664daa7930865d URL: https://github.com/llvm/llvm-project/commit/8b79bed0f3c90c539865f2e55f664daa7930865d DIFF: https://github.com/llvm/llvm-project/commit/8b79bed0f3c90c539865f2e55f664daa7930865d.diff

[Lldb-commits] [PATCH] D73935: [lldb] Remove clang classes from lldb-forward.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c9ebdd3d6ae: [lldb] Remove clang classes from lldb-forward.h (authored by xiaobai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73935/new/ https://review

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it.

jasonmolenda added a comment. I don't know about checking for NO_XPC_SERVICES for these -- they're LaunchServices/AppleScript related. As Vedant mentioned with the earlier check, I think `TARGET_OS_EMBEDDED` rather than an architecture check would be the most correct change; these services are

[Lldb-commits] [lldb] 7c9ebdd - [lldb] Remove clang classes from lldb-forward.h

Author: Alex Langford Date: 2020-02-04T14:23:58-08:00 New Revision: 7c9ebdd3d6ae405dc6702e544453a51862daf948 URL: https://github.com/llvm/llvm-project/commit/7c9ebdd3d6ae405dc6702e544453a51862daf948 DIFF: https://github.com/llvm/llvm-project/commit/7c9ebdd3d6ae405dc6702e544453a51862daf948.diff

[Lldb-commits] [PATCH] D73808: [lldb/TypeSystemClang] Supply trivial TypeSourceInfo to NonTypeTemplateParmDecl::Create

vsk added a comment. The original sanitizer report /does/ show UB in the NonTypeTemplateParmDecl static constructor: * thread #1, queue = 'com.apple.main-thread', stop reason = Null pointer use * fram

[Lldb-commits] [PATCH] D73808: [lldb/TypeSystemClang] Supply trivial TypeSourceInfo to NonTypeTemplateParmDecl::Create

vsk added a comment. It probably makes sense to land this and D73946 as a defensive measure, without any test change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73808/new/ https://reviews.llvm.org/D73808 _

Re: [Lldb-commits] [lldb] 1048000 - [lldb] [testsuite] Fixup: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

Thanks Jan! Sorry for not getting in touch about this earlier. > On Feb 4, 2020, at 1:52 PM, Jan Kratochvil wrote: > > Hi Jason, > > On Tue, 04 Feb 2020 22:23:52 +0100, Jason Molenda wrote: >> Hi Jan, I'm not sure which upstream change this was working around > > It was not up-to-date with:

[Lldb-commits] [lldb] f37b62e - Re-land "[lldb] [testsuite] generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML"

Author: Jonas Devlieghere Date: 2020-02-04T13:59:29-08:00 New Revision: f37b62eccecadfe3248c06a6bd42e8a062a1dc61 URL: https://github.com/llvm/llvm-project/commit/f37b62eccecadfe3248c06a6bd42e8a062a1dc61 DIFF: https://github.com/llvm/llvm-project/commit/f37b62eccecadfe3248c06a6bd42e8a062a1dc61.d

[Lldb-commits] [lldb] c21b71c - [lldb/Unittest] Fix the modules build by including TypeSystemClang.h

Author: Jonas Devlieghere Date: 2020-02-04T14:05:15-08:00 New Revision: c21b71c1ba5cbfd8de755a067bedc5ca40a66a20 URL: https://github.com/llvm/llvm-project/commit/c21b71c1ba5cbfd8de755a067bedc5ca40a66a20 DIFF: https://github.com/llvm/llvm-project/commit/c21b71c1ba5cbfd8de755a067bedc5ca40a66a20.d

[Lldb-commits] [PATCH] D73808: [lldb/TypeSystemClang] Supply trivial TypeSourceInfo to NonTypeTemplateParmDecl::Create

vsk added a comment. .. and I can no longer reproduce the sanitizer exception while debugging a Debug clang binary, as I rebased recently and some source change in clang hides the bug. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73808/new/ https://reviews.llvm.org/D73808

Re: [Lldb-commits] [lldb] 1048000 - [lldb] [testsuite] Fixup: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

Hi Jason, On Tue, 04 Feb 2020 22:23:52 +0100, Jason Molenda wrote: > Hi Jan, I'm not sure which upstream change this was working around It was not up-to-date with: commit 8be30215feeff1d82fe2bde0c9fb0e6cd1bfc15c Author: Alex Langford Date: Wed Jan 29 11:59:28 2020 -0800 [lldb] Move clang-

[Lldb-commits] [lldb] b73f8c5 - Revert: [lldb] [testsuite] generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

Author: Jan Kratochvil Date: 2020-02-04T22:48:27+01:00 New Revision: b73f8c53d8af1fbf6e0e2eac0c54c8dc0576ff39 URL: https://github.com/llvm/llvm-project/commit/b73f8c53d8af1fbf6e0e2eac0c54c8dc0576ff39 DIFF: https://github.com/llvm/llvm-project/commit/b73f8c53d8af1fbf6e0e2eac0c54c8dc0576ff39.diff

[Lldb-commits] [PATCH] D73808: [lldb/TypeSystemClang] Supply trivial TypeSourceInfo to NonTypeTemplateParmDecl::Create

vsk added a comment. In D73808#1856503 , @teemperor wrote: > Thanks for looking into this. I didn't get around to fix that myself yet. Out > of curiosity, how did you get this test to fail? When I apply just your > changes to the test (without the TypeSy

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

vsk added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp:29 +if (sizeof(std::string) == sizeof(garbage_string_sso)) + memcpy((void *)&garbage1, &garbage_string_sso, sizeof(std::st

[Lldb-commits] [PATCH] D73992: [lldb/Reproducers] Instrument SBFile

This revision was automatically updated to reflect the committed changes. Closed by commit rG2757f93a5a76: [lldb/Reproducers] Instrument SBFile (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73992/new/ https://reviews.llvm

[Lldb-commits] [lldb] 2757f93 - [lldb/Reproducers] Instrument SBFile

Author: Jonas Devlieghere Date: 2020-02-04T13:30:38-08:00 New Revision: 2757f93a5a76c5939dc5c1f7c23ee5d21ff6 URL: https://github.com/llvm/llvm-project/commit/2757f93a5a76c5939dc5c1f7c23ee5d21ff6 DIFF: https://github.com/llvm/llvm-project/commit/2757f93a5a76c5939dc5c1f7c23ee5d21ff6.d

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

vsk updated this revision to Diff 242417. vsk marked 5 inline comments as done. vsk added a comment. Address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73860/new/ https://reviews.llvm.org/D73860 Files: lldb/packages/Python/lldbsuite/test/functionalities/data-form

Re: [Lldb-commits] [lldb] 1048000 - [lldb] [testsuite] Fixup: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

Hi Jan, I'm not sure which upstream change this was working around - but the macos cmake bot has been failing since these changes went in, http://green.lab.llvm.org/green/job/lldb-cmake/ http://green.lab.llvm.org/green/job/lldb-cmake/7867/console In module 'lldb_TestingSupport_Symbol' import

[Lldb-commits] [PATCH] D73992: [lldb/Reproducers] Instrument SBFile

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a project: LLDB. Currently SBFile isn't really instrumented, which was causing trouble when capturing and replaying the Python test suite. The class is particularly tricky because one of its constructors take

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

Suppose we give the traditional message (making the users and the test happy) and then augment it with a little extra text to let developers figure out where it went wrong. symbol file '%s'%s does not match any existing module%s symbol file '%s'%s does not match any existing module%s (the symbo

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

The question isn't so much whether it makes a difference to the user than whether when somebody reports getting this error in a project that we can't get our hands on so all we have is the screen output (a very not uncommon circumstance for debuggers) the different error messages would be useful

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

I think the new error message will be harder for users to understand. When they try to add a dSYM that doesn't match any binary currently in the Target, the error message should make that clear so the user can realize that either (1) they picked the wrong dSYM, or (2) they thought a binary was

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

Given that the UUIDs in the test don't actually match, I think it's reasonable for the error message to say it's not a match. I'm not sure detecting the problem in a different step of the process makes that much difference to the user that it warrants a different message. (I know it sounds like I

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

Seems like your change is more informative. Could we just fix the tests? Jim > On Feb 4, 2020, at 11:18 AM, Adrian McCarthy via lldb-commits > wrote: > > I see why the behavior is different, but I'm not sure whether the new > behavior is wrong. > > The old code nested a bunch of if-success

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

I see why the behavior is different, but I'm not sure whether the new behavior is wrong. The old code nested a bunch of if-success statements so that any failure would fall through to a default error message (the one the tests is expecting). The new code is a linear set of if-failure-return state

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

clayborg added a comment. To further clarify the issue with the "initialized" packet being sent too early: if it gets sent too early, then the breakpoints packets immediately follow and we will need a target to set the breakpoints in. This is why en empty target was created. If the target is no

[Lldb-commits] [lldb] e05af08 - [lldb/StackFrameList] Convert assert to defensive check in SynthesizeTailCallFrames

Author: Vedant Kumar Date: 2020-02-04T10:43:50-08:00 New Revision: e05af081bf7cbc738b2e4cdfa91054fff0153ce3 URL: https://github.com/llvm/llvm-project/commit/e05af081bf7cbc738b2e4cdfa91054fff0153ce3 DIFF: https://github.com/llvm/llvm-project/commit/e05af081bf7cbc738b2e4cdfa91054fff0153ce3.diff

[Lldb-commits] [lldb] 047c041 - [lldb/test] Skip TestBasicEntryValuesX86_64 due to llvm.org/PR44774

Author: Vedant Kumar Date: 2020-02-04T10:43:50-08:00 New Revision: 047c041277543564d482cdc297c4e82de0fd2758 URL: https://github.com/llvm/llvm-project/commit/047c041277543564d482cdc297c4e82de0fd2758 DIFF: https://github.com/llvm/llvm-project/commit/047c041277543564d482cdc297c4e82de0fd2758.diff

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

clayborg added a comment. We can do this in lldb-vscode.cpp. When I first made the lldb-vscode plug-in I was sending the "initialized" notification back to the IDE too early. This resulted in breakpoint packets being sent _before_ "launch" or "attach" packets. A good change would be to default

[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

vsk added a comment. In D73946#1857400 , @teemperor wrote: > In D73946#1857244 , @vsk wrote: > > > We have test coverage for this already, not sure why the sanitizer bot > > hasn't flagged this already: > > http:/

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it.

vsk added inline comments. Comment at: lldb/source/Host/macosx/objcxx/Host.mm:14 // On device doesn't have supporty for XPC. #if defined(__APPLE__) && (defined(__arm64__) || defined(__aarch64__)) #define NO_XPC_SERVICES 1 This is missing `__arm__`, right? Why

[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

teemperor added a comment. In D73946#1857244 , @vsk wrote: > We have test coverage for this already, not sure why the sanitizer bot hasn't > flagged this already: > http://lab.llvm.org:8080/coverage/coverage-reports/coverage/Users/buildslave/jenkins/work

[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

davide closed this revision. davide added a comment. Not relevant anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71316/new/ https://reviews.llvm.org/D71316 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D73974: [lldb] Improve debugging 32-bit programs on NetBSD/amd64

mgorny created this revision. mgorny added reviewers: labath, krytarowski. mgorny added a parent revision: D73802: [lldb] Introduce i386 support in NetBSD Process plugin. Implement detection of ELF binary format, and support for i386 register context on amd64 when a 32-bit executable is being deb

[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73946/new/ https://reviews.llvm.org/D73946 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

vsk added a comment. We have test coverage for this already, not sure why the sanitizer bot hasn't flagged this already: http://lab.llvm.org:8080/coverage/coverage-reports/coverage/Users/buildslave/jenkins/workspace/coverage/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp.h

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

Sorry. I can check this out this morning. I didn't have any test failures locally, but I'm guessing that test doesn't run on Windows. On Mon, Feb 3, 2020 at 6:43 PM Jason Molenda wrote: > I'm going to xfail it for tonight; we end up copying the base filename > into the ModuleSpec that we use f

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

shafik planned changes to this revision. shafik added a comment. Everyone has brought up great feedback, let me go back and revise this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73921/new/ https://reviews.llvm.org/D73921 ___ lldb-commi

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl updated this revision to Diff 242340. aykevl added a comment. Added a unit test. I think it would also be a good idea to test this by loading an AVR binary and connecting to a debugger (thus triggering this code), but I don't know how to add such a test. Suggestions would be appreciated.

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl created this revision. aykevl added reviewers: labath, dylanmckay, Andrzej. aykevl added projects: LLVM, LLDB. Herald added subscribers: lldb-commits, aprantl. aykevl updated this revision to Diff 242340. aykevl added a comment. Added a unit test. I think it would also be a good idea to te

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

aykevl added a comment. See D73969 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73961/new/ https://reviews.llvm.org/D73961 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

teemperor updated this revision to Diff 242339. teemperor edited the summary of this revision. teemperor added a comment. - Fix a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73946/new/ https://reviews.llvm.org/D73946 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang

[Lldb-commits] [PATCH] D73952: [lldb] Ignore type sugar in TypeSystemClang::GetPointerType

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73952/new/ https://reviews.llvm.org/D73952 ___ lldb-commits mail

[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin

mgorny updated this revision to Diff 242324. mgorny added a comment. Added tlsbase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73802/new/ https://reviews.llvm.org/D73802 Files: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp lldb/source/Plugins/Process/

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil added a comment. Fixed up by: rG104800084f6a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73279/new/ https://reviews.llvm.org/D73279 __

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

aykevl created this revision. aykevl added reviewers: granata.enrico, labath, dylanmckay, Andrzej. Herald added subscribers: llvm-commits, lldb-commits, hiraditya. Herald added projects: LLDB, LLVM. Addresses are usually two bytes in size on AVR, so make sure LLDB deals with that. --- I'm not s

[Lldb-commits] [lldb] 1048000 - [lldb] [testsuite] Fixup: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

Author: Jan Kratochvil Date: 2020-02-04T15:03:09+01:00 New Revision: 104800084f6a7033ef31a453f0015715f0fc390b URL: https://github.com/llvm/llvm-project/commit/104800084f6a7033ef31a453f0015715f0fc390b DIFF: https://github.com/llvm/llvm-project/commit/104800084f6a7033ef31a453f0015715f0fc390b.diff

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

This revision was automatically updated to reflect the committed changes. Closed by commit rG2926a651ba73: [lldb] [testsuite] generalize `DWARFASTParserClangTests` based on… (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[Lldb-commits] [lldb] 2926a65 - [lldb] [testsuite] generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

Author: Jan Kratochvil Date: 2020-02-04T14:33:29+01:00 New Revision: 2926a651ba7398514ca49970577d5c940a385f09 URL: https://github.com/llvm/llvm-project/commit/2926a651ba7398514ca49970577d5c940a385f09 DIFF: https://github.com/llvm/llvm-project/commit/2926a651ba7398514ca49970577d5c940a385f09.diff

[Lldb-commits] [lldb] 88cd49e - [lldb] Increase LINK_INTERFACE_MULTIPLICITY for Debug builds

Author: Jan Kratochvil Date: 2020-02-04T14:30:27+01:00 New Revision: 88cd49e941b9a24ff9df4c1ed7b6f771b13b701e URL: https://github.com/llvm/llvm-project/commit/88cd49e941b9a24ff9df4c1ed7b6f771b13b701e DIFF: https://github.com/llvm/llvm-project/commit/88cd49e941b9a24ff9df4c1ed7b6f771b13b701e.diff

[Lldb-commits] [PATCH] D73952: [lldb] Ignore type sugar in TypeSystemClang::GetPointerType

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Currently having a typedef for ObjC types is breaking member access in LLDB: typedef NSString Str; NSString *s; s.length; // OK Str *s; s.

[Lldb-commits] [lldb] bf4d73e - [lldb][NFC] Use correct Decl typedef in ClangASTSource

Author: Raphael Isemann Date: 2020-02-04T11:53:23+01:00 New Revision: bf4d73e6f3e93cf2c92691a44cff52afc025942d URL: https://github.com/llvm/llvm-project/commit/bf4d73e6f3e93cf2c92691a44cff52afc025942d DIFF: https://github.com/llvm/llvm-project/commit/bf4d73e6f3e93cf2c92691a44cff52afc025942d.dif

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

teemperor requested changes to this revision. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp:8 +// A corrupt libcxx string which points to garbage and has a crazy length. +

[Lldb-commits] [PATCH] D73808: [lldb/TypeSystemClang] Supply trivial TypeSourceInfo to NonTypeTemplateParmDecl::Create

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks for looking into this. I didn't get around to fix that myself yet. Out of curiosity, how did you get this test to fail? When I apply just your changes to the test (without the Typ

[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

teemperor created this revision. teemperor added reviewers: shafik, vsk. Herald added subscribers: lldb-commits, JDevlieghere, kristof.beyls. Herald added a project: LLDB. Follow up to an issue pointed out in the review of D73808 . Repository: rLLDB LLDB http