[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

2019-12-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 235092. JDevlieghere added a comment. Rebase after `can_reload` removal CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71825/new/ https://reviews.llvm.org/D71825 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp lldb/source/Plugins/S

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

2019-12-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:57 + + // Reload the module if requested. + if (llvm::Error e = Run( `s/ if requested//` CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1562511 - [lldb/ScriptInterpreter] Remove can_reload which is always true (NFC)

2019-12-22 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2019-12-22T21:36:03-08:00 New Revision: 1562511275fe1f002458194c085216cf9ae36d1f URL: https://github.com/llvm/llvm-project/commit/1562511275fe1f002458194c085216cf9ae36d1f DIFF: https://github.com/llvm/llvm-project/commit/1562511275fe1f002458194c085216cf9ae36d1f.d

[Lldb-commits] [lldb] b449d19 - build: use `find_package(Python3)` rather than `PYTHON_HOME`

2019-12-22 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2019-12-22T20:47:25-08:00 New Revision: b449d19e55888ab9554b04184c6d9716389820fd URL: https://github.com/llvm/llvm-project/commit/b449d19e55888ab9554b04184c6d9716389820fd DIFF: https://github.com/llvm/llvm-project/commit/b449d19e55888ab9554b04184c6d9716389820fd.

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

2019-12-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath. Herald added a project: LLDB. This implements the `command script import` command for Lua. Repository: rLLDB LLDB https://reviews.llvm.org/D71825 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp lldb/

[Lldb-commits] [PATCH] D71824: Add the 'start' and 'length' to the completions response. This will fix an issue where applying a completion 'foo.bar' to 'po foo.b' inserts the entire completion result

2019-12-22 Thread Ivan Hernandez via Phabricator via lldb-commits
ivanhernandez13 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71824 Files: lldb/tools/lldb-vscode/lldb-vscode.cpp Index: lldb/tools/lldb-vscode/lldb-vscode.cpp

[Lldb-commits] [lldb] bd5c8d1 - [lldb/ScriptInterpreter] Unify error message for command script import

2019-12-22 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2019-12-22T16:47:28-08:00 New Revision: bd5c8d167b7cce3290d755e29623d047c2ad8e3e URL: https://github.com/llvm/llvm-project/commit/bd5c8d167b7cce3290d755e29623d047c2ad8e3e DIFF: https://github.com/llvm/llvm-project/commit/bd5c8d167b7cce3290d755e29623d047c2ad8e3e.d

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

2019-12-22 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd closed this revision. compnerd added a comment. GIT 2046d72e916 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69535/new/ https://reviews.llvm.org/D69535

[Lldb-commits] [lldb] 2046d72 - build: improve python checks for Windows

2019-12-22 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2019-12-22T13:57:46-08:00 New Revision: 2046d72e91670114625c87e122db6e013ba089d5 URL: https://github.com/llvm/llvm-project/commit/2046d72e91670114625c87e122db6e013ba089d5 DIFF: https://github.com/llvm/llvm-project/commit/2046d72e91670114625c87e122db6e013ba089d5.

[Lldb-commits] [PATCH] D71235: [lldb/Lua] Generate Lua Bindings and Make Them Available to the Script Interpreter

2019-12-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/CMakeLists.txt:55 - add_subdirectory(scripts) endif () mstorsjo wrote: > This change here (unconditionally including the scripts subdir) made SWIG a > hard de

[Lldb-commits] [lldb] 218601a - [lldb] Remove unused CompilerDeclContext::IsStructUnionOrClass

2019-12-22 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2019-12-22T14:01:37+01:00 New Revision: 218601ada1496f920fadddae9a21f7d6ccf48da5 URL: https://github.com/llvm/llvm-project/commit/218601ada1496f920fadddae9a21f7d6ccf48da5 DIFF: https://github.com/llvm/llvm-project/commit/218601ada1496f920fadddae9a21f7d6ccf48da5.dif

[Lldb-commits] [PATCH] D71235: [lldb/Lua] Generate Lua Bindings and Make Them Available to the Script Interpreter

2019-12-22 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added inline comments. Comment at: lldb/CMakeLists.txt:55 - add_subdirectory(scripts) endif () This change here (unconditionally including the scripts subdir) made SWIG a hard dependency, even if both lua and python are disabled. I pushed a commit