[Lldb-commits] [PATCH] D71231: Replace redundant code in FormatManager and FormatCache with templates (NFC)

labath added a comment. Not really my area, but it seems reasonable. One thing I'd consider is replacing the functions which return the values through a by-ref argument (e.g. `TypeCategoryMap::Get` with an actual return value. That'd mean one would have to type out the type in the invocation ex

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere added a comment. In D71105#1774936 , @labath wrote: > This looks better. Ideally I wouldn't even have Utility/GDBRemote.h, but as > Process/gdb-remote is not a very good place for it either (it messes with > lldb-server dependencies), we can

[Lldb-commits] [PATCH] D71236: [FormatManager] GetCandidateLanguages shouldn't know about ValueObject.

jingham added a comment. In D71236#1776404 , @aprantl wrote: > I'm assuming you already checked that this isn't used in swift-lldb either? > Otherwise this obviously LGTM. This is answering the question "which languages have formatters that are compati

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

jingham added a comment. If you make the frame format such that it is easy to pull the mangled & demangled names out of the format output (e.g. ###${function.mangled-name}### ???${function.name}) then you could check that the two names are different, and for extra credit you could use "lang c++

[Lldb-commits] [PATCH] D71236: [FormatManager] GetCandidateLanguages shouldn't know about ValueObject.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc69dd2cfae3: [FormatManager] GetCandidateLanguages shouldn't know about ValueObject. (authored by davide). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D712

[Lldb-commits] [lldb] bc69dd2 - [FormatManager] GetCandidateLanguages shouldn't know about ValueObject.

Author: Davide Italiano Date: 2019-12-09T17:16:20-08:00 New Revision: bc69dd2cfae37a335b9a0125e161c54548a9d2a5 URL: https://github.com/llvm/llvm-project/commit/bc69dd2cfae37a335b9a0125e161c54548a9d2a5 DIFF: https://github.com/llvm/llvm-project/commit/bc69dd2cfae37a335b9a0125e161c54548a9d2a5.dif

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/Language.h:146 +eNameWithNoArgs, +eMangledName }; `eNameMangled`? Comment at: lldb/source/Core/FormatEntity.cpp:1754 +StreamString ss; +if (sc->functio

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

mib updated this revision to Diff 232976. mib added a comment. Mark test as unsupported for windows. Run clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71237/new/ https://reviews.llvm.org/D71237 Files: lldb/docs/use/formatting.rst

[Lldb-commits] [PATCH] D71236: [FormatManager] GetCandidateLanguages shouldn't know about ValueObject.

aprantl added a comment. I'm assuming you already checked that this isn't used in swift-lldb either? Otherwise this obviously LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71236/new/ https://reviews.llvm.org/D71236 ___

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

jingham added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2056 +if (parent_had_base_class) + s.PutCString("::"); +s.PutCString(class_name.getValue()); xiaobai wrote: > jingham wrote: > > That's still implicitly C. Other languages (

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

xiaobai added inline comments. Comment at: lldb/test/Shell/Settings/Inputs/main.cpp:95 + +//virtual +~C() nit: comment unneeded. Comment at: lldb/test/Shell/Settings/TestFrameFormatMangling.test:9 +frame info +# CHECK: frame #0: {{.*}}_

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

jasonmolenda marked an inline comment as done. jasonmolenda added inline comments. Comment at: lldb/test/Shell/Settings/TestFrameFormatMangling.test:9 +frame info +# CHECK: frame #0: {{.*}}_ZN1CC2Eiii +c Is this mangled name going to be the same on windows? Rep

[Lldb-commits] [PATCH] D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype

xiaobai added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/CMakeLists.txt:10 +find_package(Lua REQUIRED) +include_directories(${LUA_INCLUDE_DIR}) + Nit: I would use `target_include_directories` here. https://cmake.org/cmake/help/latest/

[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

xiaobai added a comment. I'm really excited to see where this goes! :D Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:64 +const char *ScriptInterpreterLua::GetPluginDescriptionStatic() { + return "Null script interpreter"; +} W

[Lldb-commits] [PATCH] D71236: [FormatManager] GetCandidateLanguages shouldn't know about ValueObject.

davide created this revision. davide added reviewers: jingham, teemperor, JDevlieghere, aprantl. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71236 Files: lldb/include/lldb/DataFormatters/FormatManager.h lldb/source/DataFormatters/FormatClasse

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

mib created this revision. Herald added a project: LLDB. mib added a reviewer: LLDB. Add `function.mangled-name` key for FormatEntity to show the mangled function names in backtraces. rdar://54088244 Signed-off-by: Med Ismail Bennani Repository: rG LLVM Github Monorepo https://reviews.llvm

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

xiaobai added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2056 +if (parent_had_base_class) + s.PutCString("::"); +s.PutCString(class_name.getValue()); jingham wrote: > That's still implicitly C. Other languages (swift) use "." for

[Lldb-commits] [PATCH] D71235: [Lldb/Lua] Generate Lua Bindings and Make Them Available to the Script Interpreter

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: abidh, mgorny. Herald added a project: LLDB. JDevlieghere added a parent revision: D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype. This patch uses SWIG to generate the Lua bi

[Lldb-commits] [PATCH] D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Protype

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: abidh, mgorny. Herald added a project: LLDB. JDevlieghere edited the summary of this revision. JDevlieghere added a parent revision: D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter.

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

jingham added a comment. One comment on a part you didn't change, but left a C++ specific track in the generic ValueObject code. Comment at: lldb/source/Core/ValueObject.cpp:2056 +if (parent_had_base_class) + s.PutCString("::"); +s.PutCString(class_name.getValue()

[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: mgorny. Herald added a project: LLDB. JDevlieghere updated this revision to Diff 232963. JDevlieghere added a comment. Return the right name from `GetPluginNameStatic`. This adds the boilerplate n

[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

JDevlieghere updated this revision to Diff 232963. JDevlieghere added a comment. Return the right name from `GetPluginNameStatic`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71232/new/ https://reviews.llvm.org/D71232 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/include/lldb/l

[Lldb-commits] [PATCH] D71233: Do not cache hardcoded formats in FormatManager

aprantl created this revision. aprantl added reviewers: jingham, davide. aprantl added a parent revision: D71231: Replace redundant code in FormatManager and FormatCache with templates (NFC). The cache in FormatCache uses only a type name as key. The hardcoded formats, synthetic children, etc in

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

xiaobai updated this revision to Diff 232960. xiaobai added a comment. Address feedback from @teemperor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69820/new/ https://reviews.llvm.org/D69820 Files: lldb/include/lldb/Symbol/ClangASTContext.h

[Lldb-commits] [PATCH] D71231: Replace redundant code in FormatManager and FormatCache with templates (NFC)

aprantl created this revision. aprantl added reviewers: jingham, shafik, davide, labath. This is a preparatory patch for an upcoming bugfix. FormatManager and friends have four identical implementations of many accessor functions to deal with the four types of shared pointers in the FormatCache.

[Lldb-commits] [lldb] 295db41 - [FormatManager] Provide a single entrypoint for GetCandidateLanguages().

Author: Davide Italiano Date: 2019-12-09T14:49:08-08:00 New Revision: 295db41ce230d9b0f1e0d24829abf0fb772b31ff URL: https://github.com/llvm/llvm-project/commit/295db41ce230d9b0f1e0d24829abf0fb772b31ff DIFF: https://github.com/llvm/llvm-project/commit/295db41ce230d9b0f1e0d24829abf0fb772b31ff.dif

[Lldb-commits] [PATCH] D71196: [lldb] Add support for calling objc_direct methods from LLDB's expression evaluator.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71196/new/ https://reviews.llvm.org/D71196 ___ lldb-commits

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Sorry, I was out on vacation until today :). The bot is actually running 3.14 already, I updated the host file to reflect that. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai added a comment. ping @jingham @teemperor any issues with this going in? I'd like to land this soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64844/new/ https://reviews.llvm.org/D64844 __

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai updated this revision to Diff 232927. xiaobai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64844/new/ https://reviews.llvm.org/D64844 Files: lldb/include/lldb/Symbol/ClangASTContext.h lldb/include/lldb/Target/T

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

compnerd added a comment. @stella.stamenova ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69535/new/ https://reviews.llvm.org/D69535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D70883: [vscode.py] Make read_packet only return None when EOF

jingham added a comment. In D70883#1771686 , @aadsm wrote: > Fair enough, I haven't seen evidence of this (haven't searched for it) but I > imagine IDEs need to ignore this as well otherwise they just barf if they're > expecting `Content-Length` and a wi

[Lldb-commits] [PATCH] D70532: [lldb] Improve/fix base address selection in location lists

clayborg added a comment. Sorry for the delay, lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70532/new/ https://reviews.llvm.org/D70532 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] be05633 - [lldb] Clean up accidentally passing TestDeadStrip.py

Author: Pavel Labath Date: 2019-12-09T19:01:52+01:00 New Revision: be05633e28949139093278d5ce57a194756bfb83 URL: https://github.com/llvm/llvm-project/commit/be05633e28949139093278d5ce57a194756bfb83 DIFF: https://github.com/llvm/llvm-project/commit/be05633e28949139093278d5ce57a194756bfb83.diff

[Lldb-commits] [lldb] fe96d1e - [lldb/SWIG] Guard Python type map in SWIG interface by SWIGPYTHON

Author: Jonas Devlieghere Date: 2019-12-09T09:35:48-08:00 New Revision: fe96d1ee788d3e8dcdc6fb984bc5376d9ec84d7d URL: https://github.com/llvm/llvm-project/commit/fe96d1ee788d3e8dcdc6fb984bc5376d9ec84d7d DIFF: https://github.com/llvm/llvm-project/commit/fe96d1ee788d3e8dcdc6fb984bc5376d9ec84d7d.d

[Lldb-commits] [lldb] d32484f - [lldb][CMake] Fix build for the case of custom libedit installation

Author: Tatyana Krasnukha Date: 2019-12-09T20:23:05+03:00 New Revision: d32484f40cbe1249643f024e3a10c4e3c50ff837 URL: https://github.com/llvm/llvm-project/commit/d32484f40cbe1249643f024e3a10c4e3c50ff837 DIFF: https://github.com/llvm/llvm-project/commit/d32484f40cbe1249643f024e3a10c4e3c50ff837.d

[Lldb-commits] [PATCH] D71212: [lldb] Centralize type "desugaring" logic in ClangASTContext

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I think this can be further simplified, but we can also do the move to `QualType::getDesugaredType` in a follow-up commit to unblock your atomic struct patch. Comment

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere updated this revision to Diff 232867. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71105/new/ https://reviews.llvm.org/D71105 Files: lldb/include/lldb/Utility/GDBRemote.h lldb/include/lldb/Utility/Reproducer.h lldb/source

[Lldb-commits] [PATCH] D71212: [lldb] Centralize type "desugaring" logic in ClangASTContext

labath created this revision. labath added reviewers: teemperor, shafik. Herald added a subscriber: jfb. Herald added a project: LLDB. A *lot* of ClangASTContext functions contained repetitive code for "desugaring" certain kinds of clang types. This patch creates a utility function for performing

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:439 - std::vector packets; - yaml::Input yin((*error_or_file)->getBuffer()); - yin >> packets; + static std::unique_ptr> + multi_loader = --

[Lldb-commits] [lldb] 0964733 - [lldb] Remove Xfail decorators from steadily passing tests

Author: Muhammad Omair Javaid Date: 2019-12-09T19:08:59+05:00 New Revision: 0964733bae2d0823f7b431ee2b16a3fd1dd993e3 URL: https://github.com/llvm/llvm-project/commit/0964733bae2d0823f7b431ee2b16a3fd1dd993e3 DIFF: https://github.com/llvm/llvm-project/commit/0964733bae2d0823f7b431ee2b16a3fd1dd993

[Lldb-commits] [PATCH] D71003: [lldb/DWARF] Switch to llvm location list parser

This revision was automatically updated to reflect the committed changes. Closed by commit rG773b849c10a6: [lldb/DWARF] Switch to llvm location list parser (authored by labath). Changed prior to commit: https://reviews.llvm.org/D71003?vs=232319&id=232809#toc Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D70532: [lldb] Improve/fix base address selection in location lists

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG329008fdf188: [lldb] Improve/fix base address selection in location lists (authored by labath). Repository: rG LLVM Git

[Lldb-commits] [lldb] 329008f - [lldb] Improve/fix base address selection in location lists

Author: Pavel Labath Date: 2019-12-09T13:39:08+01:00 New Revision: 329008fdf1889c0554f7afbb426f829f98327c78 URL: https://github.com/llvm/llvm-project/commit/329008fdf1889c0554f7afbb426f829f98327c78 DIFF: https://github.com/llvm/llvm-project/commit/329008fdf1889c0554f7afbb426f829f98327c78.diff

[Lldb-commits] [lldb] 773b849 - [lldb/DWARF] Switch to llvm location list parser

Author: Pavel Labath Date: 2019-12-09T13:39:10+01:00 New Revision: 773b849c10a60171908ab1bd658a44b6b396f567 URL: https://github.com/llvm/llvm-project/commit/773b849c10a60171908ab1bd658a44b6b396f567 DIFF: https://github.com/llvm/llvm-project/commit/773b849c10a60171908ab1bd658a44b6b396f567.diff

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

labath added a comment. This looks better. Ideally I wouldn't even have Utility/GDBRemote.h, but as Process/gdb-remote is not a very good place for it either (it messes with lldb-server dependencies), we can live with it for now. Comment at: lldb/include/lldb/Utility/Reproduc

[Lldb-commits] [PATCH] D71196: [lldb] Add support for calling objc_direct methods from LLDB's expression evaluator.

teemperor created this revision. teemperor added reviewers: aprantl, shafik. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. D69991 introduced `__attribute__((objc_direct))` that allows directly calling methods without message

Re: [Lldb-commits] [lldb] 7d175cf - [lldb] Xfail TestCallOverriddenMethod.py for aarch64/linux

Can you share the error output of the test failure? > On 9. Dec 2019, at 12:38, Muhammad Omair Javaid via lldb-commits > wrote: > > > Author: Muhammad Omair Javaid > Date: 2019-12-09T16:38:33+05:00 > New Revision: 7d175cf504bceb72a487a83ed9f640011832d46d > > URL: > https://github.com/llvm/ll

[Lldb-commits] [lldb] 7d175cf - [lldb] Xfail TestCallOverriddenMethod.py for aarch64/linux

Author: Muhammad Omair Javaid Date: 2019-12-09T16:38:33+05:00 New Revision: 7d175cf504bceb72a487a83ed9f640011832d46d URL: https://github.com/llvm/llvm-project/commit/7d175cf504bceb72a487a83ed9f640011832d46d DIFF: https://github.com/llvm/llvm-project/commit/7d175cf504bceb72a487a83ed9f640011832d4

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

PatriosTheGreat added a comment. It seems like with this CL find-basic-functions logic became inconsistent for macos target and pc-linux. In cases of pc-linux it returns no function with --function-flags=full flag and in macos it returns 7 functions. I think there are 3 ways to fix this: 1. Fi

[Lldb-commits] [PATCH] D71183: [lldb] Support for DWARF-5 atomic types

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0fb7a478df1: [lldb] Support for DWARF-5 atomic types (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71183/new/ https://reviews.llvm

[Lldb-commits] [lldb] d0fb7a4 - [lldb] Support for DWARF-5 atomic types

Author: Raphael Isemann Date: 2019-12-09T10:46:26+01:00 New Revision: d0fb7a478df19b78b58bf8778e9f046903115035 URL: https://github.com/llvm/llvm-project/commit/d0fb7a478df19b78b58bf8778e9f046903115035 DIFF: https://github.com/llvm/llvm-project/commit/d0fb7a478df19b78b58bf8778e9f046903115035.dif

[Lldb-commits] [PATCH] D71183: [lldb] Support for DWARF-5 atomic types

teemperor updated this revision to Diff 232772. teemperor added a comment. - Fix test formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71183/new/ https://reviews.llvm.org/D71183 Files: lldb/include/lldb/Symbol/ClangASTContext.h lldb/include/lldb/Symbol/CompilerType.h lld

[Lldb-commits] [PATCH] D71183: [lldb] Support for DWARF-5 atomic types

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks pretty straight-forward. When I wrote this test, I was expecting that an "atomic struct" would be "invalid input". Given that this is actually a thing, it would be nice to add some membe

[Lldb-commits] [PATCH] D71056: [lldb] Add a test for how we lazily create Clang AST nodes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf6e05672f656: [lldb] Add a test for how we lazily create Clang AST nodes (authored by teemperor). Repository: rG LLVM G

[Lldb-commits] [lldb] f6e0567 - [lldb] Add a test for how we lazily create Clang AST nodes

Author: Raphael Isemann Date: 2019-12-09T09:59:40+01:00 New Revision: f6e05672f6566a8d7efc4aed6473319e7115f979 URL: https://github.com/llvm/llvm-project/commit/f6e05672f6566a8d7efc4aed6473319e7115f979 DIFF: https://github.com/llvm/llvm-project/commit/f6e05672f6566a8d7efc4aed6473319e7115f979.dif

[Lldb-commits] [PATCH] D71056: [lldb] Add a test for how we lazily create Clang AST nodes

teemperor updated this revision to Diff 232768. teemperor added a comment. - Add this to DWARF testing category. The types we load depends partly on the debug information so this set of tests is only testing the way we build the AST with DWARF. CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

labath added a comment. While I'm not opposed to moving "lldbsuite" to some place closer to the tests, one thing I'd like to get out of this is to have the actual tests stand out more prominently. For that reason, I wouldn't want to just take the "lldbsuite" folder and "drop" it into `test/API`

[Lldb-commits] [PATCH] D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.

labath added a comment. Hmm... given the lua thread on lldb-dev, maybe we should slow down here, and consider the potential relationship of these tests and the hypothetical lua tests that come to be. One of the reasons the current tests are so deeply nested was that Zach was trying to future-pr