[Lldb-commits] [PATCH] D70303: Fix TestFormatters.py stepping too far

2019-11-15 Thread Diana Picus via Phabricator via lldb-commits
rovka created this revision. rovka added reviewers: omjavaid, lawrence_danna. Herald added a subscriber: kristof.beyls. TestFormatters.py has a sequence of three 'next' commands to get past all the initializations in the test function. On AArch64 (and potentially other platforms), this was one 'ne

[Lldb-commits] [PATCH] D70272: [-gmodules] Let LLDB log a warning if the Clang module hash mismatches.

2019-11-15 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:283-285 + /// Return a hash for this symbol file, such as a dwo_id. + virtual llvm::Optional GetSymbolHash() { return {}; } + Can we remove this and put a cast in `SymbolFileDWAR

[Lldb-commits] [PATCH] D70120: [lldb][NFC] Let CompilerType::DumpTypeValue take a option struct instead of a huge list of options

2019-11-15 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor abandoned this revision. teemperor added a comment. D70294 is the new thing Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70120/new/ https://reviews.llvm.org/D70120 ___ l

[Lldb-commits] [PATCH] D70294: [lldb][NFC] Pass a ValueObject to DumpTypeValue instead of bitfield size/offset pair

2019-11-15 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added a reviewer: labath. teemperor added a project: Upstreaming LLDB's downstream patches. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. teemperor retitled this revision from "[lldb] Pass a ValueObject to Dump