[Lldb-commits] [PATCH] D67887: Use _WIN32 instead of _MSC_VER

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372493: Use _WIN32 instead of _MSC_VER (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subs

[Lldb-commits] [PATCH] D67887: Use _WIN32 instead of _MSC_VER

hhb created this revision. Herald added subscribers: lldb-commits, mstorsjo. Herald added a project: LLDB. This way it works better with MinGW. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67887 Files: lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/IOHandler.cpp

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

mstorsjo created this revision. mstorsjo added reviewers: amccarth, compnerd, hhb. Herald added subscribers: JDevlieghere, abidh, mgorny. Herald added a project: LLDB. The PECOFF object file plugin uses the dbghelp API, but doesn't specify that it has to be linked in anywhere. Current MSVC based

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna added a comment. @labath So what do you think? Update all the lldb_private::File clients to use shared_ptr instead? Or do it this way, with sharing handled inside of File? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

This revision was automatically updated to reflect the committed changes. Closed by commit rL372486: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[Lldb-commits] [PATCH] D67862: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format strings

This revision was automatically updated to reflect the committed changes. Closed by commit rL372485: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format… (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[Lldb-commits] [PATCH] D67860: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment

This revision was automatically updated to reflect the committed changes. Closed by commit rL372484: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

This revision was automatically updated to reflect the committed changes. Closed by commit rL372482: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D67858: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition to MSVC defines

This revision was automatically updated to reflect the committed changes. Closed by commit rL372483: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition… (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[Lldb-commits] [lldb] r372486 - [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

Author: mstorsjo Date: Sat Sep 21 12:10:15 2019 New Revision: 372486 URL: http://llvm.org/viewvc/llvm-project?rev=372486&view=rev Log: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing This silences warnings about comparison of integers between unsigned long long (which is wh

[Lldb-commits] [lldb] r372484 - [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment

Author: mstorsjo Date: Sat Sep 21 12:09:54 2019 New Revision: 372484 URL: http://llvm.org/viewvc/llvm-project?rev=372484&view=rev Log: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment This fixes a warning when built with Clang in MinGW mode. Differential Revision: https://reviews.llvm.org

[Lldb-commits] [lldb] r372485 - [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format strings

Author: mstorsjo Date: Sat Sep 21 12:10:00 2019 New Revision: 372485 URL: http://llvm.org/viewvc/llvm-project?rev=372485&view=rev Log: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format strings SetErrorStringWithFormat only supports normal printf style format strings. Dif

[Lldb-commits] [lldb] r372483 - [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition to MSVC defines

Author: mstorsjo Date: Sat Sep 21 12:09:49 2019 New Revision: 372483 URL: http://llvm.org/viewvc/llvm-project?rev=372483&view=rev Log: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition to MSVC defines This matches how it is done in all other similar ifdefs throughou

[Lldb-commits] [lldb] r372482 - [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

Author: mstorsjo Date: Sat Sep 21 12:09:43 2019 New Revision: 372482 URL: http://llvm.org/viewvc/llvm-project?rev=372482&view=rev Log: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member This fixes build errors like these: NativeRegisterContextWindows.h:22:33: error: e