[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, zturner, jingham. Herald added a subscriber: mgorny. Herald added a project: LLDB. SBFile is a scripting API wrapper for lldb_private::File This is the first step in a rework of https://reviews.llvm.

[Lldb-commits] [PATCH] D67792: bugfix: llvm_private::File::GetStream() can fail if m_options == 0

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda. Herald added a project: LLDB. It's not clear from the header a File created with a descriptor will be not be usable by LLDB unless SetOptions is also called, but it is. This is because some parts of

[Lldb-commits] [PATCH] D67791: dotest.py: bugfix: test filters with -f do not work on Python3

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda. Herald added a project: LLDB. `dotest -f` does not work on Python3. The name types.UnboundMethodType was an alias for types.MethodType in 2.7, but it does not exist in python3. MethodType works in

[Lldb-commits] [PATCH] D38829: Python: SetOutputFileHandle doesn't work with IOBase

lawrence_danna abandoned this revision. lawrence_danna added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. I've reworked this -- finally -- as zturner suggested. I'll be posting it as a bunch of individual commits, so i'm abandoning this one. Repository: r

[Lldb-commits] [PATCH] D67790: prepare_binding_Python: print readable errors if SWIG fails

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda. Herald added a project: LLDB. When swig fails, all the errors are squished onto one line with `\n` quoting. It's very hard to read. This will print them out in a more reasonable format. Repository

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda. Herald added a project: LLDB. If the file has m_stream, it may not have a m_descriptor. GetWaitableHandle() should call GetDescriptor(), which will call fileno(), so it will get waitable descriptor wh

[Lldb-commits] [PATCH] D67786: support for arbitrary python file objects

lawrence_danna abandoned this revision. lawrence_danna added a comment. will re-submit as individual patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67786/new/ https://reviews.llvm.org/D67786 __

[Lldb-commits] [PATCH] D67583: Fix swig python package path

ZeGentzy added a comment. In D67583#1675714 , @hhb wrote: > My theory now is that your python has a different implementation of > get_python_lib(). After all we should not guess what python would do. I'm > making a change. > If you still interested in t

[Lldb-commits] [PATCH] D67781: Revert "Fix swig python package path"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372364: Revert "Fix swig python package path" (authored by hhb, committed by ). Herald added a project: LLVM. Herald added

[Lldb-commits] [PATCH] D67781: Revert "Fix swig python package path"

hhb created this revision. hhb added reviewers: JDevlieghere, ZeGentzy. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This reverts commit 5a115e81cdd40c758b10c382aeffc0c8de6930e2 . Repository:

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1675697 , @ZeGentzy wrote: > In D67583#1675415 , @hhb wrote: > > > Oh sorry my mistake. The current directory should be > > llvm-project/lldb/scripts. I.e. > > > > cd /src/llvm-proj

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. I'm making a change in finishSwigPythonLLDB.py to write directly to targetDir. This way we don't have the problem to guess where the files are written. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583

[Lldb-commits] [PATCH] D67583: Fix swig python package path

ZeGentzy added a comment. In D67583#1675415 , @hhb wrote: > Oh sorry my mistake. The current directory should be > llvm-project/lldb/scripts. I.e. > > cd /src/llvm-project/lldb/scripts > Maybe I'm doing something wrong, but that does not work either.

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, jingham. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. Usually, SIGTARP, SIGINT and SIGSTOP don't imply a crash. Rely on process signals' ShouldSuppress to filter such kin

[Lldb-commits] [PATCH] D67774: [Mangle] Check ExternalASTSource before adding prefix to asm label names

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I wonder what's the motivation for making this a setting in the ExternalASTSource? Opposed to e.g. storing a bit in AsmLabelAttr, which we could squeeze in by maybe stealing a

[Lldb-commits] [PATCH] D67774: [Mangle] Check ExternalASTSource before adding prefix to asm label names

rjmccall added inline comments. Comment at: clang/lib/AST/Mangle.cpp:137 +(!Source || Source->UseGlobalPrefixInAsmLabelMangle())) Out << '\01'; // LLVM IR Marker for __asm("foo") This is one of those bugs where looking at the code really reveals

[Lldb-commits] [PATCH] D67774: [Mangle] Check ExternalASTSource before adding prefix to asm label names

vsk created this revision. vsk added reviewers: teemperor, jasonmolenda, rjmccall. LLDB may synthesize decls using asm labels. These decls cannot have a mangle different than the one specified in the label name. I.e., the mangle-suppression prefix should not be added. Fixes an expression evaluati

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. Oh sorry my mistake. The current directory should be llvm-project/lldb/scripts. I.e. cd /src/llvm-project/lldb/scripts Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Multithread support

mgorny added a comment. Herald added a subscriber: dexonsmith. So I've made some progress on this. However, I'm stuck and I'd use some help going forward. I've made a trivial two-threaded program: #include #include #include #include void* thread_func(void* x) { printf("

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Multithread support

mgorny updated this revision to Diff 220871. mgorny marked 5 inline comments as done. mgorny retitled this revision from "[lldb] [Process/NetBSD] Implement per-thread execution control" to " [lldb] [Process/NetBSD] Multithread support". mgorny edited the summary of this revision. Herald added a r

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

mgorny abandoned this revision. mgorny added a comment. The problem is to complex too be implemented in smaller blocks. I'm going to close this in favor of a single unified patch in D64647 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ http

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py:54 +# Shifting longer than size of a type also doesn't work. +if rhs.value <= 0 or rhs.value >= 7: +

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

teemperor updated this revision to Diff 220857. teemperor marked 7 inline comments as done. teemperor added a comment. - Addressed feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67227/new/ https://reviews.llvm.org/D67227 Files: lldb/packages/Python/lldbsuite/test/commands/e

[Lldb-commits] [PATCH] D67760: [lldb] Decouple importing the std C++ module from the way the program is compiled

teemperor created this revision. teemperor added reviewers: aprantl, shafik. teemperor added a project: C++ modules in LLDB. Herald added subscribers: lldb-commits, JDevlieghere, abidh, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. At the moment, when trying to import t

[Lldb-commits] [PATCH] D67583: Fix swig python package path

ZeGentzy added a comment. In D67583#1674912 , @hhb wrote: > I don't have the right environment to try your command. But I didn't see > anything obviously problematic. > > Can you try the following: > > cd /src/llvm-project/lldb/scripts/Python > > > Then