[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb updated this revision to Diff 220206. hhb added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 Files: lldb/scripts/CMakeLists.txt Index: lldb/scripts/CMakeLists.txt ==

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb updated this revision to Diff 220207. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 Files: lldb/scripts/CMakeLists.txt Index: lldb/scripts/CMakeLists.txt ==

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. The path defined in CMakeLists.txt doesn't match the path generated in our python script. This change fixes that. LLVM_LIBRARY_OUTPUT_INTDIR is defined as: ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INT

[Lldb-commits] [PATCH] D67474: [Reproducer] Add `reproducer dump` command

This revision was automatically updated to reflect the committed changes. Closed by commit rL371909: [Reproducer] Add reproducer dump command. (authored by JDevlieghere, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D67474?vs=219949&id=22

[Lldb-commits] [lldb] r371909 - [Reproducer] Add reproducer dump command.

Author: jdevlieghere Date: Fri Sep 13 16:27:31 2019 New Revision: 371909 URL: http://llvm.org/viewvc/llvm-project?rev=371909&view=rev Log: [Reproducer] Add reproducer dump command. This adds a reproducer dump commands which makes it possible to inspect a reproducer from inside LLDB. Currently it

[Lldb-commits] [PATCH] D67523: [Reproducer] Move GDB Remote Packet into Utility. (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL371907: [Reproducer] Move GDB Remote Packet into Utility. (NFC) (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r371907 - [Reproducer] Move GDB Remote Packet into Utility. (NFC)

Author: jdevlieghere Date: Fri Sep 13 16:14:10 2019 New Revision: 371907 URL: http://llvm.org/viewvc/llvm-project?rev=371907&view=rev Log: [Reproducer] Move GDB Remote Packet into Utility. (NFC) To support dumping the reproducer's GDB remote packets, we need the (de)serialization logic to live in

[Lldb-commits] [PATCH] D67474: [Reproducer] Add `reproducer dump` command

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Approved with that addition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67474/new/ https://reviews.llvm.org/D67474 ___ lldb-commits

[Lldb-commits] [PATCH] D67474: [Reproducer] Add `reproducer dump` command

jingham added a comment. The help for -f should say what happens if this option isn't provided. Otherwise this looks fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67474/new/ https://reviews.llvm.org/D67474 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D67523: [Reproducer] Move GDB Remote Packet into Utility. (NFC)

jingham accepted this revision. jingham added a comment. Looks right. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67523/new/ https://reviews.llvm.org/D67523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D67540: [lldb] Remove SetCount/ClearCount from Flags

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67540/new/ https://reviews.llvm.org/D67540 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [lldb] r371905 - [test] Update TestAPILog to pass on Windows.

Author: jdevlieghere Date: Fri Sep 13 15:14:59 2019 New Revision: 371905 URL: http://llvm.org/viewvc/llvm-project?rev=371905&view=rev Log: [test] Update TestAPILog to pass on Windows. The pretty function macro is including __cdecl on Windows, which was causing the pattern matching to fail. This s

[Lldb-commits] [lldb] r371902 - [LLDB] Add missing breaks for switch statement

Author: timshen Date: Fri Sep 13 15:00:03 2019 New Revision: 371902 URL: http://llvm.org/viewvc/llvm-project?rev=371902&view=rev Log: [LLDB] Add missing breaks for switch statement Modified: lldb/trunk/tools/lldb-server/lldb-platform.cpp Modified: lldb/trunk/tools/lldb-server/lldb-platform.c

[Lldb-commits] [lldb] r371899 - [test] Print the log output on failure.

Author: jdevlieghere Date: Fri Sep 13 14:15:03 2019 New Revision: 371899 URL: http://llvm.org/viewvc/llvm-project?rev=371899&view=rev Log: [test] Print the log output on failure. This ensures that if the assertion fails we dump the log content. This should help me investigate what the output look

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

JDevlieghere added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov marked 4 inline comments as done. aleksandr.urakov added a comment. Hi Jason, thanks for the review! Initially, the reason of these changes was to reuse the code that works with `eh_frame`, because on Windows we have a very similar compiler generated info designed to help with

[Lldb-commits] [PATCH] D67538: [Reproducer] Include the this pointer in the API log.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371885: [Reproducer] Include the this pointer in the API log. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [lldb] r371885 - [Reproducer] Include the this pointer in the API log.

Author: jdevlieghere Date: Fri Sep 13 12:08:10 2019 New Revision: 371885 URL: http://llvm.org/viewvc/llvm-project?rev=371885&view=rev Log: [Reproducer] Include the this pointer in the API log. The new centralized way of doing API logging through the reproducer macros is lacking a way to easily co

[Lldb-commits] [lldb] r371882 - Fix error in ProcessLauncherWindows.cpp

Author: amccarth Date: Fri Sep 13 11:50:39 2019 New Revision: 371882 URL: http://llvm.org/viewvc/llvm-project?rev=371882&view=rev Log: Fix error in ProcessLauncherWindows.cpp Restored missing parens on a function call. Modified: lldb/trunk/source/Host/windows/ProcessLauncherWindows.cpp Modi

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov updated this revision to Diff 220144. aleksandr.urakov edited the summary of this revision. aleksandr.urakov added a comment. Update due to the requests. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347

[Lldb-commits] [PATCH] D67538: [Reproducer] Include the this pointer in the API log.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67538/new/ https://reviews.llvm.org/D67538 ___ lldb-commi

[Lldb-commits] [PATCH] D67540: [lldb] Remove SetCount/ClearCount from Flags

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Sure. If anything something like this should live in llvm/Support, but given it's not used, it should live nowhere. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] r371866 - [lldb] - Update unit tests after lib/ObjectYAML change.

Author: grimar Date: Fri Sep 13 09:00:28 2019 New Revision: 371866 URL: http://llvm.org/viewvc/llvm-project?rev=371866&view=rev Log: [lldb] - Update unit tests after lib/ObjectYAML change. An update after r371865 Modified: lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp lldb

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

guiandrade added a comment. In D67022#1665800 , @labath wrote: > looks fine to me Thank you, guys! Could you please submit it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67022/new/ https://revie

[Lldb-commits] [lldb] r371842 - [lldb][NFC] Remove ArgEntry::ref member

Author: teemperor Date: Fri Sep 13 04:26:48 2019 New Revision: 371842 URL: http://llvm.org/viewvc/llvm-project?rev=371842&view=rev Log: [lldb][NFC] Remove ArgEntry::ref member The StringRef should always be identical to the C string, so we might as well just create the StringRef from the C-string

[Lldb-commits] [lldb] r371836 - [lldb][NFC] Simplify Args::ReplaceArgumentAtIndex

Author: teemperor Date: Fri Sep 13 03:41:29 2019 New Revision: 371836 URL: http://llvm.org/viewvc/llvm-project?rev=371836&view=rev Log: [lldb][NFC] Simplify Args::ReplaceArgumentAtIndex This code is not on any performance critical path that would justify this shortening optimization. It also make

[Lldb-commits] [PATCH] D67540: [lldb] Remove SetCount/ClearCount from Flags

teemperor created this revision. teemperor added a reviewer: davide. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. These functions are only used in tests where we should test the actual flag values instead of counting all bits for an approximate check.

[Lldb-commits] [lldb] r371823 - [lldb][NFC] Make ArgEntry::quote private and provide a getter

Author: teemperor Date: Fri Sep 13 01:26:00 2019 New Revision: 371823 URL: http://llvm.org/viewvc/llvm-project?rev=371823&view=rev Log: [lldb][NFC] Make ArgEntry::quote private and provide a getter Modified: lldb/trunk/include/lldb/Utility/Args.h lldb/trunk/source/API/SBCommandInterpreter

[Lldb-commits] [PATCH] D67538: [Reproducer] Include the this pointer in the API log.

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a subscriber: abidh. Herald added a project: LLDB. The new centralized way of doing API logging through the reproducer macros is lacking a way to easily correlate instances of API objects. Logging the this poi