[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

labath added a comment. The details of how our FS capture works have unfortunately, swapped out of my memory, but... isn't this the sort of thing that should already be handled by the filesystem capture/replay machinery? It sounds to me like it could/should remember what the CWD at the time of

Re: [Lldb-commits] [lldb] r367549 - [lit] Use ld.lld -z separate-code to work around a debug_line parsing bug

On 02/08/2019 06:58, Fāng-ruì Sòng wrote: Hi Raphael, you need lld built from top of trunk to run the lldb tests. -z separate-code is added by rLLD367537, not included in lld 9. We may need to somehow tweak the detection logic in our lit scripts so that it does not pick up ambient lld (nor l

Re: [Lldb-commits] [lldb] r367549 - [lit] Use ld.lld -z separate-code to work around a debug_line parsing bug

On Thu, Aug 1, 2019 at 8:38 PM Pavel Labath wrote: > On 01/08/2019 14:34, Fangrui Song via lldb-commits wrote: > > Author: maskray > > Date: Thu Aug 1 05:34:43 2019 > > New Revision: 367549 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=367549&view=rev > > Log: > > [lit] Use ld.lld -z sepa

Re: [Lldb-commits] [lldb] r367549 - [lit] Use ld.lld -z separate-code to work around a debug_line parsing bug

Hi Raphael, you need lld built from top of trunk to run the lldb tests. -z separate-code is added by rLLD367537, not included in lld 9. On Fri, Aug 2, 2019 at 4:45 AM Raphael Isemann wrote: > This breaks the tests on my machine: > > > FAIL: LLDB :: SymbolFile/DWARF/dir-separ

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

aprantl added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:2229 clang::DeclContext *decl_ctx, const char *name, -const CompilerType ¶m_type, int storage) { +const CompilerType ¶m_type, int storage, bool add_decl) { ASTContext *ast = getASTContext

[Lldb-commits] [PATCH] D65489: Format OptionEnumValueElement

This revision was automatically updated to reflect the committed changes. Closed by commit rL367638: Format OptionEnumValueElement (NFC) (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[Lldb-commits] [lldb] r367638 - Format OptionEnumValueElement (NFC)

Author: jdevlieghere Date: Thu Aug 1 17:18:44 2019 New Revision: 367638 URL: http://llvm.org/viewvc/llvm-project?rev=367638&view=rev Log: Format OptionEnumValueElement (NFC) Reformat OptionEnumValueElement to make it easier to distinguish between its fields. This also removes the need to disable

[Lldb-commits] [PATCH] D65489: Format OptionEnumValueElement

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Okay, if clang-format won't undo this, then I'm fine with writing them this way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65489/new/ https://reviews.llvm.org/D65489

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

JDevlieghere updated this revision to Diff 212924. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new/ https://reviews.llvm.org/D65611 Files: lldb/lit/Driver/TestTarget.test lldb/tools/driver/Driver.cpp Index: lldb/tools/driver/Driver.cpp ==

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

jingham added a comment. IIRC both GetPath and ResolvePath return the number of characters it would take to actually resolve the path. 128 is actually pretty short, so you should check the result and malloc a buffer of the return + 1 if 128 ends up not being enough. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

jingham added a comment. If you just want the path and don't need the FileSpec, you can call the static SBFileSpec::ResolvePath. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new/ https://reviews.llvm.org/D65611 ___ lldb-commits mail

[Lldb-commits] [PATCH] D55571: [ast] CreateParameterDeclaration should use an appropriate DeclContext.

stella.stamenova added a comment. Herald added a project: LLDB. Test passes now. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55571/new/ https://reviews.llvm.org/D55571 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

JDevlieghere updated this revision to Diff 212916. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new/ https://reviews.llvm.org/D65611 Files: lldb/lit/Driver/TestTarget.test lldb/tools/driver/Driver.cpp Index: lldb/tools/driver/Driver.cpp ==

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

JDevlieghere created this revision. JDevlieghere added reviewers: davide, labath, jingham, clayborg, mgorny. JDevlieghere added a project: LLDB. Herald added a subscriber: teemperor. When invoking lldb on the command line with a binary, lldb will construct a command stream to create the target.

[Lldb-commits] [PATCH] D65489: Format OptionEnumValueElement

JDevlieghere added a comment. In D65489#1611165 , @jingham wrote: > What happens if you clang-format your reformatted version of the setter? Do > we need clang-format off for them? > > Otherwise this looks fine to me. This is the clang-format output!

[Lldb-commits] [PATCH] D65489: Format OptionEnumValueElement

jingham added a comment. What happens if you clang-format your reformatted version of the setter? Do we need clang-format off for them? Otherwise this looks fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65489/new/ https://reviews.llvm.org/D65489 ___

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

jasonmolenda accepted this revision. jasonmolenda added a comment. This looks good, this is in line with what we discussed, thanks for taking it on! Sorry for the delay at looking this over, it has been a little crazy this week. Comment at: lldb/source/Plugins/Process/Utilit

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

This revision was automatically updated to reflect the committed changes. Closed by commit rL367618: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure (authored by harlanhaskins, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[Lldb-commits] [PATCH] D65594: Fix `skipIfSanitized` decorator on macOS

jasonmolenda added a comment. fwiw this behavior is documented here, https://developer.apple.com/documentation/bundleresources/entitlements/com_apple_security_cs_allow-dyld-environment-variables?language=objc Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65594/new

[Lldb-commits] [PATCH] D65492: Adjust a ValueObjectChild's offset when the child is a bitfield

jasonmolenda added a comment. I'm sure this is fine, I read the code through and I've realized I haven't had to do anything with bitfields in lldb up to now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65492/new/ https://reviews.llvm.org/D65492

Re: [Lldb-commits] [lldb] r367549 - [lit] Use ld.lld -z separate-code to work around a debug_line parsing bug

This breaks the tests on my machine: FAIL: LLDB :: SymbolFile/DWARF/dir-separator-no-comp-dir.s (114 of 1660) TEST 'LLDB :: SymbolFile/DWARF/dir-separator-no-comp-dir.s' FAILED Script: -- : 'RUN: at line 6'; /home/teemperor/work/3llv

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

JDevlieghere added a comment. Is there a way to use the debugserver in the framework instead? This seems like the inverse of the problem we had earlier with the RPATHs, where we would fix them up in the build tree after copying them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D65489: Format OptionEnumValueElement

JDevlieghere updated this revision to Diff 212892. JDevlieghere retitled this revision from "Tablegen option enum value elements" to "Format OptionEnumValueElement". JDevlieghere edited the summary of this revision. JDevlieghere added a reviewer: labath. JDevlieghere added a comment. Reformat Op

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

shafik added a comment. @labath @stella.stamenova I updated the diff with a fix that I believe should address the test failure. This is an unfortunate difference in how DWARF and PDB works. After spending some time digging into this I don't see the key difference that allows DWARF to work w/o

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

jkorous accepted this revision. jkorous marked an inline comment as done. jkorous added a comment. This revision is now accepted and ready to land. LGTM Thanks for all the work here! Comment at: clang/lib/ARCMigrate/FileRemapper.cpp:156 + auto newE = FileMgr->getFile(temp

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

shafik updated this revision to Diff 212884. shafik added a comment. Fix that should fix the failing PDB test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 Files: include/lldb/Symbol/ClangASTContext.h packages/Python/lldbsuite/test/lang/

[Lldb-commits] [PATCH] D65594: Fix `skipIfSanitized` decorator on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rL367595: Fix `skipIfSanitized` decorator on macOS (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[Lldb-commits] [lldb] r367595 - Fix `skipIfSanitized` decorator on macOS

Author: jdevlieghere Date: Thu Aug 1 11:35:40 2019 New Revision: 367595 URL: http://llvm.org/viewvc/llvm-project?rev=367595&view=rev Log: Fix `skipIfSanitized` decorator on macOS For security reasons, DYLD_INSERT_LIBRARIES is not propagated to a child process. This breaks the skipIfSanitized dec

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

harlanhaskins marked 6 inline comments as done and an inline comment as not done. harlanhaskins added inline comments. Comment at: clang/lib/ARCMigrate/FileRemapper.cpp:156 + auto newE = FileMgr->getFile(tempPath); + if (newE) { +remap(origFE, *newE); -

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

harlanhaskins updated this revision to Diff 212860. harlanhaskins marked 8 inline comments as done. harlanhaskins added a comment. Updated in response to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65

[Lldb-commits] [PATCH] D65594: Fix `skipIfSanitized` decorator on macOS

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65594/new/ https://reviews.llvm.org/D65594 ___ lldb-comm

[Lldb-commits] [PATCH] D65594: Fix `skipIfSanitized` decorator on macOS

JDevlieghere created this revision. JDevlieghere added reviewers: davide, vsk. Herald added a subscriber: teemperor. Herald added a project: LLDB. For security reasons, `DYLD_INSERT_LIBRARIES` is not propagated to a child process. This breaks the `skipIfSanitized` decorator, which checks for the

[Lldb-commits] [PATCH] D65492: Adjust a ValueObjectChild's offset when the child is a bitfield

aprantl added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65492/new/ https://reviews.llvm.org/D65492 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

thakis added a comment. Nice! This makes https://bugs.llvm.org/show_bug.cgi?id=42524#c3 easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 ___ lldb-commits

[Lldb-commits] [PATCH] D65546: Fix TestThreadSpecificBreakpoint on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL367573: Fix TestThreadSpecificBreakpoint on Windows (authored by amccarth, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [lldb] r367573 - Fix TestThreadSpecificBreakpoint on Windows

Author: amccarth Date: Thu Aug 1 07:49:54 2019 New Revision: 367573 URL: http://llvm.org/viewvc/llvm-project?rev=367573&view=rev Log: Fix TestThreadSpecificBreakpoint on Windows This test was frequently hanging on Windows, causing a timeout after 10 minutes. The short delay (100 microsecond) in

[Lldb-commits] [lldb] r367554 - Add llvm-dwarfdump to the list of test dependencies

Author: labath Date: Thu Aug 1 05:50:25 2019 New Revision: 367554 URL: http://llvm.org/viewvc/llvm-project?rev=367554&view=rev Log: Add llvm-dwarfdump to the list of test dependencies It is used by SymbolFile/DWARF/debug-types-dwo-cross-reference.cpp Modified: lldb/trunk/lit/CMakeLists.txt

[Lldb-commits] [PATCH] D65571: [lldb][NFC] Remove unused imports from Python tests

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. I haven't looked at all files, but the changes are pretty straight-forward, and bound to break in a pretty obvious way if this is wrong, so LGTM. Reposi

Re: [Lldb-commits] [lldb] r367549 - [lit] Use ld.lld -z separate-code to work around a debug_line parsing bug

On 01/08/2019 14:34, Fangrui Song via lldb-commits wrote: Author: maskray Date: Thu Aug 1 05:34:43 2019 New Revision: 367549 URL: http://llvm.org/viewvc/llvm-project?rev=367549&view=rev Log: [lit] Use ld.lld -z separate-code to work around a debug_line parsing bug The issue was exposed by D649

[Lldb-commits] [lldb] r367549 - [lit] Use ld.lld -z separate-code to work around a debug_line parsing bug

Author: maskray Date: Thu Aug 1 05:34:43 2019 New Revision: 367549 URL: http://llvm.org/viewvc/llvm-project?rev=367549&view=rev Log: [lit] Use ld.lld -z separate-code to work around a debug_line parsing bug The issue was exposed by D64903/r367537. http://lab.llvm.org:8011/builders/lldb-x64-windo

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

teemperor added a comment. The error handling in LLDB seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

labath added a comment. In D65386#1609986 , @teemperor wrote: > In D65386#1609956 , @labath wrote: > > > > > > The setter function still seems more verbose than three short lines, but I > don't have a strong opinio

[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

teemperor added a comment. In D65386#1609956 , @labath wrote: > In D65386#1609875 , @teemperor wrote: > > > In D65386#1604498 , @labath wrote: > > > > > How about codegenning

[Lldb-commits] [lldb] r367542 - [lldb][NFC] Make ClangDiagnostic::m_fixit_vec private

Author: teemperor Date: Thu Aug 1 04:05:47 2019 New Revision: 367542 URL: http://llvm.org/viewvc/llvm-project?rev=367542&view=rev Log: [lldb][NFC] Make ClangDiagnostic::m_fixit_vec private Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h Modified: lldb/trunk/sour

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

labath added a comment. In D64993#1608946 , @JosephTremoulet wrote: > In D64993#1608452 , @labath wrote: > > > I haven't looked at the implementation, but I did run into the problem you > > are fixing in the past,

[Lldb-commits] [PATCH] D65569: Remove SymbolVendor::GetSymtab

labath created this revision. labath added reviewers: clayborg, JDevlieghere, jingham. This patch removes the GetSymtab method from the SymbolVendor, which is a no-op as it's implementation just forwards to the relevant SymbolFile. Instead it creates a Module::GetSymtab, which calls the SymbolFile

[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

labath added a comment. In D65386#1609875 , @teemperor wrote: > In D65386#1604498 , @labath wrote: > > > How about codegenning the entire implementation of `SetOptionValue`? That > > way the user won't have to writ

[Lldb-commits] [PATCH] D65509: [lldb][CMake] Avoid 'Autogenerate scheme' dialogs in Xcode projects

This revision was automatically updated to reflect the committed changes. Closed by commit rL367538: [lldb][CMake] Avoid 'Autogenerate scheme' dialogs in Xcode projects (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[Lldb-commits] [PATCH] D65437: [lldb][docs] Update landing page for monorepo

This revision was automatically updated to reflect the committed changes. Closed by commit rL367539: [lldb][docs] Update landing page for monorepo (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[Lldb-commits] [lldb] r367539 - [lldb][docs] Update landing page for monorepo

Author: stefan.graenitz Date: Thu Aug 1 03:33:54 2019 New Revision: 367539 URL: http://llvm.org/viewvc/llvm-project?rev=367539&view=rev Log: [lldb][docs] Update landing page for monorepo Summary: Following up from D65330, here's an update for the landing page. Reviewers: jryans, clayborg, amcca

[Lldb-commits] [lldb] r367538 - [lldb][CMake] Avoid 'Autogenerate scheme' dialogs in Xcode projects

Author: stefan.graenitz Date: Thu Aug 1 03:33:44 2019 New Revision: 367538 URL: http://llvm.org/viewvc/llvm-project?rev=367538&view=rev Log: [lldb][CMake] Avoid 'Autogenerate scheme' dialogs in Xcode projects Summary: Supported in CMake 3.9 and higher: https://cmake.org/cmake/help/v3.9/variable

Re: [Lldb-commits] [lldb] r367308 - [lldb] Fix crash when tab-completing in multi-line expr

Merged to release_90 in r367534. On Tue, Jul 30, 2019 at 2:53 PM Hans Wennborg wrote: > > Hi Raphael, > > Since this just landed, let's have it bake in trunk a little bit, and > then I'll merge it. > > Thanks, > Hans > > On Tue, Jul 30, 2019 at 2:36 PM Raphael “Teemperor” Isemann > wrote: > > >

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

sgraenitz marked an inline comment as done. sgraenitz added a comment. Checked with: > xcodebuild -configuration Release -target debugserver > codesign -dv Release/bin/LLDB.framework/Versions/A/Resources/debugserver > codesign -dv Release/bin/debugserver Comment at: lldb

[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

teemperor marked an inline comment as done. teemperor added a comment. > It worries me a little bit that we are making it harder and harder to figure > out "where does the option for "-t" get stored once this CommandObject's > options have been parsed. Can you show the steps I would have to go t

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

sgraenitz created this revision. sgraenitz added reviewers: jingham, davide, JDevlieghere, teemperor. Herald added a subscriber: mgorny. Herald added a project: LLDB. sgraenitz edited the summary of this revision. Explicitly code-sign the LLDB.framework copy of debugserver in the build-tree. This

[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile

labath updated this revision to Diff 212764. labath added a comment. - add two null checks - replace GetSymbolVendor with GetSymbolFile in a couple of more places, where it is easy to do CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65435/new/ https://reviews.llvm.org/D65435 Files:

[Lldb-commits] [PATCH] D65561: SymbolVendorELF: Perform build-id lookup even without a debug link

labath created this revision. labath added reviewers: jankratochvil, mgorny, clayborg. Herald added subscribers: MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. The debug link and build-id lookups are two independent ways one can search for a se

[Lldb-commits] [PATCH] D65560: ObjectFile[ELF]: Refactor gnu_debuglink interface

labath created this revision. labath added reviewers: clayborg, jankratochvil, mgorny. Herald added subscribers: MaskRay, arichardson, emaste. Herald added a reviewer: espindola. The contents of the gnu_debuglink section were passed through the GetDebugSymbolFilePaths interface, which was more gen

Re: [Lldb-commits] [lldb] r367414 - [ProcessWindows] Choose a register context file by preprocessor

Merged to release_90 in r367523. On Wed, Jul 31, 2019 at 1:59 PM Tatyana Krasnukha via lldb-commits wrote: > > Author: tkrasnukha > Date: Wed Jul 31 05:00:30 2019 > New Revision: 367414 > > URL: http://llvm.org/viewvc/llvm-project?rev=367414&view=rev > Log: > [ProcessWindows] Choose a register co

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

labath added a comment. In D64647#1609712 , @mgorny wrote: > Not sure if we're taking about the same thing. I meant the status in resume > actions. I think it'd be logical if 'no action' meant 'resume in same state > as prior to stopping the process', an

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

mgorny added a comment. Not sure if we're taking about the same thing. I meant the status in resume actions. I think it'd be logical if 'no action' meant 'resume in same state as prior to stopping the process', and explicit eStateS* meant 'keep this thread stopped after resuming'. CHANGES SIN

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

labath added a comment. In D65489#1609001 , @JDevlieghere wrote: > In D65489#1608936 , @labath wrote: > > > Yeah, the C arrays aren't the prettiest sight, but OTOH your tablegen files > > don't respect the column

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:738 +if (*it && ((*it)->GetID() == thread_id)) { + m_threads.erase(it); + break; Note to self, this should