labath added a subscriber: mgorny.
labath added a comment.
This looks mostly good. The thing I'm wondering about is whether this part of
the code is really linux specific (in which case we should rename ELFLinkMap
into LinuxLinkMap), or if it can be useful on other platforms (in which case
this
labath accepted this revision.
labath added a comment.
LGTM.
BTW, I see you still haven't submitted the previous two changes in the stack.
Are you planning to submit all of them together or what? It's usually better to
avoid batch submitting a bunch of dependent changes, as that way, if any
pr
aadsm updated this revision to Diff 203761.
aadsm added a comment.
Do not try to use LoadModules again if they failed in the past
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62504/new/
https://reviews.llvm.org/D62504
Files:
lldb/include/lldb/T
compnerd added inline comments.
Comment at: include/lldb/Target/ObjCLanguageRuntime.h:202
+ static ObjCLanguageRuntime *GetObjCLanguageRuntime(Process &process) {
+return llvm::cast_or_null(
I think it would be nice to just call this `Get` (and we could ha
