[Lldb-commits] [PATCH] D62473: [zorg] Add lldb-aarch64-ubuntu builder

This revision was automatically updated to reflect the committed changes. omjavaid marked an inline comment as done. Closed by commit rL361787: [zorg] Add lldb-aarch64-ubuntu builder (authored by omjavaid, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

aadsm created this revision. aadsm added reviewers: clayborg, xiaobai, labath. Herald added subscribers: lldb-commits, srhines. Herald added a project: LLDB. This solves the problem of lldb not recognizing android vendor's ndks that can live along side the system ndks. More about this feature her

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

aadsm created this revision. aadsm added reviewers: clayborg, xiaobai, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm edited the summary of this revision. aadsm added a parent revision: D62503: Add ReadCStringFromMemory for faster string reads. This is the si

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

aadsm created this revision. aadsm added reviewers: clayborg, xiaobai. Herald added subscribers: lldb-commits, krytarowski, srhines. Herald added a project: LLDB. aadsm added a parent revision: D62501: Implement GetSharedLibraryInfoAddress. aadsm added a child revision: D62503: Add ReadCStringFromM

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm created this revision. aadsm added reviewers: clayborg, xiaobai. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm added a parent revision: D62502: Implement xfer:libraries-svr4:read packet. This is the fifth and final patch to improve module loading in a series t

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

aadsm created this revision. aadsm added reviewers: clayborg, xiaobai. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm added a parent revision: D62500: Add support to read aux vector values. This is the third patch to improve module loading in a series that started her

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm created this revision. aadsm added reviewers: clayborg, xiaobai. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. aadsm added a parent revision: D62499: Create a generic handler for Xfer packets. aadsm added a child revision: D62501: Implement GetSharedLibraryInf

[Lldb-commits] [PATCH] D62499: Create a generic handler for Xfer packets

aadsm created this revision. aadsm added reviewers: clayborg, xiaobai. Herald added subscribers: lldb-commits, krytarowski. Herald added a project: LLDB. aadsm edited the summary of this revision. aadsm edited the summary of this revision. This is the first of a few patches I have to improve the p

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

guiandrade updated this revision to Diff 201583. guiandrade added a comment. Add inferior to to set the values of a few registers to known values so we can verify the 'g' packet looks good. Also, start testing with/without thread suffix . Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

labath added a comment. In D62316#1515266 , @labath wrote: > In D62316#1513905 , @clayborg wrote: > > > In D62316#1513894 , @labath wrote: > > > > > Two other options I see a

[Lldb-commits] [lldb] r361765 - DWARFDebugArangeSet: Remove references to SymbolFileDWARF

Author: labath Date: Mon May 27 07:16:15 2019 New Revision: 361765 URL: http://llvm.org/viewvc/llvm-project?rev=361765&view=rev Log: DWARFDebugArangeSet: Remove references to SymbolFileDWARF This class does not depend on SymbolFileDWARF. Instead, include more appropriate low-level headers. Modif

[Lldb-commits] [lldb] r361760 - XFAIL prefer-debug-over-eh-frame.test on darwin

Author: labath Date: Mon May 27 06:43:01 2019 New Revision: 361760 URL: http://llvm.org/viewvc/llvm-project?rev=361760&view=rev Log: XFAIL prefer-debug-over-eh-frame.test on darwin debug_frame does not seem to work on darwin, so there is nothing to prefer. Adding `-g` to the compiler command lin

[Lldb-commits] [lldb] r361759 - DWARF: Add a simple test exercising debug_loc parsing

Author: labath Date: Mon May 27 06:23:23 2019 New Revision: 361759 URL: http://llvm.org/viewvc/llvm-project?rev=361759&view=rev Log: DWARF: Add a simple test exercising debug_loc parsing Added: lldb/trunk/lit/SymbolFile/DWARF/debug_loc.s Added: lldb/trunk/lit/SymbolFile/DWARF/debug_loc.s URL

[Lldb-commits] [PATCH] D62302: DWARF: Fix address range support in mixed 4+5 scenario

labath updated this revision to Diff 201515. labath added a comment. - reduce the code duplication by adding a helper function. I've elected to put the helper function into DWARFDebugInfoEntry, to keep the DWARFUnit part of this patch identical with the llvm DWARFUnit. I think the main source of

[Lldb-commits] [PATCH] D62374: FuncUnwinders: prefer debug_frame over eh_frame

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361758: FuncUnwinders: prefer debug_frame over eh_frame (authored by labath, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to commit: https://revie

[Lldb-commits] [lldb] r361758 - FuncUnwinders: prefer debug_frame over eh_frame

Author: labath Date: Mon May 27 04:53:24 2019 New Revision: 361758 URL: http://llvm.org/viewvc/llvm-project?rev=361758&view=rev Log: FuncUnwinders: prefer debug_frame over eh_frame The two sections usually contain the same information, and we rarely have both kinds of entries for a single functio

[Lldb-commits] [PATCH] D62395: WIP: Dont vend lldb_private::CompileUnits for DWARFTypeUnits

labath added a comment. Thanks for looking at this. I'm not going to respond to the individual comments here, as this patch is not is not intended to be submitted like this. I just posted it here to get some high level feedback about the overall direction. Instead, I'm going to split off smalle

[Lldb-commits] [PATCH] D62481: DWARFASTParserClang: Unify compilation unit language handling

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:297 TypeSP type_sp; + LanguageType cu_language = die.GetLanguage(); switch (tag) { `DWARFDIE::GetLanguage` just fetch

[Lldb-commits] [PATCH] D62481: DWARFASTParserClang: Unify compilation unit language handling

labath created this revision. labath added reviewers: clayborg, JDevlieghere, aprantl. Herald added a subscriber: jdoerfert. The function was not being consistent in how it retrieved the language of the current compile unit. Sometimes it did so from the lldb CU object, and sometimes from the DWARF

[Lldb-commits] [PATCH] D62477: DWARFASTParserClang: Move attribute parsing into a single function

labath updated this revision to Diff 201497. labath added a comment. - also include DW_AT_signature in the attribute list to increase consistency and avoid iterating over the attribute list twice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62477/new/ https://reviews.llvm.org/D62477

[Lldb-commits] [PATCH] D62473: [zorg] Add lldb-aarch64-ubuntu builder

omjavaid updated this revision to Diff 201490. omjavaid added a comment. Fixes typo in first rev. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62473/new/ https://reviews.llvm.org/D62473 Files: buildbot/osuosl/master/config/builders.py buildbot/osuosl/master/config/slaves.py buil

[Lldb-commits] [PATCH] D62477: DWARFASTParserClang: Move attribute parsing into a single function

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. Herald added a subscriber: jdoerfert. The ParseTypeFromDWARF function consists of a huge switch on the kind of type being parsed. Each case in this switch starts with parsing the attributes of the current DIE. A

[Lldb-commits] [PATCH] D62473: [zorg] Add lldb-aarch64-ubuntu builder

omjavaid marked 2 inline comments as done. omjavaid added inline comments. Comment at: buildbot/osuosl/master/config/status.py:282 +mode = "failing", +builders = ["lldb-x86_64-debian"], +addLogs=False), labath wrote: > This doe

[Lldb-commits] [lldb] r361754 - DWARF: Remove cu_idx variables from parsing functions

Author: labath Date: Mon May 27 03:10:59 2019 New Revision: 361754 URL: http://llvm.org/viewvc/llvm-project?rev=361754&view=rev Log: DWARF: Remove cu_idx variables from parsing functions These variables were useful when looking up the compile unit index required a binary search. Now that we can l

[Lldb-commits] [PATCH] D57830: Add functionality to trace a function within lldb

serge-sans-paille added a comment. LGTM with respect to Python 2/3 compat, can't tell for the functionality though. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57830/new/ https://reviews.llvm.org/D57830 ___ lldb-

[Lldb-commits] [PATCH] D62425: [DWARFExpression] Remove ctor that takes just a compile unit.

labath added a comment. (Other than that, the change seems like a nice improvement.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62425/new/ https://reviews.llvm.org/D62425 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [PATCH] D62425: [DWARFExpression] Remove ctor that takes just a compile unit.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:508-509 uint32_t block_length = form_value.Unsigned(); - frame_base->SetOpcodeData(module, debug_info_data, block_offset, -