[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 201377. kusmour added a comment. update the `CreateDefaultUnwindPlan`. return false or give empty Unwind Plan may cause lldb to crash and break tests on windows. So for now, copy the SysV-x86_64 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 201349. aadsm added a comment. Rebase and fixed an issue with one of the asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61235/new/ https://reviews.llvm.org/D61235 Files: lldb/include/lldb/Utility/Timer

[Lldb-commits] [lldb] r361676 - Revert Xcode scheme changes from 361675

Author: gclayton Date: Fri May 24 15:12:01 2019 New Revision: 361676 URL: http://llvm.org/viewvc/llvm-project?rev=361676&view=rev Log: Revert Xcode scheme changes from 361675 Modified: lldb/trunk/lldb.xcodeproj/xcshareddata/xcschemes/desktop.xcscheme Modified: lldb/trunk/lldb.xcodeproj/xcsh

[Lldb-commits] [PATCH] D62416: Cleanup fixed form sizes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361675: Cleanup fixed form sizes. (authored by gclayton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D62416?v

[Lldb-commits] [lldb] r361675 - Cleanup fixed form sizes.

Author: gclayton Date: Fri May 24 15:08:50 2019 New Revision: 361675 URL: http://llvm.org/viewvc/llvm-project?rev=361675&view=rev Log: Cleanup fixed form sizes. The fix form sizes use to have two arrays: one for 4 byte addresses and in for 8 byte addresses. The table had an issue where DW_FORM_f

[Lldb-commits] [lldb] r361673 - [Target] Make Processes' GetLanguageRuntime non-virtual

Author: xiaobai Date: Fri May 24 14:27:37 2019 New Revision: 361673 URL: http://llvm.org/viewvc/llvm-project?rev=361673&view=rev Log: [Target] Make Processes' GetLanguageRuntime non-virtual Modified: lldb/trunk/include/lldb/Target/Process.h Modified: lldb/trunk/include/lldb/Target/Process.h

[Lldb-commits] [lldb] r361672 - [DWARFExpression] Remove commented-out code (NFC)

Author: jdevlieghere Date: Fri May 24 14:26:30 2019 New Revision: 361672 URL: http://llvm.org/viewvc/llvm-project?rev=361672&view=rev Log: [DWARFExpression] Remove commented-out code (NFC) Modified: lldb/trunk/source/Expression/DWARFExpression.cpp Modified: lldb/trunk/source/Expression/DWARF

[Lldb-commits] [PATCH] D62425: [DWARFExpression] Remove ctor that takes just a compile unit.

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, clayborg, labath. Herald added a project: LLDB. JDevlieghere updated this revision to Diff 201331. JDevlieghere added a comment. s/SetOpcodeData/UpdateValue/ Like many of our DWARF classes, the DWARFExpression can be init

[Lldb-commits] [PATCH] D62425: [DWARFExpression] Remove ctor that takes just a compile unit.

JDevlieghere updated this revision to Diff 201331. JDevlieghere added a comment. s/SetOpcodeData/UpdateValue/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62425/new/ https://reviews.llvm.org/D62425 Files: lldb/include/lldb/Expression/DWARFExpression.h lldb/source/Expression/DWARFE

[Lldb-commits] [PATCH] D62416: Cleanup fixed form sizes.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks like a good change. Small comment inline but otherwise LGTM. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3170 uint32_t

[Lldb-commits] [lldb] r361666 - [Process] Clean up some logic around LanguageRuntimes

Author: xiaobai Date: Fri May 24 12:39:50 2019 New Revision: 361666 URL: http://llvm.org/viewvc/llvm-project?rev=361666&view=rev Log: [Process] Clean up some logic around LanguageRuntimes Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trunk/source/Target/Process.cpp URL: http

[Lldb-commits] [PATCH] D62416: Cleanup fixed form sizes.

clayborg updated this revision to Diff 201302. clayborg added a comment. Removed unused function added to DWARFFormValue CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62416/new/ https://reviews.llvm.org/D62416 Files: source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.cpp source/Plugins/S

[Lldb-commits] [PATCH] D62416: Cleanup fixed form sizes.

clayborg created this revision. clayborg added reviewers: labath, aprantl, JDevlieghere. Herald added a subscriber: arphaman. The fix form sizes use to have two arrays: one for 4 byte addresses and in for 8 byte addresses. The table had an issue where DW_FORM_flag_present wasn't being represente

[Lldb-commits] [PATCH] D62395: WIP: Dont vend lldb_private::CompileUnits for DWARFTypeUnits

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:318-319 case DW_AT_decl_file: -decl.SetFile(sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex( -form_value.Unsigned())); break;

[Lldb-commits] [PATCH] D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName

This revision was automatically updated to reflect the committed changes. Closed by commit rL361650: [ASTImporter] Call to HandleNameConflict in VisitRecordDecl mistakeningly using… (authored by shafik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName

davide added a comment. To elaborate further, I'm not familiar with this code so I really shouldn't be the person to approve the patch. On the other hand I'm somewhat nervous as refactors in this area of the codebase caused bugs/crashes in lldb, fundamentally due to changes in behavior previou

[Lldb-commits] [PATCH] D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName

davide resigned from this revision. davide added a comment. This revision is now accepted and ready to land. I don't think I'm qualified enough to comment further on this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62352/new/ https://reviews.llvm.org/D62352 _

[Lldb-commits] [PATCH] D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName

shafik added a comment. @davide We have a reproducer but so far it has proven difficult to narrow it down to a test case. This is serious regression b/c this leads to fields being dropped in records during expression evaluation leading to results that looks like a bug but are actually expressio

[Lldb-commits] [PATCH] D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Do you have a testcase? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62352/new/ https://reviews.llvm.org/D62352 ___ lldb-comm

[Lldb-commits] [PATCH] D62395: WIP: Dont vend lldb_private::CompileUnits for DWARFTypeUnits

labath created this revision. labath added reviewers: clayborg, JDevlieghere, aprantl, jingham. Herald added a subscriber: jdoerfert. This patch isn't meant to be committed, but it is here to demostrate what it would take to implement the idea proposed by Greg in D62073#1507063

[Lldb-commits] [PATCH] D62374: FuncUnwinders: prefer debug_frame over eh_frame

labath created this revision. labath added reviewers: jasonmolenda, clayborg. The two sections usually contain the same information, and we rarely have both kinds of entries for a single function. However, in theory the debug_frame plan can be more complete, whereas eh_frame is only required to be

[Lldb-commits] [PATCH] D61853: [FuncUnwinders] Use "symbol file" unwind plans for unwinding

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361618: [FuncUnwinders] Use "symbol file" unwind plans for unwinding (authored by labath, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D61853?vs=200

[Lldb-commits] [lldb] r361618 - [FuncUnwinders] Use "symbol file" unwind plans for unwinding

Author: labath Date: Fri May 24 02:54:39 2019 New Revision: 361618 URL: http://llvm.org/viewvc/llvm-project?rev=361618&view=rev Log: [FuncUnwinders] Use "symbol file" unwind plans for unwinding Summary: Previous patch (r360409) introduced the "symbol file unwind plan" concept, but that plan wasn'

[Lldb-commits] [PATCH] D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62352/new/ https://reviews.llvm.org/D62352 ___ lldb-commits maili

[Lldb-commits] [PATCH] D62246: DWARF: Implement DW_AT_signature lookup for type unit support

This revision was automatically updated to reflect the committed changes. Closed by commit rL361603: DWARF: Implement DW_AT_signature lookup for type unit support (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHA

[Lldb-commits] [lldb] r361603 - DWARF: Implement DW_AT_signature lookup for type unit support

Author: labath Date: Fri May 24 01:11:12 2019 New Revision: 361603 URL: http://llvm.org/viewvc/llvm-project?rev=361603&view=rev Log: DWARF: Implement DW_AT_signature lookup for type unit support Summary: This patch implements the main feature of type units. When completing a type, if we encounter

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361602: DWARFContext: Make loading of sections thread-safe (authored by labath, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D62316?vs=200970&id=201

[Lldb-commits] [lldb] r361602 - DWARFContext: Make loading of sections thread-safe

Author: labath Date: Fri May 24 01:04:03 2019 New Revision: 361602 URL: http://llvm.org/viewvc/llvm-project?rev=361602&view=rev Log: DWARFContext: Make loading of sections thread-safe Summary: SymbolFileDWARF used to load debug sections in a thread-safe manner. When we moved to DWARFContext, we d

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

labath marked an inline comment as done. labath added a comment. In D62316#1513905 , @clayborg wrote: > In D62316#1513894 , @labath wrote: > > > Two other options I see are: > > > > - initialize the sections immedia