[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

labath added a comment. It looks like diff now contains the changes from D61833 as well. It would be better to upload just the changes relative to the previous patch in the series, otherwise things get confusing about what is being changed where. It's kind of o

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

labath added inline comments. Comment at: lldb/unittests/Host/CMakeLists.txt:12-13 TaskPoolTest.cpp + SocketTestUtilities.cpp + ConnectionFileDescriptorTest.cpp ) Please sort this list before committing. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D62159: LLGS: support 32-bit on 64-bit hosts

labath added a comment. BTW, there's no fundamental reason why a 64-bit lldb-server has to use instruction emulation for debugging arm32 binaries. Since all arm64 chips support hardware single stepping, we could just teach the arm32 native register context to issue PTRACE_SINGLESTEP commands wh

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm updated this revision to Diff 200403. aadsm added a comment. Herald added subscribers: jfb, mgorny. - Change GetConnectURI to GetRemoteConnectionURI - Fixes tests when it comes to using dangling pointers on ConstRefs - Better usage of the EXPECT_* macros. Repository: rG LLVM Github Monor

[Lldb-commits] [lldb] r361216 - [CMake] Correct some dependencies

Author: xiaobai Date: Mon May 20 20:41:05 2019 New Revision: 361216 URL: http://llvm.org/viewvc/llvm-project?rev=361216&view=rev Log: [CMake] Correct some dependencies Symbol doesn't depend on CPlusPlusLanguage, but Expressiond does. Modified: lldb/trunk/source/Expression/CMakeLists.txt

[Lldb-commits] [PATCH] D62168: [DynamicLoader] Make sure we always set the rendezvous breakpoint

aadsm created this revision. aadsm added reviewers: ADodds, clayborg, eugene. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Once we've attached to the process we load all current modules and also set a breakpoint at the rendezvous break address. However, we don't do this

[Lldb-commits] [PATCH] D62159: LLGS: support 32-bit on 64-bit hosts

compnerd closed this revision. compnerd added a comment. SVN r361210 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62159/new/ https://reviews.llvm.org/D62159 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] r361210 - lldb-server: LLGS: support 32-bit on 64-bit hosts

Author: compnerd Date: Mon May 20 18:25:48 2019 New Revision: 361210 URL: http://llvm.org/viewvc/llvm-project?rev=361210&view=rev Log: lldb-server: LLGS: support 32-bit on 64-bit hosts Enable the ARM emulation support on AArch64 which can execute ARM32 code. Similarly, handle MIPS 32 on 64. Modi

[Lldb-commits] [PATCH] D62061: Add AST logging

JDevlieghere added inline comments. Comment at: lldb/source/Symbol/ClangASTImporter.cpp:956 + Log *log_ast(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_AST)); + if (log_ast) { +std::string name_string; Why not `if (Log* log_ast = lldb_pri

[Lldb-commits] [PATCH] D62159: LLGS: support 32-bit on 64-bit hosts

compnerd updated this revision to Diff 200366. compnerd added a comment. Fix inclusion Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62159/new/ https://reviews.llvm.org/D62159 Files: tools/lldb-server/SystemInitializerLLGS.cpp Index: tools/lldb-server/Syst

[Lldb-commits] [PATCH] D62159: LLGS: support 32-bit on 64-bit hosts

xiaobai added a comment. Unsure about the MIPS one but the ARM/ARM64 one looks right to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62159/new/ https://reviews.llvm.org/D62159 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/source/Host/posix/DomainSocket.cpp:130 + +std::string DomainSocket::GetSocketName() const { + if (m_socket != kInvalidSocketValue) { labath wrote: > This should also be `GetRe

[Lldb-commits] [PATCH] D62159: LLGS: support 32-bit on 64-bit hosts

compnerd created this revision. compnerd added reviewers: xiaobai, labath, clayborg. Herald added subscribers: abidh, atanasyan, kristof.beyls, arichardson, javed.absar, sdardis. Herald added a project: LLDB. Enable the ARM emulation support on AArch64 which can execute ARM32 code. Similarly, h

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

aadsm updated this revision to Diff 200353. aadsm edited the summary of this revision. aadsm added a comment. - Fixed function from const to static (mea culpa) - Fixed inet_pton usage on windows - Fixed issue with GetURL return creating a temp object Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D62008: DWARF: Introduce DWARFTypeUnit class

aprantl added inline comments. Comment at: lit/SymbolFile/DWARF/debug-types-expressions.test:28 +# CHECK-LABEL: print ns::A() +# CHECK: (ns::A) $1 = (i = 147) [This is more a meta-point and I don't care very strongly about it] For a test of the DWARF parser, is i

[Lldb-commits] [PATCH] D62073: DWARF: Introduce DWARFUnitHeader class

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Fine if we get things in quick! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62073/new/ https://reviews.llvm.org/D62073 ___ lldb-co

[Lldb-commits] [PATCH] D62008: DWARF: Introduce DWARFTypeUnit class

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Ok, as long as we get things in soon, some functionality is better than none. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62008/new/ https://reviews.llvm.org/D62008 _

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot added a comment. In D60962#1504921 , @labath wrote: > Adrian is on vacation now, but given that he was just waiting until you > resolve my comments (which you have), I think we don't have to wait for him. Thank you for one more review. Repos

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

labath added a comment. `GetRemoteConnectionURI` sounds fine. Comment at: lldb/source/Host/posix/DomainSocket.cpp:130 + +std::string DomainSocket::GetSocketName() const { + if (m_socket != kInvalidSocketValue) { This should also be `GetRemoteSocketName` or so

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

labath added a comment. BTW, given that we recommend using ninja pretty much everywhere, you might want to include `set(CMAKE_GENERATOR Ninja)` Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61956/new/ https://reviews.llvm.org/D61956 ___

[Lldb-commits] [PATCH] D62008: DWARF: Introduce DWARFTypeUnit class

labath added a comment. Replying here as this is the relevant patch. In D62073#1507063 , @clayborg wrote: > Are type units still disabled with the kill switch we had in? Or is this on > top of the .debug_types patch? We have an internal .debug_types patc

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm marked an inline comment as done. aadsm added a comment. Glad you brought the naming up, I was also not happy with it. I guess I kind of convinced myself in the end with "it's the url the socket used to create its connection". The other name I tinkered with was `GetConnectRemoteURI`, I wan

[Lldb-commits] [PATCH] D62008: DWARF: Parse type units from the debug_types section

labath updated this revision to Diff 200230. labath added a comment. - rebase on top of the DWARFUnitHeader patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62008/new/ https://reviews.llvm.org/D62008 Files: lit/SymbolFile/DWARF/Inputs/debug-types-basic.cpp lit/SymbolFile/DWARF/I

[Lldb-commits] [PATCH] D62073: Introduce DWARFUnitHeader and use it to parse type units out of .debug_info

labath updated this revision to Diff 200227. labath added a comment. Rebase so that this does not require any debug_types support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62073/new/ https://reviews.llvm.org/D62073 Files: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp so

[Lldb-commits] [PATCH] D62073: Introduce DWARFUnitHeader and use it to parse type units out of .debug_info

labath marked an inline comment as done. labath added a comment. In D62073#1507001 , @aprantl wrote: > Nice! FYI, we have a bot that runs the LLDB dotests against DWARF5 (the last > stage http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/) t

[Lldb-commits] [PATCH] D61505: Implement .debug_types

jankratochvil abandoned this revision. jankratochvil added a comment. It should be obsoleted by D62073 and future @labath patches. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61505/new/ https://reviews.llvm.org/D61505 ___

[Lldb-commits] [lldb] r361127 - DWARF: Port most of other sections over to DWARFContext

Author: labath Date: Mon May 20 01:38:47 2019 New Revision: 361127 URL: http://llvm.org/viewvc/llvm-project?rev=361127&view=rev Log: DWARF: Port most of other sections over to DWARFContext This moves the sections from SymbolFileDWARF to DWARFContext, where it was trivial to do so. A couple of sec

[Lldb-commits] [lldb] r361126 - minidump: Remove checked-in files used for testing MemoryList handling

Author: labath Date: Mon May 20 01:22:59 2019 New Revision: 361126 URL: http://llvm.org/viewvc/llvm-project?rev=361126&view=rev Log: minidump: Remove checked-in files used for testing MemoryList handling Now that yaml2obj supports this stream, we can use the yaml form instead. Removed: lldb/

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

labath added a comment. The patch looks fine, modulo some inline nits. I am somewhat doubtful about the name of the new function though. When I first saw `GetConnectURI`, i thought this would be the URI used to connect to `this` socket, but in reality it is the URI of the other end (right?). In

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

labath accepted this revision. labath added a comment. Ok, let's give this a shot. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61687/new/ https://reviews.llvm.org/D61687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

labath added inline comments. Comment at: unittests/Host/ConnectionFileDescriptorTest.cpp:41 +llvm::StringRef path; +EXPECT_TRUE(UriParser::Parse(connection_file_descriptor.GetURI(), scheme, + hostname, port, path)); Judgin