[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2118 +void CommandInterpreter::SourceInitFile(FileSpec file, CommandReturnObject &result) { + if

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

JDevlieghere created this revision. JDevlieghere added reviewers: labath, xiaobai, jingham. Herald added a project: LLDB. JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2118 +void Comma

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

Hui added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py:208-212 +# In current implementation of llgs on Windows, as a response to '\x03' packet, the debugger +# of the native process will trigger a call

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

MaskRay added a comment. In D54747#1459175 , @rocallahan wrote: > Updated results for the rusoto test in > https://github.com/rust-lang/rust/issues/56068#issue-382175735. The test > changed a bit because I'm using an updated Rust toolchain and `rusoto_co

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

JDevlieghere added a comment. No objections from me to checking in caches for common configurations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61956/new/ https://reviews.llvm.org/D61956 ___ lldb-co

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

Hui added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py:40 +@skipIfWindows # For now the signo in T* packet is always 0. @llgs_test labath wrote: > labath wrote: > > Do you have any

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

rnk added a comment. I think there's an issue with the whole idea of dropping .debug_info from objects without live sections. Consider: // a.cpp int main() { return f(); } // b.cpp struct Foo { int x, y; }; int f() { volatile Foo var; var.x = 13; var.y = 42;

[Lldb-commits] [lldb] r360822 - Update LLDB license on the LLDB home page to Apache+LLVM.

Author: adrian Date: Wed May 15 14:58:43 2019 New Revision: 360822 URL: http://llvm.org/viewvc/llvm-project?rev=360822&view=rev Log: Update LLDB license on the LLDB home page to Apache+LLVM. Modified: lldb/trunk/docs/index.rst Modified: lldb/trunk/docs/index.rst URL: http://llvm.org/viewvc/

[Lldb-commits] [PATCH] D61913: Get back the navigation sidebar on the LLDB website

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360819: Get back the navigation sidebar on the LLDB website. (authored by adrian, committed by ). Herald added a subscriber: teemperor. Changed prior to commit: https://reviews.llvm.org/D61913?vs=199

[Lldb-commits] [lldb] r360819 - Get back the navigation sidebar on the LLDB website.

Author: adrian Date: Wed May 15 14:49:00 2019 New Revision: 360819 URL: http://llvm.org/viewvc/llvm-project?rev=360819&view=rev Log: Get back the navigation sidebar on the LLDB website. This returns the look & feel of the Sphinx-generated LLDB website to the original pre-Sphinx layout. Different

[Lldb-commits] [PATCH] D61913: Get back the navigation sidebar on the LLDB website

JDevlieghere updated this revision to Diff 199686. JDevlieghere added a comment. Fix pre-padding CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.org/D61913 Files: lldb/docs/CMakeLists.txt lldb/docs/_static/lldb.css lldb/docs/conf.py lldb/docs/index

[Lldb-commits] [PATCH] D61913: Get back the navigation sidebar on the LLDB website

JDevlieghere commandeered this revision. JDevlieghere edited reviewers, added: aprantl; removed: JDevlieghere. JDevlieghere added a comment. Hostile take-over of the patch ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.org/D61913 ___

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

lanza added a comment. Herald added a project: LLVM. @aleksandr.urakov Microsoft's docs state > The first four integer arguments are passed in registers. Integer values are > passed in left-to-right order in RCX, RDX, R8 > , and R9 >

[Lldb-commits] [PATCH] D61913: Get back the navigation sidebar on the LLDB website

JDevlieghere updated this revision to Diff 199683. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.org/D61913 Files: lldb/docs/CMakeLists.txt lldb/docs/_static/lldb.css lldb/docs/conf.py lldb/docs/index.rst lldb/docs/status/about.rst lldb/docs/us

[Lldb-commits] [PATCH] D61913: Get back the navigation sidebar on the LLDB website

aprantl updated this revision to Diff 199676. aprantl added a comment. More tweaks from Jonas & me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.org/D61913 Files: lldb/docs/CMakeLists.txt lldb/docs/_static/lldb.css lldb/docs/conf.py lldb/docs/in

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

shafik added a comment. I ran `check-lldb` and I hit one regression in `TestFormatters.py`, part of what I am seeing is as follows: AssertionError: False is not True : FileCheck'ing result of `expression --show-types -- *(new foo(47))` Error output: error: no matching constructor for init

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

JDevlieghere added a comment. How does this cleanup affect dependency tracking? Does the build dir become unusable after running ninja install? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61952/new/ https://reviews.llvm.org/D61952 ___

[Lldb-commits] [lldb] r360800 - [lldb] [test] Skip one more TestMiBreak on NetBSD

Author: mgorny Date: Wed May 15 13:03:31 2019 New Revision: 360800 URL: http://llvm.org/viewvc/llvm-project?rev=360800&view=rev Log: [lldb] [test] Skip one more TestMiBreak on NetBSD Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py Modified: lldb/

[Lldb-commits] [PATCH] D61502: Permit cross-CU references

This revision was automatically updated to reflect the committed changes. Closed by commit rL360795: Permit cross-CU references (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6

[Lldb-commits] [lldb] r360795 - Permit cross-CU references

Author: jankratochvil Date: Wed May 15 12:22:33 2019 New Revision: 360795 URL: http://llvm.org/viewvc/llvm-project?rev=360795&view=rev Log: Permit cross-CU references So far dw_offset_t was global for the whole SymbolFileDWARF but with .debug_types the same dw_offset_t may mean two different thin

[Lldb-commits] [PATCH] D61502: Permit cross-CU references

jankratochvil marked an inline comment as done. jankratochvil added a comment. In D61502#1503247 , @clayborg wrote: > Just a few simplifications to GetName() and AppendTypeName() are in question > and can optionally be done if needed. I will do that in

[Lldb-commits] [PATCH] D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo()

shafik added a comment. @friss we have several bugs, once of which I can reproduce but I have not been able to reduce it to a minimal case yet and the nullptr check is obviously the right to do. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61805/new/ https://reviews.llvm.org/D61805

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

aprantl added inline comments. Comment at: lldb/cmake/caches/Apple-lldb-osx.cmake:1 +include(${CMAKE_CURRENT_LIST_DIR}/Apple-lldb-base.cmake) + Filename: Apple-lldb-macOS or apple-lldb-macos? MacOS X has been renamed to OS X which has been renamed to macOS :-)

[Lldb-commits] [PATCH] D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo()

shafik updated this revision to Diff 199649. shafik marked 4 inline comments as done. shafik added a comment. Simplified the checking of symbol being a `nullptr` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61805/new/ https://reviews.llvm.org/D61805 Files: source/Target/CPPLanguageR

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

jingham added a comment. In D61921#1503331 , @xiaobai wrote: > In D61921#1503282 , @jingham wrote: > > > In D61921#1502502 , @labath wrote: > > > > > If this iteration is goi

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, compnerd, JDevlieghere, aprantl, labath. Herald added a subscriber: mgorny. Herald added a project: LLDB. CMake cache scripts pre-populate the CMakeCache in a build directory with commonly used settings. The CMake invocation fro

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai added a comment. In D61921#1503282 , @jingham wrote: > In D61921#1502502 , @labath wrote: > > > If this iteration is going to be used a lot, I'd recommend taking a bit of > > time to implement an iterator a

[Lldb-commits] [PATCH] D61913: Get back the navigation sidebar on the LLDB website

aprantl updated this revision to Diff 199642. aprantl added a comment. Add more context to the diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.org/D61913 Files: lldb/docs/CMakeLists.txt lldb/docs/_static/lldb.css lldb/docs/conf.py lldb/docs/i

[Lldb-commits] [PATCH] D61913: Get back the navigation sidebar on the LLDB website

aprantl updated this revision to Diff 199641. aprantl added a comment. Herald added a subscriber: mgorny. I think I addressed most/all of the outstanding bugs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.org/D61913 Files: lldb/docs/CMakeLists.txt l

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

jingham added a comment. In D61921#1502352 , @xiaobai wrote: > In D61921#1502338 , @jingham wrote: > > > Getting it from the Process's m_language_runtimes is probably fine. On > > reflection, I can't think of a re

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

jingham added a comment. In D61921#1502502 , @labath wrote: > If this iteration is going to be used a lot, I'd recommend taking a bit of > time to implement an iterator abstraction over the language runtimes. It > takes a bit longer to set up, but I hope

[Lldb-commits] [PATCH] D61502: Permit cross-CU references

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just a few simplifications to GetName() and AppendTypeName() are in question and can optionally be done if needed. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARF

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, compnerd, JDevlieghere, labath. Herald added subscribers: kristof.beyls, javed.absar, mgorny, ki.stfu. Herald added a project: LLDB. We got used to post-build commands for copying resources into the build-tree framework. Executa

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

clayborg added inline comments. Comment at: packages/Python/lldbsuite/test/dotest.py:1313 # Don't do lldb-server (llgs) tests on anything except Linux. +configuration.dont_do_llgs_test = not ("linux" in target_platform) and not ("windows" in target_platform) -

[Lldb-commits] [PATCH] D61853: [FuncUnwinders] Use "symbol file" unwind plans for unwinding

clayborg added inline comments. Comment at: source/Symbol/FuncUnwinders.cpp:61-70 if (UnwindPlanSP plan_sp = GetEHFrameUnwindPlan(target)) return plan_sp; if (UnwindPlanSP plan_sp = GetDebugFrameUnwindPlan(target)) return plan_sp; if (UnwindPlanSP plan_sp = Get

[Lldb-commits] [PATCH] D61942: DWARFContext: Return empty data extractors instead of null pointers

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/DWARF/DWARFContext.h:26 - const DWARFDataExtractor *getOrLoadArangesData(); + const DWARFDataExtractor &getOrLoadArangesData()

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

aadsm updated this revision to Diff 199619. aadsm added a comment. Move function from anonymous namespace to const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61833/new/ https://reviews.llvm.org/D61833 Files: lldb/source/Host/posix/ConnectionF

[Lldb-commits] [PATCH] D61942: DWARFContext: Return empty data extractors instead of null pointers

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. There are several reasons for doing this: - generally, there's no reason to differentiate between a section being absent and it being present, but empty - it matches more closely what llvm DWARF parser is doin

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

sgraenitz added a comment. Yes, sorry for that. I realized it after the commit was in. The commit I got from arc patch did have the original author information. It must have changed in `git llvm push`, probably because it's still going to SVN and then gets mirrored back to git. I missed this la

[Lldb-commits] [lldb] r360767 - [lldb] [test] Mark frequently failing flaky tests skipped on NetBSD

Author: mgorny Date: Wed May 15 05:13:20 2019 New Revision: 360767 URL: http://llvm.org/viewvc/llvm-project?rev=360767&view=rev Log: [lldb] [test] Mark frequently failing flaky tests skipped on NetBSD Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_s

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

jryans added a comment. @sgraenitz Thanks for committing! 😄 I guess the original author info is lost for this one, but consider adding a "Patch by" line for future commits from those without access. Repository: rL LLVM CHANGES SI

[Lldb-commits] [lldb] r360762 - Delete unnecessary copy ctors/copy assignment operators

Author: maskray Date: Wed May 15 04:23:54 2019 New Revision: 360762 URL: http://llvm.org/viewvc/llvm-project?rev=360762&view=rev Log: Delete unnecessary copy ctors/copy assignment operators It's the simplest and gives the cleanest semantics. Modified: lldb/trunk/include/lldb/Core/ModuleChild

[Lldb-commits] [lldb] r360761 - [lldb] [lit] Pass --mode=compile to fix compiler-full-path.test

Author: mgorny Date: Wed May 15 03:48:55 2019 New Revision: 360761 URL: http://llvm.org/viewvc/llvm-project?rev=360761&view=rev Log: [lldb] [lit] Pass --mode=compile to fix compiler-full-path.test Pass '--mode=compile' to fix compiler-full-path.test failure on NetBSD buildbot (apparently due to l

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

This revision was automatically updated to reflect the committed changes. Closed by commit rL360760: [ASTImporter] Use llvm::Expected and Error in the importer API (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D61885: Minidump: Add support for the MemoryList stream

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM, though I haven't bothered to inspect the detail of the minidump format. I'll leave it up to you whether you think it's worth getting a separate pair of eyes.

[Lldb-commits] [PATCH] D61885: Minidump: Add support for the MemoryList stream

labath updated this revision to Diff 199570. labath marked 6 inline comments as done. labath added a comment. Address review comments. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61885/new/ https://reviews.llvm.org/D61885 Files: include/llvm/Object/Minidump.h

[Lldb-commits] [PATCH] D61885: Minidump: Add support for the MemoryList stream

labath added inline comments. Comment at: include/llvm/Object/Minidump.h:85-86 + /// error is returned if the file does not contain this stream, or if the + /// stream is not large enough to contain the number of threads declared in + /// the stream header. The consistency of

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 199569. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 Files: clang/include/clang/AST/ASTImporter.h clang/lib/AST/ASTIm

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

labath added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteProcessInfo.py:205-217 @skipUnlessPlatform(["linux"]) @llgs_test def test_qProcessInfo_does_not_contain_cputype_cpusubtype_llgs_linux(self): self.init_

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

mgorny added a comment. In D61713#1502606 , @labath wrote: > In D61713#1502580 , @mgorny wrote: > > > Is this test supposed to work portably? It fails on NetBSD buildbot: > > http://lab.llvm.org:8011/builders/netbs

[Lldb-commits] [lldb] r360757 - Group forward declarations in one namespace lldb_private {}

Author: maskray Date: Wed May 15 02:15:13 2019 New Revision: 360757 URL: http://llvm.org/viewvc/llvm-project?rev=360757&view=rev Log: Group forward declarations in one namespace lldb_private {} Modified: lldb/trunk/include/lldb/Core/Address.h lldb/trunk/include/lldb/Core/AddressRange.h

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

labath added a comment. In D61713#1502580 , @mgorny wrote: > Is this test supposed to work portably? It fails on NetBSD buildbot: > http://lab.llvm.org:8011/builders/netbsd-amd64/builds/20101/steps/run%20unit%20tests/logs/FAIL%3A%20LLDB%3A%3Acompiler-full

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

labath added a comment. In D61713#1502617 , @mgorny wrote: > In D61713#1502606 , @labath wrote: > > > In D61713#1502580 , @mgorny wrote: > > > > > Is this test supposed to wo

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: cmake/modules/LLDBConfig.cmake:421 # ensure we build lldb-server when an lldb target is being built. -if (CMAKE_SYSTEM_NAME MATCHES "Android|Darwin|FreeBSD|L

[Lldb-commits] [PATCH] D61502: Permit cross-CU references

labath added a comment. I like this patch in a lot of ways, because it makes the code cleaner, and prepares us for DWARF5, which can reference entries in other files in a lot of interesting ways. The part I am not totally sure if is the alignment of lldb's DWARFFormValue with it's llvm counter

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

This revision was automatically updated to reflect the committed changes. Closed by commit rL360756: [CMake] Add error to clarify that lldb requires libcxx (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r360756 - [CMake] Add error to clarify that lldb requires libcxx

Author: stefan.graenitz Date: Wed May 15 01:59:02 2019 New Revision: 360756 URL: http://llvm.org/viewvc/llvm-project?rev=360756&view=rev Log: [CMake] Add error to clarify that lldb requires libcxx Summary: This adds a specific error message to clarify that lldb requires libcxx when built together

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

mgorny added a comment. Is this test supposed to work portably? It fails on NetBSD buildbot: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/20101/steps/run%20unit%20tests/logs/FAIL%3A%20LLDB%3A%3Acompiler-full-path.test Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D61908: DWARF: Add ability to reference debug info coming from multiple sections

labath updated this revision to Diff 199562. labath marked 4 inline comments as done. labath added a comment. - use enum class for the section type - put DIERef as a member of HashedNameToDie::DIEInfo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61908/new/ https://reviews.llvm.org/D619

[Lldb-commits] [PATCH] D61908: DWARF: Add ability to reference debug info coming from multiple sections

labath marked 10 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:18 if (form_value.IsValid()) { const DWARFUnit *dwarf_cu = form_value.GetCompileUnit(); if (dwarf_cu) { clayborg wrote: > W

[Lldb-commits] [lldb] r360754 - DWARF: s/CompileUnit/Unit/ in DWARFFormValue

Author: labath Date: Wed May 15 00:45:40 2019 New Revision: 360754 URL: http://llvm.org/viewvc/llvm-project?rev=360754&view=rev Log: DWARF: s/CompileUnit/Unit/ in DWARFFormValue The class has been converted to use DWARFUnit, but a number of uses of the words compile unit remained. This removes al

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

labath added a comment. If this iteration is going to be used a lot, I'd recommend taking a bit of time to implement an iterator abstraction over the language runtimes. It takes a bit longer to set up, but I hope we can all agree that `for (runtime: process->GetLanguageRuntimes()) runtime->foo(