[Lldb-commits] [PATCH] D60829: FuncUnwinders: remove "current_offset" from function arguments

jasonmolenda added a comment. Thanks for digging in to this Pavel. I haven't had time to look over the patch today, but I'd like to; I'll make time for it in the next couple days if that's OK. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60829/new/ https://reviews.llvm.org/D60829

[Lldb-commits] [lldb] r358635 - [Shell] Simplify Extracting Python Version

Author: jdevlieghere Date: Wed Apr 17 18:37:19 2019 New Revision: 358635 URL: http://llvm.org/viewvc/llvm-project?rev=358635&view=rev Log: [Shell] Simplify Extracting Python Version Instead of parsing the Python version with a fairly convoluted regex, just print the major and minor version and ca

[Lldb-commits] [lldb] r358629 - [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

Author: kuba.brecka Date: Wed Apr 17 17:15:44 2019 New Revision: 358629 URL: http://llvm.org/viewvc/llvm-project?rev=358629&view=rev Log: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables Differential Revision: https://reviews.llvm.org/

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358629: [lldb] Don't filter variable list when doing a lookup by mangled name in… (authored by kuba.brecka, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] r358625 - [Cmake] Add missing dependency for running tests.

Author: davide Date: Wed Apr 17 16:43:01 2019 New Revision: 358625 URL: http://llvm.org/viewvc/llvm-project?rev=358625&view=rev Log: [Cmake] Add missing dependency for running tests. This is needed now that we marked lldb-test as EXCLUDE_ALL, to make sure `ninja lldb-test-deps` doesn't fail. Mod

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

amccarth added a comment. Thanks for the new test and the test fix. It's unfortunate that the tests are so sensitive to an arbitrary buffer size. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60519/new/ https://reviews.llvm.org/D60519 _

[Lldb-commits] [PATCH] D60405: MinidumpYAML: Add support for ModuleList stream

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Nice! Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:57 +/// record. In memory, we represent these as the ParsedModule struct, which +/// groups minidump::Module with

[Lldb-commits] [lldb] r358615 - [crashlog] Use the right path for dsymforUUID and remove an unnecessary import.

Author: davide Date: Wed Apr 17 14:51:55 2019 New Revision: 358615 URL: http://llvm.org/viewvc/llvm-project?rev=358615&view=rev Log: [crashlog] Use the right path for dsymforUUID and remove an unnecessary import. Modified: lldb/trunk/examples/python/crashlog.py Modified: lldb/trunk/example

[Lldb-commits] [lldb] r358604 - [CMake] Remove Apple-specific version logic.

Author: friss Date: Wed Apr 17 11:23:22 2019 New Revision: 358604 URL: http://llvm.org/viewvc/llvm-project?rev=358604&view=rev Log: [CMake] Remove Apple-specific version logic. We were using the LLDB-Info.plist as the canonical holder of the version number, but there is really no good reason to d

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60737/new/ https://reviews.llvm.org/D60737 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

kubamracek added a comment. Okay. @jingham, any more comments, or is this okay to land? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60737/new/ https://reviews.llvm.org/D60737 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

kubamracek updated this revision to Diff 195596. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60737/new/ https://reviews.llvm.org/D60737 Files: packages/Python/lldbsuite/test/lang/cpp/global_variables/Makefile packages/Python/lldbsuite/test/lang/cpp/global_variables/TestGlobalVaria

[Lldb-commits] [PATCH] D60829: FuncUnwinders: remove "current_offset" from function arguments

labath created this revision. labath added reviewers: jasonmolenda, clayborg. This argument was added back in 2010 (r118882) to support the ability to unwind from functions whose eh_frame entry does not cover the entire range of the function. However, due to the caching happening in FuncUnwinders

[Lldb-commits] [PATCH] D60667: Allow direct comparison of ConstString against StringRef

amccarth accepted this revision. amccarth added a comment. In D60667#1467970 , @teemperor wrote: > In D60667#1467387 , @amccarth wrote: > > > I, too, have some concern that this could have unintended side effects.

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:891-892 + + if (!CreateBinary()) +return UUID(); + auto COFFObj = Hui wrote: > labath wrote: > > I don't think this is necessary as `CreateInstance` will refuse

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

Hui added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:891-892 + + if (!CreateBinary()) +return UUID(); + auto COFFObj = labath wrote: > I don't think this is necessary as `CreateInstance` will refuse to return the > O

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy updated this revision to Diff 195549. leonid.mashinskiy added a comment. - increased buffer size in GetStopDescription call to fit new message Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60519/new/ https://reviews.llvm.org/D60519 Files: l

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, asmith, labath, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, aprantl. This patch adds anonymous namespaces support to the native PDB plugin. I had to

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

labath added a comment. Thanks for adding the test. I guess I've touched this bit when I was working on the dwarf5 index thingy, but all my memory of this function has already been swapped out (and I'm not sure I ever fully understood all the nuances of how it was supposed to work). So yeah, I

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

labath added a comment. In D60153#1469397 , @jgorbe wrote: > Thanks! Please let me know if it happens again and I'll try my best to debug > it. It is still happening (e.g. http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/141), but I already

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

labath added a comment. Thanks. I have a couple of small comments, but I think this is basically done. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:43 +namespace { +using namespace llvm; llvm style is to only use the anonymous namespaces