[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

labath accepted this revision. labath added a comment. LGTM. The ifdefs for the getpid() code and stuff are unfortunate, but I am not sure if using llvm libraries for that is a good idea. Right now we have the ability to compile the tests for a different architecture than the one lldb is built

[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

asmith marked an inline comment as done. asmith added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:74-78 +#if defined(_WIN32) + fprintf(stderr, "PID: %d\n", ::GetCurrentProcessId()); +#else fprintf(stderr, "PID: %d\n", getpid()); +#en

[Lldb-commits] [lldb] r358249 - [IRMemoryMap] Fix -Wimplicit-fallthrough in -DLLVM_ENABLE_ASSERTIONS=off build

Author: maskray Date: Thu Apr 11 19:38:17 2019 New Revision: 358249 URL: http://llvm.org/viewvc/llvm-project?rev=358249&view=rev Log: [IRMemoryMap] Fix -Wimplicit-fallthrough in -DLLVM_ENABLE_ASSERTIONS=off build Modified: lldb/trunk/source/Expression/IRMemoryMap.cpp Modified: lldb/trunk/sou

[Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

shafik marked 2 inline comments as done. shafik added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/namespace_local_var_same_name_cpp_and_c/TestNamespaceLocalVarSameNameCppAndC.py:11 +@skipUnlessDarwin +@add_test_categories(["gmodules"])

[Lldb-commits] [PATCH] D60588: Adjusting libc++ std::list formatter to act better with pointers and references and adding a test to cover a previous related fix

shafik created this revision. shafik added a reviewer: jingham. Herald added a reviewer: EricWF. Herald added a subscriber: christof. This previous fix https://github.com/llvm-mirror/lldb/commit/5469bda296c183d1b6bf74597c88c9ed667b3145 did not have a test since we did not have a reproducer. Thi

Re: [Lldb-commits] [lldb] r358216 - [test] Fix & re-enable CommandScriptImmediateOutputFile on Windows

Hi Greg, Paths with spaces will work because we split from the right and at most once. So unless you provide an invalid syntax to the function (which we control through the test) it should work fine. I’m not saying that my hand rolled thingy replaces shlex in general, but it should do the right t

[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

asmith marked an inline comment as done. asmith added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:188-192 +g_print_mutex.lock(); printf("thread %d id: ", this_thread_index); print_thread_id(); printf("\n"); +g_prin

Re: [Lldb-commits] [lldb] r358216 - [test] Fix & re-enable CommandScriptImmediateOutputFile on Windows

So if there is a space in the path this will fail? shlex does really complex stuff like turn: "hello"' world' into one "hello world" argument. If this is just for one controlled test whose arguments are guaranteed to no ever have any quotes or desensitized spaces like: hello\ world Then it i

[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

clayborg added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:74-78 +#if defined(_WIN32) + fprintf(stderr, "PID: %d\n", ::GetCurrentProcessId()); +#else fprintf(stderr, "PID: %d\n", getpid()); +#endif Is there no llvm h

[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

asmith updated this revision to Diff 194751. asmith added a comment. Address reviewer comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60496/new/ https://reviews.llvm.org/D60496 Files: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp Index: packages/Python/lldbsuite/t

[Lldb-commits] [lldb] r358224 - [lldb] [lit/Register] XFAIL on Darwin

Author: mgorny Date: Thu Apr 11 13:44:40 2019 New Revision: 358224 URL: http://llvm.org/viewvc/llvm-project?rev=358224&view=rev Log: [lldb] [lit/Register] XFAIL on Darwin Modified: lldb/trunk/lit/Register/x86-mm-xmm-read.test Modified: lldb/trunk/lit/Register/x86-mm-xmm-read.test URL: http:

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

amccarth accepted this revision. amccarth added a comment. I'm even happier. Thanks for giving the params more specific names. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60410/new/ https://reviews.llvm.org/D60410 ___ lldb-commits mailin

[Lldb-commits] [lldb] r358216 - [test] Fix & re-enable CommandScriptImmediateOutputFile on Windows

Author: jdevlieghere Date: Thu Apr 11 12:36:53 2019 New Revision: 358216 URL: http://llvm.org/viewvc/llvm-project?rev=358216&view=rev Log: [test] Fix & re-enable CommandScriptImmediateOutputFile on Windows Apparently the shlex module produces garbage on Windows. I've added a hand rolled split ins

[Lldb-commits] [lldb] r358213 - [test] Disable CommandScriptImmediateOutputFile on Windows

Author: jdevlieghere Date: Thu Apr 11 12:18:40 2019 New Revision: 358213 URL: http://llvm.org/viewvc/llvm-project?rev=358213&view=rev Log: [test] Disable CommandScriptImmediateOutputFile on Windows Somehow the path gets messed up. The command looks correct, but the python path is not. (lldb) myw

[Lldb-commits] [PATCH] D60501: Minidump: extend UUID byte-swapping to windows platform

clayborg added a comment. Nice! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60501/new/ https://reviews.llvm.org/D60501 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

clayborg requested changes to this revision. clayborg added a comment. I would really like to see a better solution than just adding all var decls to an expression as this is already costly for C++ and we shouldn't propagate this. I know it used to be really really expensive. Not sure if it stil

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

labath updated this revision to Diff 194705. labath added a comment. After trying to use this in new code, I realized that the CRTP is not really needed for what I am trying to achieve here. The same can be achieved through more standard virtual functions. This updates the patch to use virtual fu

[Lldb-commits] [lldb] r358188 - [lldb] [lit/Register] Mark x86-mm-xmm-read XFAIL on Windows

Author: mgorny Date: Thu Apr 11 09:06:14 2019 New Revision: 358188 URL: http://llvm.org/viewvc/llvm-project?rev=358188&view=rev Log: [lldb] [lit/Register] Mark x86-mm-xmm-read XFAIL on Windows Modified: lldb/trunk/lit/Register/x86-mm-xmm-read.test Modified: lldb/trunk/lit/Register/x86-mm-xmm

[Lldb-commits] [lldb] r358184 - [lldb] [lit/Register] Fix test to use %clangxx

Author: mgorny Date: Thu Apr 11 08:13:17 2019 New Revision: 358184 URL: http://llvm.org/viewvc/llvm-project?rev=358184&view=rev Log: [lldb] [lit/Register] Fix test to use %clangxx Modified: lldb/trunk/lit/Register/x86-mm-xmm-read.test Modified: lldb/trunk/lit/Register/x86-mm-xmm-read.test UR

[Lldb-commits] [PATCH] D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358180: [test] Convert CommandScriptImmediateOutput from pexpect to lit (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D60566?vs=194685&id=194692#toc Re

[Lldb-commits] [lldb] r358180 - [test] Convert CommandScriptImmediateOutput from pexpect to lit

Author: jdevlieghere Date: Thu Apr 11 08:03:07 2019 New Revision: 358180 URL: http://llvm.org/viewvc/llvm-project?rev=358180&view=rev Log: [test] Convert CommandScriptImmediateOutput from pexpect to lit This converts the CommandScriptImmediateOutput test from a python test using pexpect to a lit

[Lldb-commits] [PATCH] D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358178: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers (authored by mgorny, committed by ). Herald added subscribers: teemperor, abidh. Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] r358178 - [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers

Author: mgorny Date: Thu Apr 11 07:58:48 2019 New Revision: 358178 URL: http://llvm.org/viewvc/llvm-project?rev=358178&view=rev Log: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers Fix mistake that mapped mm* registers into the space for xmm* registers, rather than the one shared with s

[Lldb-commits] [PATCH] D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit

JDevlieghere updated this revision to Diff 194685. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Feedback Pavel CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60566/new/ https://reviews.llvm.org/D60566 Files: lldb/lit/Commands/CommandScriptImmediateOutp

[Lldb-commits] [PATCH] D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers

mgorny added a comment. Will do, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60325/new/ https://reviews.llvm.org/D60325 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [PATCH] D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers

labath accepted this revision. labath added a comment. The new version looks really great. Thank you. As I mentioned previously, I think this will probably fail on windows, so I suggest you look out for the bot and be prepared to add an XFAIL here. CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit

labath added inline comments. Comment at: lldb/lit/Commands/CommandScriptImmediateOutput/CommandScriptImmediateOutputFile.test:4-5 + +# RUN: echo "READ" > %t.read.txt +# RUN: echo "READ PLUS" > %t.read_plus.txt + The original test writes to all files it checks.

[Lldb-commits] [PATCH] D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide. Herald added a project: LLDB. This converts the CommandScriptImmediateOutput test from a python test using pexpect to a regular lit test. Repository: rLLDB LLDB https://reviews.llvm.org/D60566 Files: lldb/l

[Lldb-commits] [PATCH] D60501: Minidump: extend UUID byte-swapping to windows platform

This revision was automatically updated to reflect the committed changes. Closed by commit rL358169: Minidump: extend UUID byte-swapping to windows platform (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES S

[Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: packages/Python/lldbsuite/test/expression_command/namespace_local_var_same_name_cpp_and_c/TestNamespaceLocalVarSameNameCppAndC.py:11 +@sk

[Lldb-commits] [lldb] r358169 - Minidump: extend UUID byte-swapping to windows platform

Author: labath Date: Thu Apr 11 07:14:07 2019 New Revision: 358169 URL: http://llvm.org/viewvc/llvm-project?rev=358169&view=rev Log: Minidump: extend UUID byte-swapping to windows platform Summary: D59433 added code to swap bytes UUIDs coming from minidump files, but only enabled it for apple pla

[Lldb-commits] [PATCH] D60563: [pexepect] Add a small sleep between pexect calls

JDevlieghere abandoned this revision. JDevlieghere added a comment. Apparently Pavel already investigated and fixed this in r357459. We also discussed a better way to make this work by checking the echo of the command passed to sendline. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy added a comment. In D60519#1461640 , @amccarth wrote: > Does this affect any existing tests? I didn't notice new failures and didn't find any existing tests for windows exceptions. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy updated this revision to Diff 194664. leonid.mashinskiy added a comment. Herald added a subscriber: teemperor. - added access violation exception message test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60519/new/ https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D60563: [pexepect] Add a small sleep between pexect calls

JDevlieghere added a comment. To give a little more context: the particular issue I was looking at (TestCommandScriptImmediateOutput) occurs with sendline. We send a bunch of commands and always check for the prompt. I can reproduce the error when piping the test commands directly to LLDB. Re

[Lldb-commits] [PATCH] D60563: [pexepect] Add a small sleep between pexect calls

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide. Herald added a project: LLDB. When we upgraded pexpect to a more recent version, we experienced issues where pexpect was sending commands faster to LLDB could process. The problem was especially apparent on CI syst