Re: [Lldb-commits] [lldb] r357141 - Copy the breakpoint site owner's collection so we can drop

On Wed, Mar 27, 2019 at 6:49 PM Jim Ingham via lldb-commits wrote: > > Author: jingham > Date: Wed Mar 27 18:51:33 2019 > New Revision: 357141 > > URL: http://llvm.org/viewvc/llvm-project?rev=357141&view=rev > Log: > Copy the breakpoint site owner's collection so we can drop > the collection lock

[Lldb-commits] [lldb] r357141 - Copy the breakpoint site owner's collection so we can drop

Author: jingham Date: Wed Mar 27 18:51:33 2019 New Revision: 357141 URL: http://llvm.org/viewvc/llvm-project?rev=357141&view=rev Log: Copy the breakpoint site owner's collection so we can drop the collection lock before we iterate over the owners calling ShouldStop. BreakpointSite::ShouldStop can

[Lldb-commits] [PATCH] D59913: Get Version SWIG wrapper should fill the list it makes

jingham created this revision. jingham added a reviewer: labath. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. The "uint32_t *versions, uint32_t num_versions" wrapper makes a list with the number of elements that SBModule::GetVersion said it returns, but if one

[Lldb-commits] [PATCH] D59911: Don't abort() in lldb_assert and document why.

aprantl updated this revision to Diff 192548. Herald added a subscriber: arphaman. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59911/new/ https://reviews.llvm.org/D59911 Files: lldb/docs/index.rst lldb/docs/resources/source.rst lldb/source/Utility/LLDBAssert.cpp lldb/www/source

[Lldb-commits] [PATCH] D59911: Don't abort() in lldb_assert and document why.

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/www/source.html:83 + Assertions. +Assertions (from assert.h) should be used liberally to assert internal consistency. +

[Lldb-commits] [PATCH] D59896: [ObjectFileMachO] Disable memory caching for savecore.

davide added a comment. Done. $ git llvm push Pushing 3 commits: d3e193e68a7 [ObjectFileMachO] Disable memory caching for savecore. 10502683510 [ObjectFileMachO] Remove another debugging aid. a619d7b69b9 [Process] Reorder declarations and document ReadMemoryFromInferior. Sendin

[Lldb-commits] [lldb] r357135 - [ObjectFileMachO] Remove another debugging aid.

Author: davide Date: Wed Mar 27 17:07:20 2019 New Revision: 357135 URL: http://llvm.org/viewvc/llvm-project?rev=357135&view=rev Log: [ObjectFileMachO] Remove another debugging aid. Pointed out by Jason. Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Modified: lldb

[Lldb-commits] [lldb] r357136 - [Process] Reorder declarations and document ReadMemoryFromInferior.

Author: davide Date: Wed Mar 27 17:07:33 2019 New Revision: 357136 URL: http://llvm.org/viewvc/llvm-project?rev=357136&view=rev Log: [Process] Reorder declarations and document ReadMemoryFromInferior. Modified: lldb/trunk/include/lldb/Target/Process.h Modified: lldb/trunk/include/lldb/Target

[Lldb-commits] [PATCH] D59896: [ObjectFileMachO] Disable memory caching for savecore.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357134: [ObjectFileMachO] Disable memory caching for savecore. (authored by davide, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D59896?vs=192496&id=19

[Lldb-commits] [lldb] r357134 - [ObjectFileMachO] Disable memory caching for savecore.

Author: davide Date: Wed Mar 27 17:07:07 2019 New Revision: 357134 URL: http://llvm.org/viewvc/llvm-project?rev=357134&view=rev Log: [ObjectFileMachO] Disable memory caching for savecore. Summary: It's not really useful, and largely increases the footprint. Reviewers: jasonmolenda Subscribers

[Lldb-commits] [PATCH] D59911: Don't abort() in lldb_assert and document why.

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Can you please also update the RST docs? (https://lldb.llvm.org/new-www/) Comment at: lldb/www/source.html:83 + Assertions. +

[Lldb-commits] [PATCH] D59911: Don't abort() in lldb_assert and document why.

aprantl created this revision. aprantl added reviewers: jingham, clayborg, labath, zturner, jasonmolenda. Herald added a project: LLDB. See the changes to the website for the full rationale. Having a policy document that explains when to use what method of error handling in LLDB will make on-boa

[Lldb-commits] [PATCH] D59896: [ObjectFileMachO] Disable memory caching for savecore.

davide added a comment. In D59896#1445310 , @jasonmolenda wrote: > Looks good. Removing that printf is good. Could you also remove the > printf("mach_header:...") in the same function? > > It would be nice if include/lldb/Target/Process.h had the decl

[Lldb-commits] [PATCH] D59847: Regression test to ensure that we handling importing of std::vector of enums correctly

shafik added a comment. @friss so far I have not found any other scenarios that relate specifically to this test outside of the one I already have here https://reviews.llvm.org/D59667 I did find some other bugs though. I will do some more tests as a separate PR unless I can find one directly re

[Lldb-commits] [PATCH] D59896: [ObjectFileMachO] Disable memory caching for savecore.

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good. Removing that printf is good. Could you also remove the printf("mach_header:...") in the same function? It would be nice if include/lldb/Target/Process.h had the decl

[Lldb-commits] [lldb] r357126 - [Python] Remove unused includes

Author: jdevlieghere Date: Wed Mar 27 14:45:11 2019 New Revision: 357126 URL: http://llvm.org/viewvc/llvm-project?rev=357126&view=rev Log: [Python] Remove unused includes Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp lldb/trunk/source/Plugins/ScriptInt

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added a comment. In D55718#1443560 , @labath wrote: > TBE, the best way would be no not even hardcode that info but ask llvm about > these things. `llvm::MCRegisterInfo` doesn't provide us with all necessary fields to create a full `R

[Lldb-commits] [PATCH] D59896: [ObjectFileMachO] Disable memory caching for savecore.

davide updated this revision to Diff 192496. davide added a comment. try CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59896/new/ https://reviews.llvm.org/D59896 Files: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Index: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFile

[Lldb-commits] [lldb] r357115 - Add LLDB_LIBDIR_SUFFIX to Config.h to unbreak the Xcode project

Author: adrian Date: Wed Mar 27 12:22:55 2019 New Revision: 357115 URL: http://llvm.org/viewvc/llvm-project?rev=357115&view=rev Log: Add LLDB_LIBDIR_SUFFIX to Config.h to unbreak the Xcode project Modified: lldb/trunk/include/lldb/Host/Config.h Modified: lldb/trunk/include/lldb/Host/Config.h

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong added a comment. In D59485#1444673 , @teemperor wrote: > In D59485#1439628 , @martong wrote: > > > In D59485#1439570 , @martong wrote: > > > > > In D59485#1439390

[Lldb-commits] [PATCH] D59804: Kill unused variable m_tu_decl_up in SymbolFilePDB

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357113: Kill unused variable m_tu_decl_up in SymbolFilePDB (authored by lanza, committed by ). Herald added subscribers: lldb-commits, teemperor. Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D59896: [ObjectFileMachO] Disable memory caching for savecore.

davide created this revision. davide added a reviewer: jasonmolenda. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. It's not really useful, and largely increases the footprint. rdar://problem/49293525 Repository: rL LLVM https://reviews.llvm.org/D59896 Files: lldb/

[Lldb-commits] [PATCH] D59847: Regression test to ensure that we handling importing of std::vector of enums correctly

shafik added a comment. In D59847#1443905 , @friss wrote: > As we're just adding test coverage, could we add a little more? > > - Anonymous enum > - Enum through a typedef > - class enum > - enum declared inside of the function rather than at the top-level

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor added a comment. In D59485#1439628 , @martong wrote: > In D59485#1439570 , @martong wrote: > > > In D59485#1439390 , @teemperor > > wrote: > > > > > > Well, I stil

[Lldb-commits] [PATCH] D59850: [Platform] Remove Kalimba Platform

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. Apparently this needs to be accepted for me to close it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59850/new/ https://review

[Lldb-commits] [PATCH] D59850: [Platform] Remove Kalimba Platform

JDevlieghere closed this revision. JDevlieghere added a comment. r357086 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59850/new/ https://reviews.llvm.org/D59850 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [lldb] r357086 - [Platform] Remove Kalimba Platform

Author: jdevlieghere Date: Wed Mar 27 09:23:50 2019 New Revision: 357086 URL: http://llvm.org/viewvc/llvm-project?rev=357086&view=rev Log: [Platform] Remove Kalimba Platform This patch removes the Kalimba platform. For more information please refer to the corresponding thread on the mailing list.

[Lldb-commits] [lldb] r357080 - Rename some variables in the std-module tests

Author: labath Date: Wed Mar 27 08:52:11 2019 New Revision: 357080 URL: http://llvm.org/viewvc/llvm-project?rev=357080&view=rev Log: Rename some variables in the std-module tests They cause failures on some systems due to an unrelated bug (pr35043). This works around that. Modified: lldb/tr

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added a comment. In D55718#1443415 , @jasonmolenda wrote: > Back in 2015 I added some code in r247121 that would fill in eh_frame and > dwarf register numbers from the ABI plugin if the remote stub didn't provide > them in ProcessGDBRe

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

JDevlieghere abandoned this revision. JDevlieghere added a comment. Apparently Phabricator is again not importing e-mail replies. As I said per e-mail, I didn't know about the existence of DynamicLibrary in LLVM and only checked LLDB for prior art. CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] r357060 - minidump: Add ability to attach (breakpad) symbol files to placeholder modules

Author: labath Date: Wed Mar 27 03:54:10 2019 New Revision: 357060 URL: http://llvm.org/viewvc/llvm-project?rev=357060&view=rev Log: minidump: Add ability to attach (breakpad) symbol files to placeholder modules This re-commits r354263, which was because it uncovered with handling of modules with

[Lldb-commits] [lldb] r357056 - Fix a "memset clearing an object of non-trivial type" warning in DWARFFormValue

Author: labath Date: Wed Mar 27 03:02:36 2019 New Revision: 357056 URL: http://llvm.org/viewvc/llvm-project?rev=357056&view=rev Log: Fix a "memset clearing an object of non-trivial type" warning in DWARFFormValue This is diagnosed by gcc-8. The ValueType struct already has a default constructor w

[Lldb-commits] [PATCH] D59495: Fix an out-of-bounds error in RegisterContextDarwin_arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rL357055: Fix an out-of-bounds error in RegisterContextDarwin_arm64 (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[Lldb-commits] [lldb] r357055 - Fix an out-of-bounds error in RegisterContextDarwin_arm64

Author: labath Date: Wed Mar 27 02:39:46 2019 New Revision: 357055 URL: http://llvm.org/viewvc/llvm-project?rev=357055&view=rev Log: Fix an out-of-bounds error in RegisterContextDarwin_arm64 Summary: gcc diagnoses this as "array subscript 63 is above array bounds of 'RegisterContextDarwin_arm64::

[Lldb-commits] [PATCH] D59495: Fix an out-of-bounds error in RegisterContextDarwin_arm64

labath added a comment. Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59495/new/ https://reviews.llvm.org/D59495 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. In D59854#1444108 , @mgorny wrote: > Is there a reason you can't reuse/extend `DynamicLibrary` from `LLVMSupport`? +1. It sounds like you do

Re: [Lldb-commits] [lldb] r357034 - [Python] Remove dynamic indirection

Wohoo. On 26/03/2019 23:51, Davide Italiano via lldb-commits wrote: This is great! On Tue, Mar 26, 2019 at 2:55 PM Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Tue Mar 26 14:57:02 2019 New Revision: 357034 URL: http://llvm.org/viewvc/llvm-project?rev=357034&view=rev