[Lldb-commits] [lldb] r356003 - [TestBatchMode] We already log this output to a file.

Author: davide Date: Tue Mar 12 19:47:51 2019 New Revision: 356003 URL: http://llvm.org/viewvc/llvm-project?rev=356003&view=rev Log: [TestBatchMode] We already log this output to a file. Modified: lldb/trunk/packages/Python/lldbsuite/test/driver/batch_mode/TestBatchMode.py Modified: lldb/tr

[Lldb-commits] [lldb] r356002 - [testsuite] Remove other traces broken in python 3.

Author: davide Date: Tue Mar 12 19:44:32 2019 New Revision: 356002 URL: http://llvm.org/viewvc/llvm-project?rev=356002&view=rev Log: [testsuite] Remove other traces broken in python 3. They can be reinstated in case somebody needs to debug this test in the future. Modified: lldb/trunk/packag

[Lldb-commits] [lldb] r356000 - [testsuite] Remove dead code in TestFormats.

Author: davide Date: Tue Mar 12 18:26:01 2019 New Revision: 356000 URL: http://llvm.org/viewvc/llvm-project?rev=356000&view=rev Log: [testsuite] Remove dead code in TestFormats. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/format/TestFormats.py Modified: lldb/trunk/p

[Lldb-commits] [lldb] r355998 - [Python] Fix another batch of python 2/python 3 portability issues.

Author: davide Date: Tue Mar 12 17:48:29 2019 New Revision: 355998 URL: http://llvm.org/viewvc/llvm-project?rev=355998&view=rev Log: [Python] Fix another batch of python 2/python 3 portability issues. Modified: lldb/trunk/examples/summaries/synth.py lldb/trunk/packages/Python/lldbsuite/t

[Lldb-commits] [lldb] r355999 - [test] Some unicode sequences can't be printed, and Py 3 is more picky.

Author: davide Date: Tue Mar 12 17:48:32 2019 New Revision: 355999 URL: http://llvm.org/viewvc/llvm-project?rev=355999&view=rev Log: [test] Some unicode sequences can't be printed, and Py 3 is more picky. Given this was under trace, it can just be removed. If somebody ever needs to debug this tes

[Lldb-commits] [lldb] r355994 - Update the macOS implementation of ComputeClangResourceDirectory to

Author: adrian Date: Tue Mar 12 16:59:02 2019 New Revision: 355994 URL: http://llvm.org/viewvc/llvm-project?rev=355994&view=rev Log: Update the macOS implementation of ComputeClangResourceDirectory to comply with the more pedantic TestPaths.py Modified: lldb/trunk/source/Plugins/ExpressionPar

[Lldb-commits] [PATCH] D59276: Delete dead code

zturner added a comment. In D59276#1426972 , @aprantl wrote: > One one hand this seems fine to remove, but on the other hand — won't these > functions come in handy to compare and debug differences between the LLDB and > LLVM DWARF parsers, while we are

[Lldb-commits] [PATCH] D59276: Delete dead code

aprantl added a comment. One one hand this seems fine to remove, but on the other hand — won't these functions come in handy to compare and debug differences between the LLDB and LLVM DWARF parsers, while we are switching over? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59276/new/

[Lldb-commits] [lldb] r355992 - This test is failing on and off on the bots.

Author: jingham Date: Tue Mar 12 16:15:48 2019 New Revision: 355992 URL: http://llvm.org/viewvc/llvm-project?rev=355992&view=rev Log: This test is failing on and off on the bots. Disable it for now till I can figure out what's going wrong. Modified: lldb/trunk/lit/ExecControl/StopHook/stop-

[Lldb-commits] [PATCH] D59276: Delete dead code

zturner created this revision. zturner added reviewers: clayborg, aprantl. Herald added subscribers: jdoerfert, mgorny. Most of these are Dump functions that are never called, but there is one instance of entire unused classes (DWARFDebugMacinfo and DWARFDebugMacinfoEntry) which are also unrefer

[Lldb-commits] [lldb] r355991 - Fix the broken Batch test by passing a custom module cache to the inferior lldb.

Author: adrian Date: Tue Mar 12 15:20:29 2019 New Revision: 355991 URL: http://llvm.org/viewvc/llvm-project?rev=355991&view=rev Log: Fix the broken Batch test by passing a custom module cache to the inferior lldb. Modified: lldb/trunk/packages/Python/lldbsuite/test/driver/batch_mode/TestBatch

[Lldb-commits] [lldb] r355990 - Revert "Temporarily add more logging to TestBatchMode"

Author: adrian Date: Tue Mar 12 15:20:26 2019 New Revision: 355990 URL: http://llvm.org/viewvc/llvm-project?rev=355990&view=rev Log: Revert "Temporarily add more logging to TestBatchMode" Modified: lldb/trunk/packages/Python/lldbsuite/test/driver/batch_mode/TestBatchMode.py Modified: lldb/t

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL355989: Add XCOFF triple object format type for AIX (authored by jasonliu, committed by ). Herald added a subscriber: kris

[Lldb-commits] [lldb] r355985 - Add more logging to ClangModulesDeclVendor.cpp

Author: adrian Date: Tue Mar 12 14:30:47 2019 New Revision: 355985 URL: http://llvm.org/viewvc/llvm-project?rev=355985&view=rev Log: Add more logging to ClangModulesDeclVendor.cpp Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp Modified: lldb/trunk/sour

[Lldb-commits] [lldb] r355986 - Temporarily add more logging to TestBatchMode

Author: adrian Date: Tue Mar 12 14:30:50 2019 New Revision: 355986 URL: http://llvm.org/viewvc/llvm-project?rev=355986&view=rev Log: Temporarily add more logging to TestBatchMode Modified: lldb/trunk/packages/Python/lldbsuite/test/driver/batch_mode/TestBatchMode.py Modified: lldb/trunk/pack

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355975: Remove support for DWARF64. (authored by zturner, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D59235?vs=190173&id=190326#toc Repository:

[Lldb-commits] [PATCH] D59165: Remove DWARFDIECollection

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355974: Remove DWARFDIECollection. (authored by zturner, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D59165?vs=189961&id=190325#toc Repository:

[Lldb-commits] [PATCH] D59164: [SymbolFileDWARF] Move ElaboratingDIEIterator into implementation file

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355973: Move ElaboratingDIEIterator into implementation file. (authored by zturner, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D59164?vs=189959&id

[Lldb-commits] [lldb] r355975 - Remove support for DWARF64.

Author: zturner Date: Tue Mar 12 13:51:05 2019 New Revision: 355975 URL: http://llvm.org/viewvc/llvm-project?rev=355975&view=rev Log: Remove support for DWARF64. LLVM doesn't produce DWARF64, and neither does GCC. LLDB's support for DWARF64 is only partial, and if enabled appears to also not wor

[Lldb-commits] [lldb] r355973 - Move ElaboratingDIEIterator into implementation file.

Author: zturner Date: Tue Mar 12 13:50:29 2019 New Revision: 355973 URL: http://llvm.org/viewvc/llvm-project?rev=355973&view=rev Log: Move ElaboratingDIEIterator into implementation file. This is not used outside of the private implementation of the class, so hiding in the implementation file is

[Lldb-commits] [lldb] r355974 - Remove DWARFDIECollection.

Author: zturner Date: Tue Mar 12 13:50:46 2019 New Revision: 355974 URL: http://llvm.org/viewvc/llvm-project?rev=355974&view=rev Log: Remove DWARFDIECollection. This is a very thin wrapper over a std::vector and does not seem to provide any real value over just using a container directly. Differ

[Lldb-commits] [PATCH] D59159: [third-party] Update pexpect to 4.6.

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355967: [third-party] Update pexpect to 4.6. (authored by davide, committed by ). Herald added a project: LLDB. Chan

[Lldb-commits] [lldb] r355969 - [lldb/thirdparty] Remove unneeded files, asked by Jonas.

Author: davide Date: Tue Mar 12 13:41:36 2019 New Revision: 355969 URL: http://llvm.org/viewvc/llvm-project?rev=355969&view=rev Log: [lldb/thirdparty] Remove unneeded files, asked by Jonas. Removed: lldb/trunk/third_party/Python/module/pexpect-4.6/doc/ lldb/trunk/third_party/Python/module

[Lldb-commits] [lldb] r355968 - [lldb-mi] Make this test more reliable. NFC.

Author: davide Date: Tue Mar 12 13:41:29 2019 New Revision: 355968 URL: http://llvm.org/viewvc/llvm-project?rev=355968&view=rev Log: [lldb-mi] Make this test more reliable. NFC. Except that it will probably stop failing on and off on my machine. Modified: lldb/trunk/packages/Python/lldbsuit

Re: [Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

Yep yep yep. On Tue, Mar 12, 2019 at 1:24 PM Adrian Prantl via Phabricator wrote: > > aprantl added a comment. > > In D59235#1426716 , @JDevlieghere > wrote: > > > Agreed, and we've been doing this for new patches for a while now. However, > > I very str

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

aprantl added a comment. In D59235#1426716 , @JDevlieghere wrote: > Agreed, and we've been doing this for new patches for a while now. However, I > very strongly prefer having asserts over "returning a default value", which > only hides real bugs. I t

[Lldb-commits] [lldb] r355963 - Fix compiler warning

Author: jdevlieghere Date: Tue Mar 12 13:24:13 2019 New Revision: 355963 URL: http://llvm.org/viewvc/llvm-project?rev=355963&view=rev Log: Fix compiler warning Fixes warning: comparison of integers of different signs. Modified: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLo

Re: [Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

+1. I’ve seen some of the changes in llvm that have changed asserts to return a default value. IMHO these should be changed to return Expected instead On Tue, Mar 12, 2019 at 1:16 PM Jonas Devlieghere via Phabricator < revi...@reviews.llvm.org> wrote: > JDevlieghere added a comment. > > In D59235#

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

JDevlieghere added a comment. In D59235#1426169 , @probinson wrote: > In D59235#1425443 , @zturner wrote: > > > In D59235#1425436 , @clayborg > > wrote: > > > > > My main co

[Lldb-commits] [lldb] r355958 - Rework how lldb warngs about kexts that failed to load in a

Author: jmolenda Date: Tue Mar 12 12:42:34 2019 New Revision: 355958 URL: http://llvm.org/viewvc/llvm-project?rev=355958&view=rev Log: Rework how lldb warngs about kexts that failed to load in a darwin kernel debug session. Originally, the kext name & uuid were emitted in the middle of the kext-

[Lldb-commits] [lldb] r355957 - Check the result of creating a node from __next_ in the std::list formatter.

Author: jingham Date: Tue Mar 12 12:27:39 2019 New Revision: 355957 URL: http://llvm.org/viewvc/llvm-project?rev=355957&view=rev Log: Check the result of creating a node from __next_ in the std::list formatter. There's a single report of a crash coming from this current_sp being NULL. I don't h

[Lldb-commits] [lldb] r355956 - Re-enable this test, the underlying bug was fixed and the test now passes.

Author: jingham Date: Tue Mar 12 12:25:29 2019 New Revision: 355956 URL: http://llvm.org/viewvc/llvm-project?rev=355956&view=rev Log: Re-enable this test, the underlying bug was fixed and the test now passes. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/

[Lldb-commits] [lldb] r355951 - Fix the project for r355939 (ASTUtils.{h, c})

Author: jingham Date: Tue Mar 12 11:48:58 2019 New Revision: 355951 URL: http://llvm.org/viewvc/llvm-project?rev=355951&view=rev Log: Fix the project for r355939 (ASTUtils.{h,c}) Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: htt

[Lldb-commits] [lldb] r355943 - Correcting some comments in PdbIndex.cpp [NFC]

Author: amccarth Date: Tue Mar 12 10:40:51 2019 New Revision: 355943 URL: http://llvm.org/viewvc/llvm-project?rev=355943&view=rev Log: Correcting some comments in PdbIndex.cpp [NFC] ICF can cause multiple symbols to start at the same virtual address. I plan to handle this shortly, but I wanted to

Re: [Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

Fair enough, a FIXME sounds reasonable. On Tue, Mar 12, 2019 at 10:33 AM Jan Kratochvil via Phabricator < revi...@reviews.llvm.org> wrote: > jankratochvil added inline comments. > > > > Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:263 >uint64_t length

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:263 uint64_t length = data.GetU32(&offset); - bool isDwarf64 = (length == 0x); - if (isDwarf64) zturner wrote: > jankratochvil wrote: > > Here

[Lldb-commits] [lldb] r355941 - [Reproducers] Add a test to ensure we can reuse the reproducer dir.

Author: jdevlieghere Date: Tue Mar 12 10:31:04 2019 New Revision: 355941 URL: http://llvm.org/viewvc/llvm-project?rev=355941&view=rev Log: [Reproducers] Add a test to ensure we can reuse the reproducer dir. Yesterday I noticed a reproducer test failing after making a local change. Removing the re

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:89 } llvm_unreachable("invalid UnitType."); } Not your code, but this application of `llvm_unreachable` seems suspicious unless we can guarantee that we a

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

zturner marked an inline comment as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp:170 case DW_FORM_sec_offset: assert(m_cu); + m_value.value.uval = data.GetMaxU64(offset_ptr, 4); jankrato

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

zturner marked an inline comment as done. zturner added a comment. It seems like we're mostly in agreement on the direction of the patch, so if there's no outstanding comments I'll submit at the end of the day. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rL355939: Add ability to import std module into expression parser to improve C++ debugging (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[Lldb-commits] [lldb] r355940 - [Reproducers] Stop recording instead of deallocating

Author: jdevlieghere Date: Tue Mar 12 10:10:28 2019 New Revision: 355940 URL: http://llvm.org/viewvc/llvm-project?rev=355940&view=rev Log: [Reproducers] Stop recording instead of deallocating The command interpreter holds a pointer to a DataRecorder. After generating the reproducer, we deallocate

[Lldb-commits] [lldb] r355939 - Add ability to import std module into expression parser to improve C++ debugging

Author: teemperor Date: Tue Mar 12 10:09:33 2019 New Revision: 355939 URL: http://llvm.org/viewvc/llvm-project?rev=355939&view=rev Log: Add ability to import std module into expression parser to improve C++ debugging Summary: This patch is the MVP version of importing the std module into the expr

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

teemperor updated this revision to Diff 190289. teemperor added a comment. - Rebased patch. - Modernized for loops in ASTUtils. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58125/new/ https://reviews.llvm.org/D58125 Files: lldb/include/lldb/Expression/ExpressionSourceCode.h lldb/i

[Lldb-commits] [PATCH] D59238: [Reproducers] Support capturing a reproducer without an explicit path.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355936: [Reproducers] Support capturing a reproducer without an explicit path. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D59238?vs=190194&id=190284#

[Lldb-commits] [lldb] r355936 - [Reproducers] Support capturing a reproducer without an explicit path.

Author: jdevlieghere Date: Tue Mar 12 09:44:18 2019 New Revision: 355936 URL: http://llvm.org/viewvc/llvm-project?rev=355936&view=rev Log: [Reproducers] Support capturing a reproducer without an explicit path. Tablegen doesn't support options that are both flags and take values as an argument. I

[Lldb-commits] [lldb] r355931 - Revert "[CMake] Avoid clang-tablegen-targets dependency when building sphinx docs (experimental)"

Author: stefan.graenitz Date: Tue Mar 12 08:54:35 2019 New Revision: 355931 URL: http://llvm.org/viewvc/llvm-project?rev=355931&view=rev Log: Revert "[CMake] Avoid clang-tablegen-targets dependency when building sphinx docs (experimental)" This reverts commit 511066858d44101703d61eded9abf8caff0f

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:263 uint64_t length = data.GetU32(&offset); - bool isDwarf64 = (length == 0x); - if (isDwarf64) Here should be an error that DWARF64 is not sup

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

probinson added a comment. In D59235#1425443 , @zturner wrote: > In D59235#1425436 , @clayborg wrote: > > > My main concern with the LLVM DWARF parser is all of the asserts in the > > code. If you attempt to use a

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

clayborg added a comment. In D59235#1425443 , @zturner wrote: > In D59235#1425436 , @clayborg wrote: > > > My main concern with the LLVM DWARF parser is all of the asserts in the > > code. If you attempt to use a D

Re: [Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

The main reason for this that I can see is if we ever want to provide a lldb::user_id_t for a given SBType. We will lose that ability if we remove, but I am ok with this because we can force the TypeSystem to be able to remember this in metadata if we ever do need it. Why? In DWARF that most com

[Lldb-commits] [PATCH] D59198: Correctly look up declarations in inline namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355897: Correctly look up declarations in inline namespaces (authored by teemperor, committed by ). Changed prior to commit: https://reviews.llvm.org/D59198?vs=190111&id=190215#toc Repository: rLL

[Lldb-commits] [lldb] r355897 - Correctly look up declarations in inline namespaces

Author: teemperor Date: Tue Mar 12 00:45:04 2019 New Revision: 355897 URL: http://llvm.org/viewvc/llvm-project?rev=355897&view=rev Log: Correctly look up declarations in inline namespaces Summary: This patch marks the inline namespaces from DWARF as inline and also ensures that looking up declar