[Lldb-commits] [lldb] r355170 - Update com.apple.diagnosticd.diagnostic entitlement

Author: jmolenda Date: Thu Feb 28 19:34:51 2019 New Revision: 355170 URL: http://llvm.org/viewvc/llvm-project?rev=355170&view=rev Log: Update com.apple.diagnosticd.diagnostic entitlement name to the newer com.apple.private.logging.diagnostic. Modified: lldb/trunk/tools/debugserver/source/d

[Lldb-commits] [lldb] r355169 - Increase timeout in Symbols::DownloadObjectAndSymbolFile

Author: jmolenda Date: Thu Feb 28 19:24:59 2019 New Revision: 355169 URL: http://llvm.org/viewvc/llvm-project?rev=355169&view=rev Log: Increase timeout in Symbols::DownloadObjectAndSymbolFile from 30 seconds to 120 seconds. We've seen cases where this symbol lookup can exceed 30 seconds for peop

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

xiaobai planned changes to this revision. xiaobai added a comment. Looks like the test I wrote doesn't pass on MacOS, I need to investigate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58748/new/ https://reviews.llvm.org/D58748 ___ lldb-c

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

xiaobai updated this revision to Diff 188817. xiaobai added a comment. Reword comment to be clearer CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58748/new/ https://reviews.llvm.org/D58748 Files: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py source/Plugins/Expre

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

xiaobai updated this revision to Diff 188816. xiaobai added a comment. Address suggestions and add unit test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58748/new/ https://reviews.llvm.org/D58748 Files: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py source/Plug

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere updated this revision to Diff 188813. JDevlieghere added a comment. Thanks Pavel. I've updated the patch with your suggestion. I agree it's a lot better :-) I implemented the logic in the Debugger rather than the SBDebugger because I think the latter should be a thin wrapper, but l

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere updated this revision to Diff 188809. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58564/new/ https://reviews.llvm.org/D58564 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/IOHandler.h lldb/include/lldb/Utility/Reproducer.h lldb/source/Commands/Comm

[Lldb-commits] [lldb] r355155 - Symbols.cpp in unittest moved too.

Author: jmolenda Date: Thu Feb 28 15:37:28 2019 New Revision: 355155 URL: http://llvm.org/viewvc/llvm-project?rev=355155&view=rev Log: Symbols.cpp in unittest moved too. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.

[Lldb-commits] [PATCH] D58793: [CMake] Make liblldb depend on clang-headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL355149: [CMake] Make liblldb depend on clang-headers (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[Lldb-commits] [lldb] r355149 - [CMake] Make liblldb depend on clang-headers

Author: xiaobai Date: Thu Feb 28 14:24:18 2019 New Revision: 355149 URL: http://llvm.org/viewvc/llvm-project?rev=355149&view=rev Log: [CMake] Make liblldb depend on clang-headers Summary: The clang headers are useful when dealing with clang modules. There is also a way to get to the clang headers

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

shafik added a comment. It stood out to me that some of the conversions were not `const` and I can see that `IsValid` is not consistently `const` across the API but after talking to @jingham it is unfortunately something we can't change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

JDevlieghere resigned from this revision. JDevlieghere added a comment. I believe this isn't relevant anymore after moving Symbols? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58654/new/ https://reviews.llvm.org/D58654 ___ lldb-commits ma

[Lldb-commits] [PATCH] D58793: [CMake] Make liblldb depend on clang-headers

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58793/new/ https://reviews.llvm.org/D58793 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D58793: [CMake] Make liblldb depend on clang-headers

xiaobai created this revision. xiaobai added reviewers: labath, zturner, sgraenitz. Herald added a subscriber: mgorny. The clang headers are useful when dealing with clang modules. There is also a way to get to the clang headers from the SB API so it would be nice if they were also available when

[Lldb-commits] [PATCH] D58790: Adding test to cover the correct import of SourceLocation pertaining to a built-in during expression parsing

shafik updated this revision to Diff 188780. shafik marked 5 inline comments as done. shafik added a comment. Addressing comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58790/new/ https://reviews.llvm.org/D58790 Files: packages/Python/lldbsuite/test/expression_command/import_

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

labath created this revision. labath added reviewers: zturner, jingham, clayborg. Herald added a reviewer: jfb. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: jdoerfert. Our python version of the SB API has (the python equivalent of) operator bool, but the C++ version doesn

[Lldb-commits] [PATCH] D58790: Adding test to cover the correct import of SourceLocation pertaining to a built-in during expression parsing

davide added a comment. Just a drive-by comment. I think writing this as a inline test would make it more compact (and maybe slightly more readable because you don't have to look at two files), but if you prefer this way, I don't have a strong preference. Comment at: package

[Lldb-commits] [PATCH] D58790: Adding test to cover the correct import of SourceLocation pertaining to a built-in during expression parsing

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/TestImportBuiltinFileID.py:18 +@skipUnlessDarwin +@add_test_categories(["gmodules"]) +def test_import_builtin_fileid(self): aprantl wro

[Lldb-commits] [PATCH] D58790: Adding test to cover the correct import of SourceLocation pertaining to a built-in during expression parsing

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/TestImportBuiltinFileID.py:17 + +@skipUnlessDarwin +@add_test_categories(["gmodules"]) The Cocoa framework only exists on macOS, there's a

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

labath added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py:20 +# GetClangResourceDir doesn't work on windows yet +@expectedFailureAll(oslist=["windows"]) @no_debug_info_test xiaobai wrote: > labath wro

[Lldb-commits] [PATCH] D58790: Adding test to cover the correct import of SourceLocation pertaining to a built-in during expression parsing

shafik created this revision. shafik added reviewers: teemperor, aprantl, jingham, martong. Herald added subscribers: jdoerfert, rnkovacs. Herald added a reviewer: serge-sans-paille. This tests a fix in the ASTImpoter.cpp to ensure that we import built-in correctly, see differential: https://rev

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py:20 +# GetClangResourceDir doesn't work on windows yet +@expectedFailureAll(oslist=["windows"]) @no_debug_info_test -

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

labath added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py:20 +# GetClangResourceDir doesn't work on windows yet +@expectedFailureAll(oslist=["windows"]) @no_debug_info_test xiaobai wrote: > teemperor

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

On 28/02/2019 20:29, Davide Italiano wrote: On Thu, Feb 28, 2019 at 11:21 AM Davide Italiano wrote: On Thu, Feb 28, 2019 at 11:19 AM Davide Italiano wrote: If I add: diff --git a/lldb/source/Host/common/MainLoop.cpp b/lldb/source/Host/common/MainLoop.cpp index a4803936196..4fee76865ee 1006

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

On Thu, Feb 28, 2019 at 11:21 AM Davide Italiano wrote: > > On Thu, Feb 28, 2019 at 11:19 AM Davide Italiano > wrote: > > > > If I add: > > > > diff --git a/lldb/source/Host/common/MainLoop.cpp > > b/lldb/source/Host/common/MainLoop.cpp > > index a4803936196..4fee76865ee 100644 > > --- a/lldb/so

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

On Thu, Feb 28, 2019 at 11:19 AM Davide Italiano wrote: > > If I add: > > diff --git a/lldb/source/Host/common/MainLoop.cpp > b/lldb/source/Host/common/MainLoop.cpp > index a4803936196..4fee76865ee 100644 > --- a/lldb/source/Host/common/MainLoop.cpp > +++ b/lldb/source/Host/common/MainLoop.cpp > @

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

If I add: diff --git a/lldb/source/Host/common/MainLoop.cpp b/lldb/source/Host/common/MainLoop.cpp index a4803936196..4fee76865ee 100644 --- a/lldb/source/Host/common/MainLoop.cpp +++ b/lldb/source/Host/common/MainLoop.cpp @@ -23,6 +23,8 @@ // (ppoll is present but not implemented properly). On w

[Lldb-commits] [PATCH] D58648: Improve process launch comments for Windows

amccarth closed this revision. amccarth added a comment. Closed with r355121. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58648/new/ https://reviews.llvm.org/D58648 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] r355121 - Improve process launch comments for Windows

Author: amccarth Date: Thu Feb 28 11:14:02 2019 New Revision: 355121 URL: http://llvm.org/viewvc/llvm-project?rev=355121&view=rev Log: Improve process launch comments for Windows The existing comment about over-allocating the command line was incorrect. The contents of the command line may be ch

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

xiaobai added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py:20 +# GetClangResourceDir doesn't work on windows yet +@expectedFailureAll(oslist=["windows"]) @no_debug_info_test teemperor wrote: > Doesn't

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

On Thu, Feb 28, 2019 at 10:31 AM Davide Italiano wrote: > > On Thu, Feb 28, 2019 at 8:25 AM Raphael Isemann via lldb-commits > wrote: > > > > Am Do., 28. Feb. 2019 um 17:11 Uhr schrieb Pavel Labath via > > lldb-commits : > > > > > > On 28/02/2019 16:18, Pavel Labath via lldb-commits wrote: > > >

[Lldb-commits] [PATCH] D58648: Improve process launch comments for Windows

amccarth added a comment. Thanks. I really don't know what other types of conditions may trigger that "request is not supported" message, so I'm going to shy away from trying to make it more specific. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58648/new/ https://reviews.llvm.org/D

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

On Thu, Feb 28, 2019 at 8:25 AM Raphael Isemann via lldb-commits wrote: > > Am Do., 28. Feb. 2019 um 17:11 Uhr schrieb Pavel Labath via > lldb-commits : > > > > On 28/02/2019 16:18, Pavel Labath via lldb-commits wrote: > > > On 28/02/2019 02:37, Davide Italiano via Phabricator wrote: > > >> davide

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

Am Do., 28. Feb. 2019 um 17:11 Uhr schrieb Pavel Labath via lldb-commits : > > On 28/02/2019 16:18, Pavel Labath via lldb-commits wrote: > > On 28/02/2019 02:37, Davide Italiano via Phabricator wrote: > >> davide added a comment. > >> Herald added a subscriber: jdoerfert. > >> Herald added a projec

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

On 28/02/2019 16:18, Pavel Labath via lldb-commits wrote: On 28/02/2019 02:37, Davide Italiano via Phabricator wrote: davide added a comment. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. Pavel, this broke unicode handling for lldb on MacOS. If you type something in the l

[Lldb-commits] [lldb] r355103 - [cmake] Move LLDB_DISABLE_LIBEDIT handling code into a central place

Author: labath Date: Thu Feb 28 08:04:54 2019 New Revision: 355103 URL: http://llvm.org/viewvc/llvm-project?rev=355103&view=rev Log: [cmake] Move LLDB_DISABLE_LIBEDIT handling code into a central place This was previously scattered between the main CMakeLists.txt file and LLDBGenerateConfig.cmake

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

On 28/02/2019 02:37, Davide Italiano via Phabricator wrote: davide added a comment. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. Pavel, this broke unicode handling for lldb on MacOS. If you type something in the lldb cmdline, it won't print the right character but a serie

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

labath added a comment. In D58564#1412674 , @JDevlieghere wrote: > Pavel made a good point that with the previous implementation, the first call > to RunCommandInterpreter would replay every recorded commands. This is indeed > incorrect, because it's po

[Lldb-commits] [PATCH] D58648: Improve process launch comments for Windows

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks fine to me. If this "The request is not supported" error is something that makes it's way to the user, and the error code is reasonably unambiguous (it +/- only happens when debugging 64