[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57475/new/ https://reviews.llvm.org/D57475 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

JDevlieghere updated this revision to Diff 187287. JDevlieghere added a comment. Herald added a subscriber: jdoerfert. - Rebase - Re-ran the latest version of the tool to insert `LLDB_RECORD_RESULT` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57475/new/ https://reviews.llvm.org/D57475

[Lldb-commits] [lldb] r354303 - [lldb-instr] Test that we ignore existing macros.

Author: jdevlieghere Date: Mon Feb 18 17:20:49 2019 New Revision: 354303 URL: http://llvm.org/viewvc/llvm-project?rev=354303&view=rev Log: [lldb-instr] Test that we ignore existing macros. Although the functionality was already present, it wasn't tested. Modified: lldb/trunk/lit/tools/lldb-i

Re: [Lldb-commits] [lldb] r354105 - Use sys.executable in lldb-dotest

Great! On Thu, Feb 14, 2019 at 11:40 PM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Thu Feb 14 23:41:17 2019 > New Revision: 354105 > > URL: http://llvm.org/viewvc/llvm-project?rev=354105&view=rev > Log: > Use sys.executable in lldb-dotest > > With

[Lldb-commits] [lldb] r354301 - [lldb-instr] Wrap returns of struct/classes in LLDB_RECORD_RESULT

Author: jdevlieghere Date: Mon Feb 18 17:04:31 2019 New Revision: 354301 URL: http://llvm.org/viewvc/llvm-project?rev=354301&view=rev Log: [lldb-instr] Wrap returns of struct/classes in LLDB_RECORD_RESULT The instrumentation framework requires return values of custom classes and structs to be wra

[Lldb-commits] [lldb] r354300 - Disable TestModuleCXX.test on Windows

Author: jdevlieghere Date: Mon Feb 18 16:08:10 2019 New Revision: 354300 URL: http://llvm.org/viewvc/llvm-project?rev=354300&view=rev Log: Disable TestModuleCXX.test on Windows Importing cxx modules doesn't seem to work on Windows: error: a.out :: Class 'tagARRAYDESC' has a member 'tdescElem' of

[Lldb-commits] [lldb] r354297 - [lldbtest] Fix some code to be compatible between py2 and py3.

Author: davide Date: Mon Feb 18 15:18:14 2019 New Revision: 354297 URL: http://llvm.org/viewvc/llvm-project?rev=354297&view=rev Log: [lldbtest] Fix some code to be compatible between py2 and py3. Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/packages/Py

[Lldb-commits] [lldb] r354294 - [lldb-instr] Add constructor and move test into lit/tools

Author: jdevlieghere Date: Mon Feb 18 14:59:52 2019 New Revision: 354294 URL: http://llvm.org/viewvc/llvm-project?rev=354294&view=rev Log: [lldb-instr] Add constructor and move test into lit/tools The test had an implicit constructor for the Foo struct. Also, as the instrumentation doesn't have t

[Lldb-commits] [lldb] r354289 - One more fix while I'm looking at this - remove the

Author: jmolenda Date: Mon Feb 18 14:18:11 2019 New Revision: 354289 URL: http://llvm.org/viewvc/llvm-project?rev=354289&view=rev Log: One more fix while I'm looking at this - remove the unused IsSBProcess method, and have IsFBSProcess return false if we don't have API that we can use to make tha

[Lldb-commits] [lldb] r354288 - Ah, misunderstood Jonas' feedback - fix this so we'll

Author: jmolenda Date: Mon Feb 18 14:13:34 2019 New Revision: 354288 URL: http://llvm.org/viewvc/llvm-project?rev=354288&view=rev Log: Ah, misunderstood Jonas' feedback - fix this so we'll do the right thing when both API are available. We want to try both of them if the first one fails. Modifie

[Lldb-commits] [lldb] r354287 - Clean up an unused variable warning when building this for

Author: jmolenda Date: Mon Feb 18 14:10:23 2019 New Revision: 354287 URL: http://llvm.org/viewvc/llvm-project?rev=354287&view=rev Log: Clean up an unused variable warning when building this for mac native. Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm Modified: lldb/tru

[Lldb-commits] [lldb] r354286 - [Python3] Fix TestObjCMethods.py to work with py2 and 3.

Author: davide Date: Mon Feb 18 13:53:02 2019 New Revision: 354286 URL: http://llvm.org/viewvc/llvm-project?rev=354286&view=rev Log: [Python3] Fix TestObjCMethods.py to work with py2 and 3. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/foundation/TestObjCMethods.py Modified:

[Lldb-commits] [PATCH] D58309: [Reproducers] Have clang make use of lldb's VFS.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354283: [Reproducers] Make clang use lldb's VFS. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[Lldb-commits] [lldb] r354283 - [Reproducers] Make clang use lldb's VFS.

Author: jdevlieghere Date: Mon Feb 18 12:31:18 2019 New Revision: 354283 URL: http://llvm.org/viewvc/llvm-project?rev=354283&view=rev Log: [Reproducers] Make clang use lldb's VFS. In r353906 we hooked up clang and lldb's reproducer infrastructure to capture files used by clang. This patch adds th

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

sgraenitz added a comment. In D58193#1401137 , @serge-sans-paille wrote: > @sgraenitz I currently have this patch applied to LLVM 8rc1 source tree for > fedora, because it wasn't working automagically otherwise. Reading the > discussion, I don't think I

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187264. mgorny added a comment. Herald added a subscriber: jdoerfert. Added comments on how test data was generated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 Files: lldb/lit/Modules/ELF/Inputs/netbsd

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

krytarowski added inline comments. Comment at: lldb/lit/Modules/ELF/netbsd-core.test:3 + +# RUN: lldb-test object-file %S/Inputs/netbsd.core | FileCheck %s +# CHECK: Architecture: x86_64-unknown-netbsd krytarowski wrote: > I propose to keep it as netbsd$VERSION-$

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187261. mgorny added a comment. Rename tests as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 Files: lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core lldb/lit/Modules/ELF/netbsd-core-amd64.test

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

krytarowski added inline comments. Comment at: lldb/lit/Modules/ELF/netbsd-core.test:3 + +# RUN: lldb-test object-file %S/Inputs/netbsd.core | FileCheck %s +# CHECK: Architecture: x86_64-unknown-netbsd I propose to keep it as netbsd$VERSION-$ARCH.core We will wa

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

krytarowski added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1359 + // p = patchlevel + const uint32_t version_major = version_info / 1; + const uint32_t version_minor = (version_info % 1) / 100; ---

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/Makefile:3 +USE_LIBCPP := 1 +CXXFLAGS += -std=c++11 -fmodules -glldb -fimplicit-module-maps +CXX_SOURCES := main.cpp teemperor wrote: >

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/lit/Modules/ELF/netbsd-exec.yaml:1 +# Test whether NetBSD executables are recognized correctly. + I'm not sure if we should keep the whole file or try to strip this a bit. C

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187254. mgorny marked an inline comment as done and an inline comment as not done. mgorny retitled this revision from "Correct recognition of NetBSD images" to "[lldb] [ObjectFile/ELF] Correct recognition of NetBSD images". mgorny edited the summary of this rev

[Lldb-commits] [lldb] r354278 - Un-XFAIL TestLinuxCore for windows

Author: labath Date: Mon Feb 18 08:05:26 2019 New Revision: 354278 URL: http://llvm.org/viewvc/llvm-project?rev=354278&view=rev Log: Un-XFAIL TestLinuxCore for windows It turns out all that was needed to get this test passing was to fix the python3 incompatibility. Modified: lldb/trunk/pack

[Lldb-commits] [lldb] r354273 - Fix TestLinuxCore for python3

Author: labath Date: Mon Feb 18 07:04:33 2019 New Revision: 354273 URL: http://llvm.org/viewvc/llvm-project?rev=354273&view=rev Log: Fix TestLinuxCore for python3 - dictionaries don't have iteritems() - division returns floats Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalit

[Lldb-commits] [PATCH] D58350: Insert random blocks of python code with swig instead of modify-python-lldb.py

labath created this revision. labath added reviewers: zturner, jingham. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: jdoerfert. Swig is perfectly capable of inserting blocks of python code into its output (and we use those fascilities already), so there's no need for this

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

labath added a comment. In D58193#1401137 , @serge-sans-paille wrote: > @sgraenitz I currently have this patch applied to LLVM 8rc1 source tree for > fedora, Could you check what's the state of the master branch? It's possible some of the changes we'v

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

serge-sans-paille added a comment. @sgraenitz I currently have this patch applied to LLVM 8rc1 source tree for fedora, because it wasn't working automagically otherwise. Reading the discussion, I don't think I missed some configuration stuff, or what did I miss when configuring the build of lld

[Lldb-commits] [PATCH] D42870: Correct recognition of NetBSD images

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1359 + // p = patchlevel + const uint32_t version_major = version_info / 1; + const uint32_t version_minor = (version_info

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

labath created this revision. labath added reviewers: clayborg, jasonmolenda. Herald added a reviewer: alexshap. Herald added a subscriber: jdoerfert. This is a preparatory step to enable adding of unwind plans by symbol file plugins. Although at the surface it seems that currently symbol files h

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

sgraenitz added a comment. Yap, will try and come up with a proposal soon. @serge-sans-paille Sorry for diverging the discussion so much. Is it working for you now or are you still eager to get this patch in? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58193

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

labath added a comment. Ok, I see. Thanks for explaining that. I agree that it would be great if we could reduce the differences between an in-tree and a standalone build to a minimum. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58193/new/ https://reviews.l

[Lldb-commits] [PATCH] D58050: PECOFF: Implement GetBaseAddress

labath closed this revision. labath added a comment. Committed in r354258. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58050/new/ https://reviews.llvm.org/D58050 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [lldb] r354263 - minidump: Add ability to attach (breakpad) symbol files to placeholder modules

Author: labath Date: Mon Feb 18 03:55:01 2019 New Revision: 354263 URL: http://llvm.org/viewvc/llvm-project?rev=354263&view=rev Log: minidump: Add ability to attach (breakpad) symbol files to placeholder modules This re-commits r353677, which was reverted due to test failures on the windows bot.

[Lldb-commits] [lldb] r354258 - PECOFF: Implement GetBaseAddress

Author: labath Date: Mon Feb 18 03:06:57 2019 New Revision: 354258 URL: http://llvm.org/viewvc/llvm-project?rev=354258&view=rev Log: PECOFF: Implement GetBaseAddress COFF files are modelled in lldb as having one big container section spanning the entire module image, with the actual sections bein

[Lldb-commits] [PATCH] D58050: PECOFF: Implement GetBaseAddress

labath added a comment. Thank you. It looks like windows is green now, so I'll go ahead and commit this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58050/new/ https://reviews.llvm.org/D58050 ___ lldb-commits mai

[Lldb-commits] [PATCH] D58330: 01/03: new SectionPart for Section subranges (for effective .debug_types concatenation)

jankratochvil added a comment. In D58330#1400847 , @labath wrote: > Ok, I see what you mean. It's nice that we don't have this regression in the > base case. Though I guess we will still do the copying as soon as debug_types > sections appear. That is

[Lldb-commits] [PATCH] D58339: Changes for running LLDB test suite for Swift on PowerPC64LE

labath added a subscriber: davide. labath added a comment. I think so, but @davide (or someone else) can confirm that. In any case, it definitely shouldn't be here, as the llvm repo does not contain any of the swift code. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] r354256 - Return better error message from GDBRemoteCommunication::ConnectLocally

Author: labath Date: Mon Feb 18 02:36:23 2019 New Revision: 354256 URL: http://llvm.org/viewvc/llvm-project?rev=354256&view=rev Log: Return better error message from GDBRemoteCommunication::ConnectLocally Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Modif

[Lldb-commits] [PATCH] D58339: Changes for running LLDB test suite for Swift on PowerPC64LE

sarveshtamba added a comment. Hi @labath , Should I be submitting this patch request directly to "https://github.com/apple/swift-lldb";? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58339/new/ https://reviews.llvm.org/D58339 ___

Re: [Lldb-commits] [lldb] r354122 - [lldb] [MainLoop] Add kevent() EINTR handling

Merged to release_80 in r354255. On Fri, Feb 15, 2019 at 1:12 PM Michal Gorny via lldb-commits wrote: > > Author: mgorny > Date: Fri Feb 15 04:13:02 2019 > New Revision: 354122 > > URL: http://llvm.org/viewvc/llvm-project?rev=354122&view=rev > Log: > [lldb] [MainLoop] Add kevent() EINTR handling

Re: [Lldb-commits] [lldb] r354029 - [lldb] [MainLoop] Report errno for failed kevent()

Merged to release_80 in r354254. On Thu, Feb 14, 2019 at 2:51 PM Michal Gorny via lldb-commits wrote: > > Author: mgorny > Date: Thu Feb 14 05:52:31 2019 > New Revision: 354029 > > URL: http://llvm.org/viewvc/llvm-project?rev=354029&view=rev > Log: > [lldb] [MainLoop] Report errno for failed keve

Re: [Lldb-commits] [lldb] r353642 - lldb: Fix compilation on OpenBSD

Merged to release_80 in r354253. On Sun, Feb 10, 2019 at 4:23 PM Raphael Isemann via lldb-commits wrote: > > Author: teemperor > Date: Sun Feb 10 07:23:58 2019 > New Revision: 353642 > > URL: http://llvm.org/viewvc/llvm-project?rev=353642&view=rev > Log: > lldb: Fix compilation on OpenBSD > > Sum

[Lldb-commits] [PATCH] D58167: Refactor user/group name resolving code

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:439 if (uid != UINT32_MAX) { -std::string name; -if (HostInfo::LookupUserName(uid, name)) { +if (auto name =

[Lldb-commits] [PATCH] D58279: Set cmake policy CMP0075 to NEW

This revision was automatically updated to reflect the committed changes. Closed by commit rL354251: Set cmake policy CMP0075 to NEW (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https

[Lldb-commits] [lldb] r354251 - Set cmake policy CMP0075 to NEW

Author: labath Date: Mon Feb 18 02:09:29 2019 New Revision: 354251 URL: http://llvm.org/viewvc/llvm-project?rev=354251&view=rev Log: Set cmake policy CMP0075 to NEW Summary: The policy is about cmake_include_files ignoring CMAKE_REQUIRED_LIBRARIES in the OLD behavior. Llvm already sets this polic

[Lldb-commits] [PATCH] D58330: 01/03: new SectionPart for Section subranges (for effective .debug_types concatenation)

labath added a comment. In D58330#1400825 , @jankratochvil wrote: > In D58330#1400812 , @labath wrote: > > > It also appears that we will still end up mmapping the object file, and > > then copying all of the debu

[Lldb-commits] [PATCH] D58330: 01/03: new SectionPart for Section subranges (for effective .debug_types concatenation)

jankratochvil added a comment. In D58330#1400812 , @labath wrote: > It also appears that we will still end up mmapping the object file, and then > copying all of the debug info out of it into a heap buffer. In all usual cases at least on Linux LLDB shou