[Lldb-commits] [PATCH] D56221: [lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values

kubamracek closed this revision. kubamracek added a comment. Landed in r353363. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56221/new/ https://reviews.llvm.org/D56221 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] r353363 - [lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values

Author: kuba.brecka Date: Wed Feb 6 17:49:10 2019 New Revision: 353363 URL: http://llvm.org/viewvc/llvm-project?rev=353363&view=rev Log: [lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values Modified: lldb/trunk/include/lldb/Target/StackFrameRecognizer.h lldb

[Lldb-commits] [lldb] r353362 - [Driver] Don't try to replay reproducer in the driver.

Author: jdevlieghere Date: Wed Feb 6 17:49:07 2019 New Revision: 353362 URL: http://llvm.org/viewvc/llvm-project?rev=353362&view=rev Log: [Driver] Don't try to replay reproducer in the driver. Because the macros for the SBReproducers have not been committed yet, the driver should not attempt to

[Lldb-commits] [lldb] r353361 - Fix my mistake adding SBReproducer the Xcode project

Author: jdevlieghere Date: Wed Feb 6 17:42:47 2019 New Revision: 353361 URL: http://llvm.org/viewvc/llvm-project?rev=353361&view=rev Log: Fix my mistake adding SBReproducer the Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxp

[Lldb-commits] [PATCH] D57840: Convert TestCommandRegex to lit (from expect)

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM, thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57840/new/ https://reviews.llvm.org/D57840 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D57840: Convert TestCommandRegex to lit (from expect)

This revision was automatically updated to reflect the committed changes. Closed by commit rL353345: [testsuite] Convert a pexpect test to lit. (authored by davide, committed by ). Changed prior to commit: https://reviews.llvm.org/D57840?vs=185634&id=185635#toc Repository: rL LLVM CHANGES S

[Lldb-commits] [lldb] r353345 - [testsuite] Convert a pexpect test to lit.

Author: davide Date: Wed Feb 6 13:48:01 2019 New Revision: 353345 URL: http://llvm.org/viewvc/llvm-project?rev=353345&view=rev Log: [testsuite] Convert a pexpect test to lit. Summary: Reviewers: JDevlieghere, friss, zturner, labath, jingham, serge-sans-paille Subscribers: llvm-commits, lldb-co

[Lldb-commits] [PATCH] D57840: Convert TestCommandRegex to lit (from expect)

davide updated this revision to Diff 185634. davide added a comment. jonas was right Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57840/new/ https://reviews.llvm.org/D57840 Files: lldb/lit/Commands/command-regex-delete.test lldb/lit/Commands/command-regex-un

[Lldb-commits] [PATCH] D57840: Convert TestCommandRegex to lit (from expect)

davide updated this revision to Diff 185633. davide added a comment. zturner's update. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57840/new/ https://reviews.llvm.org/D57840 Files: lldb/packages/Python/lldbsuite/test/functionalities/command_regex/.categories

[Lldb-commits] [PATCH] D57840: Convert TestCommandRegex to lit (from expect)

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Can you rename these two tests to `command-regex-delete.test` and `command-regex-unalias.test`? Otherwise, lgtm Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D57840: [Py3/TestAppleOSSimulator] Another byte<->str interoperability issue.

davide updated this revision to Diff 185621. davide added a comment. update with the correct patch. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57840/new/ https://reviews.llvm.org/D57840 Files: lldb/lit/Commands/command-regex-2.test lldb/lit/Commands/comman

[Lldb-commits] [PATCH] D57840: [Py3/TestAppleOSSimulator] Another byte<->str interoperability issue.

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestAppleSimulatorOSType.py:18 sim_devices_str = subprocess.check_output(['xcrun', 'simctl', 'list', -

[Lldb-commits] [PATCH] D57840: [Py3/TestAppleOSSimulator] Another byte<->str interoperability issue.

davide created this revision. davide added reviewers: JDevlieghere, friss, zturner, labath, jingham. Herald added a reviewer: serge-sans-paille. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. [testsuite] Convert a pexpect test to lit. Repository: rL LLVM https://review

[Lldb-commits] [PATCH] D57402: build: remove custom variables

compnerd added a comment. @sgraenitz yeah, I passed `LLVM_DIR` and `Clang_DIR`, but, this is for a **standalone** build, so I think that it is pretty reasonable to ask that the user tell us where LLVM and Clang are built. Although, if you install LLVM and Clang to your root (like on Linux), yo

[Lldb-commits] [PATCH] D57830: Add functionality to trace a function within lldb

hiraditya created this revision. hiraditya added reviewers: xiaobai, clayborg. Herald added a reviewer: serge-sans-paille. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D57830 Files: examples/python/process_events.py Index: examples/python/process_events.py

[Lldb-commits] [lldb] r353326 - Add SBReproducer to Xcode project

Author: jdevlieghere Date: Wed Feb 6 11:05:43 2019 New Revision: 353326 URL: http://llvm.org/viewvc/llvm-project?rev=353326&view=rev Log: Add SBReproducer to Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://ll

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL353324: [Reproducers] SBReproducer framework: Capture & Replay (authored by JDevlieghere, committed by ). Herald added a p

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere added a comment. In D56322#1387357 , @labath wrote: > This looks good to me. Thank you for your patience. My pleasure, thank you for the thorough review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56322/new/ https://reviews.llv

[Lldb-commits] [lldb] r353324 - [Reproducers] SBReproducer framework: Capture & Replay

Author: jdevlieghere Date: Wed Feb 6 10:57:42 2019 New Revision: 353324 URL: http://llvm.org/viewvc/llvm-project?rev=353324&view=rev Log: [Reproducers] SBReproducer framework: Capture & Replay This is part two of the reproducer instrumentation framework. It contains the code to capture and repla

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

labath added a comment. This looks good to me. Thank you for your patience. Comment at: lldb/source/Utility/ReproducerInstrumentation.cpp:91 +Recorder::~Recorder() { + assert(m_result_recorded && "Did you forget SB_RECORD_RESULT?"); + UpdateBoundary(); old ma

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere updated this revision to Diff 185585. JDevlieghere marked 7 inline comments as done. JDevlieghere added a comment. Feedback Pavel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56322/new/ https://reviews.llvm.org/D56322 Files: lldb/include/lldb/API/SBReproducer.h lldb/

[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

labath updated this revision to Diff 185557. labath edited the summary of this revision. labath added a comment. Add a bounds check to the GetCompileUnitAtIndex method CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56595/new/ https://reviews.llvm.org/D56595 Files: include/lldb/Core/Fi

[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

clayborg added a comment. Just bounds check "index" in parse compile unit and this is good to go Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:196 + + CompUnitData &data = m_cu_data->GetEntryRef(index).data; + Validate "index" first? We

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

clayborg added a comment. Do we have any callers that call GetNumTemplateArguments with false? If not, remove the argument? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51387/new/ https://reviews.llvm.org/D51387 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D57817: Add PythonBoolean type to PythonDataObjects

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: zturner, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When reading some settings from a Python script, getting a boolean option via `StructuredData::Object::GetAsBoolean` fails unexpected

[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

labath updated this revision to Diff 185533. labath marked 2 inline comments as done. labath added a comment. Tried to make parsing as lazy as possible. GetNumSections() will count the number of FUNC records, but will not create CompileUnit objects. FILE records will be parsed when we create the f

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good to me, but let's wait for zachary too. In D57809#1386883 , @aleksandr.urakov wrote: > I've checked your solution, and it's worked for

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

aleksandr.urakov updated this revision to Diff 185526. aleksandr.urakov added a comment. I've checked your solution, and it's worked for me too! I think that your solution is better because it is more straight-forward. Here is the updated patch. Repository: rLLDB LLDB CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D57751: minidump: Add ability to attach (breakpad) symbol files to placeholder modules

labath added inline comments. Comment at: include/lldb/Core/Module.h:176-177 + +// Also update the module FileSpec. +module_sp->m_file = module_sp->m_objfile_sp->GetFileSpec(); +return std::move(module_sp); clayborg wrote: > Why do we need to update t

[Lldb-commits] [PATCH] D57751: minidump: Add ability to attach (breakpad) symbol files to placeholder modules

labath updated this revision to Diff 185513. labath marked 8 inline comments as done. labath added a comment. - remove std::move - avoid using the word "update" in CreateModuleFromObjectFile - implement the Dump method and cover it with a test CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D57402: build: remove custom variables

sgraenitz added a comment. In D57402#1385718 , @xiaobai wrote: > > - For us it's a good match for our downstream code > > https://github.com/apple/swift-lldb/blob/upstream-with-swift/cmake/modules/LLDBStandalone.cmake > > I don't think it's too difficult

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I don't think this should be necessary. Based on my experiments, the fact whether clang-cl defines `char32_t` depends on the version of visual studio it is emulating (`-fms-compatibi

Re: [Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

Yes, sure, here it is: https://reviews.llvm.org/D56904 On Tue, Feb 5, 2019 at 7:39 PM Zachary Turner wrote: > Yes, clang tries to find the visual studio installation, because that is > how it can find headers and libs. Can you make a separate patch with the > changes to build.py and upload that

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, labath, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: lldb-commits. On my system, `clang-cl` can't compile tests containing `char16_

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353281: [x64] Process the B field of the REX prefix correctly for the PUSH and POP (authored by aleksandr.urakov, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] r353281 - [x64] Process the B field of the REX prefix correctly for the PUSH and POP

Author: aleksandr.urakov Date: Wed Feb 6 00:48:30 2019 New Revision: 353281 URL: http://llvm.org/viewvc/llvm-project?rev=353281&view=rev Log: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions Summary: This patch makes `x86AssemblyInspectionEngine` to process

[Lldb-commits] [PATCH] D57780: Don't include UnixSignals.h from Host

labath added reviewers: jingham, davide. labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The rationale you give for this class being in Target is sound from the POV of lldb client. (the CreateForHost function is slightly fishy, but not too m

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. Thanks all for the review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57745/new/ https://reviews.llvm.org/D57745 ___ lldb-comm

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

aleksandr.urakov updated this revision to Diff 185497. aleksandr.urakov added a comment. Yes, sure, sorry about this, I occasionally have forgot to update the prefixes... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57745/new/ https://reviews.llvm.org/D57745

[Lldb-commits] [lldb] r353280 - Fix strlen() of unbound array undefined behavior

Author: jankratochvil Date: Wed Feb 6 00:44:13 2019 New Revision: 353280 URL: http://llvm.org/viewvc/llvm-project?rev=353280&view=rev Log: Fix strlen() of unbound array undefined behavior LLDB testsuite fails when built by GCC8 on: LLDB :: SymbolFile/DWARF/find-basic-namespace.cpp This is bec

[Lldb-commits] [PATCH] D57781: Fix strlen() of unbound array undefined behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rL353280: Fix strlen() of unbound array undefined behavior (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

labath added a comment. I think we're very close. This batch of comments is just about small improvements to the tests. It looks like the `Validate` thingy wasn't such a clever idea, since the fact that the framework creates extra copies means that there are some unvalidated copies floating aro