[Lldb-commits] [PATCH] D56237: Implement GetFileLoadAddress for the Windows process plugin

2019-01-27 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I think there are some architectural issues here in how ProcessWindows works. Normally (i.e., on all non-windows process classes), it is the job of the dynamic loader plugin to create modules and set their load addresses. However, ProcessWindows does things differently,

[Lldb-commits] [PATCH] D56196: ProcessLaunchInfo: Remove Target reference

2019-01-27 Thread Pavel Labath via Phabricator via lldb-commits
labath marked an inline comment as done. labath added inline comments. Comment at: lldb/trunk/source/Target/ProcessLaunchInfo.cpp:220 + if (!m_pty->OpenFirstAvailableMaster(open_flags, nullptr, 0)) { +return llvm::createStringError(llvm::inconvertibleErrorCode(), +

[Lldb-commits] [PATCH] D56221: [lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values

2019-01-27 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek added a comment. Herald added a reviewer: serge-sans-paille. Ping. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56221/new/ https://reviews.llvm.org/D56221 ___ lldb-commits mailing list lldb-commits@list