Re: [Lldb-commits] [PATCH] D57275: [testsuite] Remove seven dependency

2019-01-26 Thread Zachary Turner via lldb-commits
Huh, that’s a coincidence. I chose the name because it was “like six”, but I guess someone else chose it for the same reason On Sat, Jan 26, 2019 at 2:18 PM Jonas Devlieghere wrote: > > > On Fri, Jan 25, 2019 at 8:44 PM Zachary Turner via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >>

Re: [Lldb-commits] [PATCH] D57275: [testsuite] Remove seven dependency

2019-01-26 Thread Jonas Devlieghere via lldb-commits
On Fri, Jan 25, 2019 at 8:44 PM Zachary Turner via lldb-commits < lldb-commits@lists.llvm.org> wrote: > The idea behind seven is that it’s a place to put stuff that we need for > py2/py3 interoperability that doesn’t already exist in six. Yes, maybe > there’s only one thing there now, but there co

[Lldb-commits] [PATCH] D57272: Remove unimplemented function

2019-01-26 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57272/new/ https://reviews.llvm.org/D57272 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D57275: [testsuite] Remove seven dependency

2019-01-26 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. I don't have a strong preference between using a separate module for interopability between python versions and implementing the functions as part of dotest if there are few of them, but I have to agree with @zturner that if we have more than a couple of functi

[Lldb-commits] [PATCH] D57282: [cmake] Fix get_llvm_lit_path() to respect LLVM_EXTERNAL_LIT always

2019-01-26 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: EricWF, sgraenitz, zturner. Herald added a subscriber: christof. Refactor the get_llvm_lit_path() logic to respect LLVM_EXTERNAL_LIT, and require the fallback to be defined explicitly as LLVM_DEFAULT_EXTERNAL_LIT. This fixes building libcxx st