The idea behind seven is that it’s a place to put stuff that we need for
py2/py3 interoperability that doesn’t already exist in six. Yes, maybe
there’s only one thing there now, but there could be more over time.
At least that was the thinking when I created it.
It seems like there’s two separate
JDevlieghere created this revision.
JDevlieghere added reviewers: davide, zturner, stella.stamenova, labath.
JDevlieghere added a project: LLDB.
Herald added a reviewer: serge-sans-paille.
When running the test suite on macOS with Python 3 we noticed a difference in
behavior between Python 2 and
aprantl created this revision.
aprantl added reviewers: jingham, labath.
This is a continuation of my quest to make the size 0 a supported value.
https://reviews.llvm.org/D57273
Files:
include/lldb/Symbol/Type.h
source/Core/ValueObjectMemory.cpp
source/Expression/Materializer.cpp
source
aprantl created this revision.
aprantl added reviewers: jasonmolenda, jingham.
Looks like this was an unintended sideeffect of r124250.
https://reviews.llvm.org/D57272
Files:
source/Symbol/Type.cpp
Index: source/Symbol/Type.cpp
===
Author: jdevlieghere
Date: Fri Jan 25 17:05:02 2019
New Revision: 352259
URL: http://llvm.org/viewvc/llvm-project?rev=352259&view=rev
Log:
[lldb] Update shebang python2 -> python
Modified:
lldb/trunk/lit/Quit/expect_exit_code.py
Modified: lldb/trunk/lit/Quit/expect_exit_code.py
URL:
http://
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
I don't have other comments, this is good to go for me. Pavel?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54617/new/
https://reviews.llvm.org/D54617
JDevlieghere added inline comments.
Comment at: source/Utility/FileCollector.cpp:27-33
+ // Change path to all upper case and ask for its real path, if the latter
+ // exists and is equal to path, it's not case sensitive. Default to case
+ // sensitive in the absence of real_p
JDevlieghere updated this revision to Diff 183641.
JDevlieghere marked 9 inline comments as done.
JDevlieghere added a comment.
Code review feedback Davide.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54617/new/
https://reviews.llvm.org/D54617
Files:
include/lldb/Host/FileSystem.h
davide added a comment.
Some comments. Thanks!
Comment at: include/lldb/Utility/FileCollector.h:5-7
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
You might want to update the license.
=
JDevlieghere updated this revision to Diff 183631.
JDevlieghere added a comment.
- Fix issue in lit test.
- Add unit test for the file collector.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54617/new/
https://reviews.llvm.org/D54617
Files:
include/lldb/Host/FileSystem.h
include/l
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB352249: Simplify LangOpts initalization in
ClangExpressionParser [NFC] (authored by teemperor, committed by ).
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57222/new/
Author: teemperor
Date: Fri Jan 25 14:41:31 2019
New Revision: 352249
URL: http://llvm.org/viewvc/llvm-project?rev=352249&view=rev
Log:
Simplify LangOpts initalization in ClangExpressionParser [NFC]
Reviewers: davide
Reviewed By: davide
Subscribers: shafik, davide, lldb-commits
Differential Re
shafik added a comment.
Nice improvement in readability!
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57222/new/
https://reviews.llvm.org/D57222
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
davide marked 2 inline comments as done.
davide added inline comments.
Comment at: lldb/source/Utility/RegisterValue.cpp:159
case 32:
+case 64:
if (buffer.length % sizeof(uint64_t) == 0) {
aprantl wrote:
> I'm curious, everything else in this patc
aprantl added inline comments.
Comment at: lldb/source/Utility/RegisterValue.cpp:159
case 32:
+case 64:
if (buffer.length % sizeof(uint64_t) == 0) {
I'm curious, everything else in this patch refers to 512, how does this fit in?
This revision was automatically updated to reflect the committed changes.
Closed by commit rL352235: [CMake] Use llvm-tblgen from NATIVE LLVM build when
cross-compiling (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
Author: xiaobai
Date: Fri Jan 25 11:38:21 2019
New Revision: 352235
URL: http://llvm.org/viewvc/llvm-project?rev=352235&view=rev
Log:
[CMake] Use llvm-tblgen from NATIVE LLVM build when cross-compiling
Summary:
When cross-compiling LLDB, we want to use llvm-tblgen built for the
host, not the targ
xiaobai updated this revision to Diff 183585.
xiaobai added a comment.
Added a comment
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57194/new/
https://reviews.llvm.org/D57194
Files:
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/LLDBStandalone.cmake
==
JDevlieghere updated this revision to Diff 183584.
JDevlieghere retitled this revision from "[WIP] Tool to insert SBReproducer
macros" to "[Reproducers] Tool to insert SBReproducer macros".
JDevlieghere added a comment.
Fixed printing of booleans; the tool would show `_Bool` instead of `bool`.
I
Nice!
On Thu, Jan 24, 2019 at 7:01 PM Jason Molenda via lldb-commits
wrote:
>
> Author: jmolenda
> Date: Thu Jan 24 19:01:48 2019
> New Revision: 352158
>
> URL: http://llvm.org/viewvc/llvm-project?rev=352158&view=rev
> Log:
> Remove a warning in DynamicLoaderDarwin::UpdateImageLoadAddress
> when
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57222/new/
https://reviews.llvm.org/D57222
___
lldb-commit
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: cmake/modules/LLDBStandalone.cmake:44
+else()
+ set(LLVM_TABLEGEN_EXE
+
"${LLVM_NATIVE_BUILD}/Release/bin/llvm-tblgen${HOST_EXECUTABLE_SU
Author: tkrasnukha
Date: Fri Jan 25 10:27:09 2019
New Revision: 352226
URL: http://llvm.org/viewvc/llvm-project?rev=352226&view=rev
Log:
ResolveBreakpointSite: fix outdated warning message
Currently if a breakpoint site is already present, its ID will be returned, not
the LLDB_INVALID_BREAK_ID.
mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
WFM. A number of tests fail but that's entirely normal at this point and we
basically stopped caring.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57233/new/
https://reviews.llvm.or
sgraenitz created this revision.
sgraenitz added a reviewer: mgorny.
The issue came up during release testing for LLVM 8:
https://bugs.llvm.org/show_bug.cgi?id=40443
https://reviews.llvm.org/D57233
Files:
cmake/modules/AddLLDB.cmake
lit/CMakeLists.txt
Index: lit/CMakeLists.txt
==
teemperor created this revision.
Herald added a subscriber: lldb-commits.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D57222
Files:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Author: teemperor
Date: Fri Jan 25 01:28:48 2019
New Revision: 352180
URL: http://llvm.org/viewvc/llvm-project?rev=352180&view=rev
Log:
Fix typo in ClangModulesDeclVendor [NFC]
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.h
Modified:
lldb/trunk/source/Pl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL352175: Refactor HAVE_LIBCOMPRESSION and related code in
GDBRemoteCommunication (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
Author: teemperor
Date: Fri Jan 25 00:21:47 2019
New Revision: 352175
URL: http://llvm.org/viewvc/llvm-project?rev=352175&view=rev
Log:
Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication
Summary:
The field `m_decompression_scratch_type` is only used when
`HAVE_LIBCOMPRESSION
29 matches
Mail list logo
