[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

2019-01-12 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D56230#1355247 , @labath wrote: > For example, for a `Args` vector like `lldb-server`, `gdb-remote`, > `--log-channels=foo\\\ \\\""" '''`, `whatever`, `QuoteForCreateProcess` > would return > `lldb-server gdb-remote "--log

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

2019-01-12 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D56230#1354851 , @zturner wrote: > I almost feel like the `Args` class could be made smarter here. Because all > of the proposed solutions will still not work correctly on Linux. For > example, why is this Windows specific?

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

2019-01-12 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D56230#1354829 , @Hui wrote: > I think the key problem here is to make sure the argument will be treated as > a single argument to the process launcher. Can you elaborate on that? I still don't see what is the problem with the