Re: [Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

2018-12-29 Thread Aleksandr Urakov via lldb-commits
Yes, right! There's x64 fastcall for everything. Ok, I'll remove it later, thanks! Am So., 30. Dez. 2018, 09:26 hat Zachary Turner geschrieben: > Sorry, this comment was supposed to be deleted after I realized i was > wrong. > > On Sat, Dec 29, 2018 at 9:12 PM Aleksandr Urakov via Phabricator <

Re: [Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

2018-12-29 Thread Zachary Turner via lldb-commits
Sorry, this comment was supposed to be deleted after I realized i was wrong. On Sat, Dec 29, 2018 at 9:12 PM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.urakov marked an inline comment as done. > aleksandr.urakov added inline comments. > > > >

[Lldb-commits] [lldb] r350160 - [test] Remove flakiness decorator from TestObjCDynamicSBType

2018-12-29 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Sat Dec 29 22:10:03 2018 New Revision: 350160 URL: http://llvm.org/viewvc/llvm-project?rev=350160&view=rev Log: [test] Remove flakiness decorator from TestObjCDynamicSBType The quoted bug report (llvm.org/PR20270) was closed in 2014. Modified: lldb/trunk/packages/

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

2018-12-29 Thread Aleksandr Urakov via Phabricator via lldb-commits
aleksandr.urakov marked an inline comment as done. aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/NativePDB/ast-methods.cpp:28 +// CHECK: |-CXXRecordDecl {{.*}} struct Struct definition +// CHECK: | |-CXXMethodDecl {{.*}} simple_method 'void () __attribute__(

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

2018-12-29 Thread Zachary Turner via Phabricator via lldb-commits
zturner added inline comments. Comment at: lit/SymbolFile/NativePDB/ast-methods.cpp:28 +// CHECK: |-CXXRecordDecl {{.*}} struct Struct definition +// CHECK: | |-CXXMethodDecl {{.*}} simple_method 'void () __attribute__((thiscall))' +// CHECK: | |-CXXMethodDecl {{.*}} virtual_met

[Lldb-commits] [PATCH] D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`

2018-12-29 Thread Aleksandr Urakov via Phabricator via lldb-commits
aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, JDevlieghere, clayborg, labath. aleksandr.urakov added a project: LLDB. Herald added a subscriber: lldb-commits. This patch allows to retrieve an address object for `ValueObject`'s children retrieved through e.g. `

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

2018-12-29 Thread Aleksandr Urakov via Phabricator via lldb-commits
aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. In D56126#1342114 , @zturner wrote: > I think it's probably best to skip this part for now and come back to it > later. The only thing that will be missing is the abilit