[Lldb-commits] [PATCH] D56115: [lldb] Check SafeToCallFunctions before calling functions in GetExceptionObjectForThread

kubamracek created this revision. kubamracek added a reviewer: jingham. kubamracek added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D56115 Files: source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp Index: source/Plugins/LanguageRuntime/

[Lldb-commits] [PATCH] D55998: ELF: create "container" sections from PT_LOAD segments

labath added a comment. In D55998#1341263 , @joerg wrote: > I foundamentally don't understand what you are trying to do. This is stemming from a discussion on a different patch. If you're interested in the full background you can look it up here https:

[Lldb-commits] [PATCH] D55998: ELF: create "container" sections from PT_LOAD segments

joerg added a comment. I foundamentally don't understand what you are trying to do. You can either look at the executable from a segment perspective or from a section perspective. But trying to mix the views is bound to give bogus results. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] r350093 - Fix tests for python 3.7

Author: labath Date: Thu Dec 27 07:16:37 2018 New Revision: 350093 URL: http://llvm.org/viewvc/llvm-project?rev=350093&view=rev Log: Fix tests for python 3.7 python 3.7 removes re._pattern_type. Fix the one place where we were depending on the type of regular expressions to compute the type dynam

[Lldb-commits] [lldb] r350094 - Reduce indentation in ObjectFilePECOFF::CreateSections via an early return

Author: labath Date: Thu Dec 27 07:16:44 2018 New Revision: 350094 URL: http://llvm.org/viewvc/llvm-project?rev=350094&view=rev Log: Reduce indentation in ObjectFilePECOFF::CreateSections via an early return Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp Modified:

[Lldb-commits] [lldb] r350091 - Fix assertion failure in NativeProcessProtocolTest

Author: labath Date: Thu Dec 27 05:45:55 2018 New Revision: 350091 URL: http://llvm.org/viewvc/llvm-project?rev=350091&view=rev Log: Fix assertion failure in NativeProcessProtocolTest The assertion fired (with a debug visual studio STL) because we tried to dereference the end of a vector (althoug

[Lldb-commits] [PATCH] D55761: lldb-test ir-memory-map: Use IntervalMap::contains

shagitoramsil reopened this revision. shagitoramsil added a comment. This revision is now accepted and ready to land. I don't no why people still protects like google Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55761/new/ https://reviews.llvm.org/D55761 _

[Lldb-commits] [PATCH] D55998: ELF: create "container" sections from PT_LOAD segments

labath updated this revision to Diff 179541. labath marked 4 inline comments as done. labath added a comment. Address review comments: - move SegmentID() to the cpp file - use lldb_private::Range (not lldb_utility::Range) for segment and sections ranges - use brackets in segment names (PT_LOAD[0

[Lldb-commits] [lldb] r350088 - Delete lldb_utility::Range

Author: labath Date: Thu Dec 27 01:44:27 2018 New Revision: 350088 URL: http://llvm.org/viewvc/llvm-project?rev=350088&view=rev Log: Delete lldb_utility::Range This class is unused, and there is already a lldb_private::Range (defined in lldb/Core/RangeMap.h), which has similar functionality. Rem

[Lldb-commits] [lldb] r350089 - Fix "default argument for lambda parameter" (-Wpedantic) warning

Author: labath Date: Thu Dec 27 01:44:32 2018 New Revision: 350089 URL: http://llvm.org/viewvc/llvm-project?rev=350089&view=rev Log: Fix "default argument for lambda parameter" (-Wpedantic) warning Modified: lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp Modified: lldb/trunk/

[Lldb-commits] [PATCH] D55761: lldb-test ir-memory-map: Use IntervalMap::contains

This revision was automatically updated to reflect the committed changes. Closed by commit rL350087: lldb-test ir-memory-map: Use IntervalMap::contains (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55761?vs=17844

[Lldb-commits] [lldb] r350087 - lldb-test ir-memory-map: Use IntervalMap::contains

Author: labath Date: Thu Dec 27 01:32:04 2018 New Revision: 350087 URL: http://llvm.org/viewvc/llvm-project?rev=350087&view=rev Log: lldb-test ir-memory-map: Use IntervalMap::contains Summary: Simplify the code by using the contains implementation in IntervalMap. There is a slight change of beha

[Lldb-commits] [PATCH] D55991: DWARF: Fix a bug in array size computation

This revision was automatically updated to reflect the committed changes. Closed by commit rL350086: DWARF: Fix a bug in array size computation (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55991?vs=179254&id=179

[Lldb-commits] [lldb] r350086 - DWARF: Fix a bug in array size computation

Author: labath Date: Thu Dec 27 01:25:34 2018 New Revision: 350086 URL: http://llvm.org/viewvc/llvm-project?rev=350086&view=rev Log: DWARF: Fix a bug in array size computation Summary: r346165 introduced a bug, where we would fail to parse the size of an array if that size happened to match an ex

[Lldb-commits] [PATCH] D55998: ELF: create "container" sections from PT_LOAD segments

labath added a comment. In D55998#1340711 , @joerg wrote: > In D55998#1340448 , @jankratochvil > wrote: > > > ELF standard : "//An object file > > segment contains one or

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar updated this revision to Diff 179535. grimar edited the summary of this revision. grimar added a comment. - Addressed review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 Files: include/lldb/lldb-defines.h source/Commands/C

[Lldb-commits] [PATCH] D56010: [NativePDB] Fix setting breakpoint by file and line

labath accepted this revision. labath added inline comments. Comment at: lldb/lit/SymbolFile/NativePDB/break-by-line.cpp:9-10 + +// This is a separate test from break-by-function.cpp because this test is +// sensitive to edits in the source file. + You could cons

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

labath added a comment. I guess it should be possible to trigger this from dotest tests via pexpect. I know we try to avoid it, but given that this is specifically testing terminal interaction, using it here seems appropriate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56014/new/ h