[Lldb-commits] [lldb] r349977 - [cmake] Suppress 'warning C4201: nonstandard extension used: nameless struct/union' on Windows

Author: stella.stamenova Date: Fri Dec 21 15:59:24 2018 New Revision: 349977 URL: http://llvm.org/viewvc/llvm-project?rev=349977&view=rev Log: [cmake] Suppress 'warning C4201: nonstandard extension used: nameless struct/union' on Windows This warning comes up in the ObjC language plugin because

[Lldb-commits] [lldb] r349972 - [NFC] Replace `compare` with (in)equality operator where applicable.

Author: jdevlieghere Date: Fri Dec 21 14:46:10 2018 New Revision: 349972 URL: http://llvm.org/viewvc/llvm-project?rev=349972&view=rev Log: [NFC] Replace `compare` with (in)equality operator where applicable. Using compare is verbose, bug prone and potentially inefficient (because of early termina

[Lldb-commits] [lldb] r349971 - [Scalar] Simplify as Jonas suggested. NFCI.

Author: davide Date: Fri Dec 21 14:45:07 2018 New Revision: 349971 URL: http://llvm.org/viewvc/llvm-project?rev=349971&view=rev Log: [Scalar] Simplify as Jonas suggested. NFCI. Modified: lldb/trunk/unittests/Utility/ScalarTest.cpp Modified: lldb/trunk/unittests/Utility/ScalarTest.cpp URL: h

[Lldb-commits] [lldb] r349970 - [Scalar] Implement operator!= using operator==.

Author: davide Date: Fri Dec 21 14:42:00 2018 New Revision: 349970 URL: http://llvm.org/viewvc/llvm-project?rev=349970&view=rev Log: [Scalar] Implement operator!= using operator==. Summary: Adding some test coverage while I'm around. Reviewers: JDevlieghere, aprantl, zturner, clayborg, jingham

[Lldb-commits] [PATCH] D56027: [lldb] Fix ObjCExceptionRecognizedStackFrame to populate the list of recognized arguments

kubamracek created this revision. kubamracek added a reviewer: jingham. kubamracek added a project: LLDB. Looks like ObjCExceptionRecognizedStackFrame is only vending the recognized exception via GetExceptionObject. It should also present it just as a regular recognized argument, i.e. populate t

[Lldb-commits] [lldb] r349967 - [ExpressionParser] Reserve size before copying over args

Author: jdevlieghere Date: Fri Dec 21 14:16:10 2018 New Revision: 349967 URL: http://llvm.org/viewvc/llvm-project?rev=349967&view=rev Log: [ExpressionParser] Reserve size before copying over args We already know the final size here so we might as well reserve it so we don't have to re-allocate du

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: source/Core/ModuleList.cpp:72 {}, "Control the use of external tools or libraries to locate symbol files. " + "Directories listed in target.debug-file-search-paths and

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil updated this revision to Diff 179349. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55859/new/ https://reviews.llvm.org/D55859 Files: packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py packages/Python/lldbsuite/test/tools/lldb-mi/

[Lldb-commits] [lldb] r349946 - [lldbsuite] Skip flakey Windows tests

Author: stella.stamenova Date: Fri Dec 21 12:10:45 2018 New Revision: 349946 URL: http://llvm.org/viewvc/llvm-project?rev=349946&view=rev Log: [lldbsuite] Skip flakey Windows tests Skip a number of tests on Windows that are flakey and will pass/fail unexpectedly every dozen or so runs. Modified

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

davide added a comment. testcase? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56014/new/ https://reviews.llvm.org/D56014 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

jingham added a comment. The only reservation I have is that this really ought to work correctly for ObjC as well as C++, and there's code to support that, but it isn't tested. I don't have time to write ObjC tests before the new year for sure. Is it possible to rope somebody else into that?

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

grimar created this revision. grimar added reviewers: LLDB, clayborg. This is https://bugs.llvm.org/show_bug.cgi?id=40112, Currently, lldb crashes after pressing the up arrow key when listing the history for expressions. The patch fixes the mistype that was a reason. https://reviews.llvm.org/

[Lldb-commits] [PATCH] D56010: [NativePDB] Fix setting breakpoint by file and line

clayborg added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56010/new/ https://reviews.llvm.org/D56010 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55991: DWARF: Fix a bug in array size computation

labath added a comment. Hm.. I can't say I have given much thought about this beforehand, as I just copied this code from llvm. However, now that I did think about it, I believe the current implementation makes sense. Nothing about DWARFFormValue::Reference (well, except the local variable name

[Lldb-commits] [PATCH] D56010: [NativePDB] Fix setting breakpoint by file and line

zturner created this revision. zturner added reviewers: aleksandr.urakov, lemo, labath, amccarth. Herald added a subscriber: arphaman. There were several problems preventing this from working. The first is that when the PDB had an absolute path to the main source file, we would construct an

[Lldb-commits] [lldb] r349926 - Don't duplicate the logic that detects if a section can/should be loaded (NFC)

Author: gclayton Date: Fri Dec 21 09:04:18 2018 New Revision: 349926 URL: http://llvm.org/viewvc/llvm-project?rev=349926&view=rev Log: Don't duplicate the logic that detects if a section can/should be loaded (NFC) Prior to this there were 3 places that were duplicating the logic to detect if a s

[Lldb-commits] [PATCH] D55991: DWARF: Fix a bug in array size computation

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp:619 + case DW_FORM_ref_addr: + case DW_FORM_ref_sig8: + case DW_FORM_GNU_ref_alt:

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. The changes from "constexpr" to "const" might introduce global constructors in the shared library which is what we were trying to avoid. The less work that the LLDB shared librar

[Lldb-commits] [PATCH] D55998: ELF: create "container" sections from PT_LOAD segments

clayborg added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1841-1844 +struct SegmentAddressInfo { + addr_t Address; + addr_t Size; +}; Use existing range code from Range.h? ``` #include "lldb/Utility/Range.h" typedef Range Segme

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

labath added a comment. Some interesting ideas here. I like some of them, but I have reservations about others. I'm going to go through them one by one. In D55142#1333077 , @zturner wrote: > I thought about what my "ideal" design would look like. I'm no

[Lldb-commits] [PATCH] D55998: ELF: create "container" sections from PT_LOAD segments

labath created this revision. labath added reviewers: clayborg, jankratochvil, krytarowski, joerg. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. This is the result of the discussion in D55356 , where it was suggested as a solut

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar created this revision. grimar added reviewers: clayborg, LLDB. Currently, lldb fails to build with the following errors when MSVS update 3 is used: > fatal error C1001: An internal error has occurred in the compiler. > (compiler file 'msc1.cpp', line 1468) > To work around this problem,

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov added a comment. Ping! What do you think about this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: source/Core/ModuleList.cpp:72 {}, "Control the use of external tools or libraries to locate symbol files. " + "Directories listed in target.de

[Lldb-commits] [PATCH] D55991: DWARF: Fix a bug in array size computation

labath created this revision. labath added reviewers: aprantl, clayborg. Herald added a subscriber: JDevlieghere. r346165 introduced a bug, where we would fail to parse the size of an array if that size happened to match an existing die offset. The logic was: if (DWARFDIE count = die.GetReference