[Lldb-commits] [lldb] r349874 - "help finish" tells you it is an alias. "help fin" doesn't.

Author: jingham Date: Thu Dec 20 17:45:28 2018 New Revision: 349874 URL: http://llvm.org/viewvc/llvm-project?rev=349874&view=rev Log: "help finish" tells you it is an alias. "help fin" doesn't. They both run the same command, and people get used to typing the shortest string they can, so we shou

[Lldb-commits] [lldb] r349869 - Fix stack-buffer-overflow in lldb_private::Host::FindProcesses (2/2)

Author: jdevlieghere Date: Thu Dec 20 17:22:58 2018 New Revision: 349869 URL: http://llvm.org/viewvc/llvm-project?rev=349869&view=rev Log: Fix stack-buffer-overflow in lldb_private::Host::FindProcesses (2/2) This fixes the second call at line 640 that I missed in r349858. Modified: lldb/trun

[Lldb-commits] [lldb] r349865 - Add an assertion to aid in tracking down a bug

Author: adrian Date: Thu Dec 20 17:09:15 2018 New Revision: 349865 URL: http://llvm.org/viewvc/llvm-project?rev=349865&view=rev Log: Add an assertion to aid in tracking down a bug Modified: lldb/trunk/source/Target/Thread.cpp Modified: lldb/trunk/source/Target/Thread.cpp URL: http://llvm.or

[Lldb-commits] [lldb] r349864 - Remove ineffective (misspelled) sanitizer option

Author: adrian Date: Thu Dec 20 17:09:14 2018 New Revision: 349864 URL: http://llvm.org/viewvc/llvm-project?rev=349864&view=rev Log: Remove ineffective (misspelled) sanitizer option Modified: lldb/trunk/lit/Suite/lit.cfg Modified: lldb/trunk/lit/Suite/lit.cfg URL: http://llvm.org/viewvc/llv

[Lldb-commits] [lldb] r349861 - Fix typo

Author: adrian Date: Thu Dec 20 15:50:32 2018 New Revision: 349861 URL: http://llvm.org/viewvc/llvm-project?rev=349861&view=rev Log: Fix typo Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py URL: http://llvm.

[Lldb-commits] [lldb] r349858 - Fix stack-buffer-overflow in lldb_private::Host::FindProcesses

Author: jdevlieghere Date: Thu Dec 20 15:45:26 2018 New Revision: 349858 URL: http://llvm.org/viewvc/llvm-project?rev=349858&view=rev Log: Fix stack-buffer-overflow in lldb_private::Host::FindProcesses Found by the address sanitizer on GreenDragon: http://green.lab.llvm.org/green/view/LLDB/job/ll

[Lldb-commits] [PATCH] D55954: [lldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB349856: [lldb] Add a "display-recognized-arguments" target setting to show recognized… (authored by kuba.brecka, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] r349856 - [lldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default

Author: kuba.brecka Date: Thu Dec 20 15:38:19 2018 New Revision: 349856 URL: http://llvm.org/viewvc/llvm-project?rev=349856&view=rev Log: [lldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default Differential Revision: https://reviews.llvm.org/D55954 Mo

[Lldb-commits] [PATCH] D55954: [lldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Excellent! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55954/new/ https://reviews.llvm.org/D55954 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] r349854 - [NativePDB] Create VarDecls for global variables.

Author: zturner Date: Thu Dec 20 15:32:37 2018 New Revision: 349854 URL: http://llvm.org/viewvc/llvm-project?rev=349854&view=rev Log: [NativePDB] Create VarDecls for global variables. Previously we would create these for local variables but not for global variables. Also updated existing tests w

[Lldb-commits] [lldb] r349851 - Disable a few tests on the green dragon sanitzier bot.

Author: adrian Date: Thu Dec 20 15:16:47 2018 New Revision: 349851 URL: http://llvm.org/viewvc/llvm-project?rev=349851&view=rev Log: Disable a few tests on the green dragon sanitzier bot. These are tests that found actual, but hard to fix, bugs that are tracked elsewhere. Leaving them red only di

[Lldb-commits] [PATCH] D55954: [lldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default

kubamracek updated this revision to Diff 179170. kubamracek retitled this revision from "[ldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default" to "[lldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default". kub

[Lldb-commits] [PATCH] D55954: [ldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default

jingham added a comment. That's great. Can you add a test that if you make a default SBVariableOption and then flip the target setting you get the target's default value? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55954/new/ https://reviews.llvm.org/D55954

[Lldb-commits] [PATCH] D55954: [ldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default

kubamracek created this revision. kubamracek added a reviewer: jingham. kubamracek added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D55954 Files: include/lldb/API/SBTarget.h include/lldb/API/SBVariablesOptions.h include/lldb/Target/Target.h scripts/interface/SBVar

[Lldb-commits] [lldb] r349821 - [API] Remove redundants get() from smart pointers. NFC

Author: jdevlieghere Date: Thu Dec 20 13:02:55 2018 New Revision: 349821 URL: http://llvm.org/viewvc/llvm-project?rev=349821&view=rev Log: [API] Remove redundants get() from smart pointers. NFC Removes redundant calls to ::get() from smart pointers in the source/API directory.. Modified: lld

[Lldb-commits] [lldb] r349818 - [dotest] Consider unexpected passes as failures.

Author: jdevlieghere Date: Thu Dec 20 12:44:23 2018 New Revision: 349818 URL: http://llvm.org/viewvc/llvm-project?rev=349818&view=rev Log: [dotest] Consider unexpected passes as failures. Unexpected successes should be considered failures because they can hide regressions when not addressed. When

[Lldb-commits] [PATCH] D55835: [dotest] Consider unexpected passes as failures.

This revision was automatically updated to reflect the committed changes. Closed by commit rL349818: [dotest] Consider unexpected passes as failures. (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55835?vs=1

[Lldb-commits] [lldb] r349813 - [lldbsuite] Un-xfail several tests in TestInferiorCrashing on Windows

Author: stella.stamenova Date: Thu Dec 20 12:26:05 2018 New Revision: 349813 URL: http://llvm.org/viewvc/llvm-project?rev=349813&view=rev Log: [lldbsuite] Un-xfail several tests in TestInferiorCrashing on Windows Several of the tests are now passing. This change is enabling them. Modified:

[Lldb-commits] [PATCH] D55835: [dotest] Consider unexpected passes as failures.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good to me. Modifying this code is not ideal, but this is a pretty small but fundamental change in how unittest works. Changing the treatment of unexpected successes anywhere else would

[Lldb-commits] [lldb] r349784 - [lit] Skip stop-hook test on Windows

Author: stella.stamenova Date: Thu Dec 20 10:23:08 2018 New Revision: 349784 URL: http://llvm.org/viewvc/llvm-project?rev=349784&view=rev Log: [lit] Skip stop-hook test on Windows This test is now marked as unsupported on Windows - it is not technically "unsupported" on Windows, but it fails be

[Lldb-commits] [lldb] r349783 - [lldbsuite] Un-xfail TestMiniDump and TestThreadJump

Author: stella.stamenova Date: Thu Dec 20 10:21:17 2018 New Revision: 349783 URL: http://llvm.org/viewvc/llvm-project?rev=349783&view=rev Log: [lldbsuite] Un-xfail TestMiniDump and TestThreadJump Both of these are now passing. I've resolved the bugs as well for verification. Modified: lldb/

[Lldb-commits] [lldb] r349781 - [lldbsuite] Un-xfail TestEvents on Windows

Author: stella.stamenova Date: Thu Dec 20 10:00:20 2018 New Revision: 349781 URL: http://llvm.org/viewvc/llvm-project?rev=349781&view=rev Log: [lldbsuite] Un-xfail TestEvents on Windows There are a couple of tests in TestEvents that are now passing. Modified: lldb/trunk/packages/Python/lldbs

[Lldb-commits] [lldb] r349775 - [lldbsuite] Skip TestConflictingSymbol (test_shadowed) on Windows

Author: stella.stamenova Date: Thu Dec 20 09:19:56 2018 New Revision: 349775 URL: http://llvm.org/viewvc/llvm-project?rev=349775&view=rev Log: [lldbsuite] Skip TestConflictingSymbol (test_shadowed) on Windows The test is "passing" on windows, but it is a false positive. Skip it on Windows until

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

This revision was automatically updated to reflect the committed changes. Closed by commit rL349767: Overload GetMemoryRegions for the ProcessMinidump (authored by tkrasnukha, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55841?vs=17

[Lldb-commits] [lldb] r349767 - Overload GetMemoryRegions for the ProcessMinidump

Author: tkrasnukha Date: Thu Dec 20 07:05:43 2018 New Revision: 349767 URL: http://llvm.org/viewvc/llvm-project?rev=349767&view=rev Log: Overload GetMemoryRegions for the ProcessMinidump Differential Revision: https://reviews.llvm.org/D55841 Modified: lldb/trunk/packages/Python/lldbsuite/te

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB349766: Replace MemoryRegionInfoSP with values and cleanup related code (authored by tkrasnukha, committed by ). Changed prior to commit: https://reviews.llvm.org/D55472?vs=178941&id=179072#toc Repo

[Lldb-commits] [lldb] r349766 - Replace MemoryRegionInfoSP with values and cleanup related code

Author: tkrasnukha Date: Thu Dec 20 07:02:58 2018 New Revision: 349766 URL: http://llvm.org/viewvc/llvm-project?rev=349766&view=rev Log: Replace MemoryRegionInfoSP with values and cleanup related code Differential Revision: https://reviews.llvm.org/D55472 Modified: lldb/trunk/include/lldb/AP

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil updated this revision to Diff 179028. jankratochvil added a comment. Herald added a subscriber: krytarowski. Updated symbols.enable-external-lookup description in detail. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55859/new/ https://reviews.llv

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

labath added a comment. In D55859#1336470 , @jankratochvil wrote: > Is the patch OK for check-in now? Thanks. I'd still like the update the description of the setting controlling this. As it stands now, I don't think it accurately describes what's happ