[Lldb-commits] [lldb] r349435 - Call DeleteCurrentProcess before we replace the old process.

Author: jingham Date: Mon Dec 17 17:49:02 2018 New Revision: 349435 URL: http://llvm.org/viewvc/llvm-project?rev=349435&view=rev Log: Call DeleteCurrentProcess before we replace the old process. We need to ensure that Finalize gets called before we start to destroy the old Process or the weak_ptr

[Lldb-commits] [PATCH] D55631: Delay replacing the process till after we've finalized it

This revision was automatically updated to reflect the committed changes. Closed by commit rL349435: Call DeleteCurrentProcess before we replace the old process. (authored by jingham, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D556

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

stella.stamenova added a comment. This change made the Windows test get stuck: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2340 They are now being killed after running for 40 minutes instead of completing in under 2. Repository: rL LLVM CHANGES SINCE LAST ACTION https

[Lldb-commits] [lldb] r349429 - Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used.

Author: gclayton Date: Mon Dec 17 16:50:11 2018 New Revision: 349429 URL: http://llvm.org/viewvc/llvm-project?rev=349429&view=rev Log: Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used. Each process plug-in can create its own custom commands. I figured it wo

[Lldb-commits] [PATCH] D55727: Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB349429: Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump… (authored by gclayton, committed by ). Herald added a subscriber: abidh. Repository: rLLDB LLDB CHANGES SINC

[Lldb-commits] [PATCH] D55727: Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used.

clayborg updated this revision to Diff 178549. clayborg added a comment. Fixed all requested changes. Added a complete test in lit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55727/new/ https://reviews.llvm.org/D55727 Files: lit/Minidump/Inputs/dump-content.dmp lit/Minidump/dump

[Lldb-commits] [lldb] r349417 - A few small updates to the testsuite for running against an iOS device.

Author: jmolenda Date: Mon Dec 17 15:33:40 2018 New Revision: 349417 URL: http://llvm.org/viewvc/llvm-project?rev=349417&view=rev Log: A few small updates to the testsuite for running against an iOS device. Remove the expected-fails for 34538611; using an alternate platform implementation handles

[Lldb-commits] [lldb] r349409 - Document the DBGSourcePathRemapping dictionary that may be

Author: jmolenda Date: Mon Dec 17 14:25:54 2018 New Revision: 349409 URL: http://llvm.org/viewvc/llvm-project?rev=349409&view=rev Log: Document the DBGSourcePathRemapping dictionary that may be present in the dSYM per-uuid plist, its precedence order with the older DBGBuildSourcePath/DBGSourcePat

[Lldb-commits] [lldb] r349406 - Add PdbAstBuilder.cpp.

Author: jmolenda Date: Mon Dec 17 14:07:39 2018 New Revision: 349406 URL: http://llvm.org/viewvc/llvm-project?rev=349406&view=rev Log: Add PdbAstBuilder.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.org/viewvc/l

[Lldb-commits] [lldb] r349401 - [lit] Detect unexpected passes in lldbtest.

Author: jdevlieghere Date: Mon Dec 17 13:40:37 2018 New Revision: 349401 URL: http://llvm.org/viewvc/llvm-project?rev=349401&view=rev Log: [lit] Detect unexpected passes in lldbtest. This patch will have lit report unexpected passes when dotest reports at least one XPASS and no failures. Modifie

[Lldb-commits] [lldb] r349399 - Fix case of source file in CMakeLists.txt

Author: zturner Date: Mon Dec 17 13:33:08 2018 New Revision: 349399 URL: http://llvm.org/viewvc/llvm-project?rev=349399&view=rev Log: Fix case of source file in CMakeLists.txt Modified: lldb/trunk/source/Plugins/SymbolFile/NativePDB/CMakeLists.txt Modified: lldb/trunk/source/Plugins/SymbolFi

[Lldb-commits] [lldb] r349397 - Remove sleep() synchronisation from teststcase and

Author: adrian Date: Mon Dec 17 13:18:11 2018 New Revision: 349397 URL: http://llvm.org/viewvc/llvm-project?rev=349397&view=rev Log: Remove sleep() synchronisation from teststcase and make the executable name more unique. This test is failing sporadically on some bots. By removing the sleep synch

[Lldb-commits] [lldb] r349398 - Reflow readme

Author: adrian Date: Mon Dec 17 13:18:12 2018 New Revision: 349398 URL: http://llvm.org/viewvc/llvm-project?rev=349398&view=rev Log: Reflow readme Modified: lldb/trunk/packages/Python/lldbsuite/test/README-TestSuite Modified: lldb/trunk/packages/Python/lldbsuite/test/README-TestSuite URL: h

[Lldb-commits] [lldb] r349383 - [NativePDB] Decouple AST reconstruction from lldb Symbol creation.

Author: zturner Date: Mon Dec 17 11:43:33 2018 New Revision: 349383 URL: http://llvm.org/viewvc/llvm-project?rev=349383&view=rev Log: [NativePDB] Decouple AST reconstruction from lldb Symbol creation. Previously the code that parsed debug info to create lldb's Symbol objects such as Variable, Typ

[Lldb-commits] [PATCH] D55776: Fix lldb's macosx/heap.py cstr command

clayborg added a comment. nice! A lot of great commands in heap.py. Like see them fixed and improved CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55776/new/ https://reviews.llvm.org/D55776 ___ lldb-commits mailing list lldb-commits@lists.l

Re: [Lldb-commits] [lldb] r349372 - Fix lldb's macosx/heap.py cstr command.

For the masses, this is https://reviews.llvm.org/D55776 On Mon, Dec 17, 2018 at 10:24 AM Davide Italiano via lldb-commits wrote: > > Author: davide > Date: Mon Dec 17 10:21:51 2018 > New Revision: 349372 > > URL: http://llvm.org/viewvc/llvm-project?rev=349372&view=rev > Log: > Fix lldb's macosx/h

[Lldb-commits] [PATCH] D55776: Fix lldb's macosx/heap.py cstr command

davide accepted this revision. davide added a comment. commit 44b5014ce138fa293238afeaa53cfd4c2f5b12d2 (HEAD -> master) Author: Davide Italiano Date: Mon Dec 17 10:23:44 2018 -0800 Fix lldb's macosx/heap.py cstr command. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55776/new

[Lldb-commits] [lldb] r349372 - Fix lldb's macosx/heap.py cstr command.

Author: davide Date: Mon Dec 17 10:21:51 2018 New Revision: 349372 URL: http://llvm.org/viewvc/llvm-project?rev=349372&view=rev Log: Fix lldb's macosx/heap.py cstr command. Added: lldb/trunk/lit/Heap/ lldb/trunk/lit/Heap/Inputs/ lldb/trunk/lit/Heap/Inputs/cstr.c lldb/trunk/lit/H

[Lldb-commits] [PATCH] D55776: Fix lldb's macosx/heap.py cstr command

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks Davide! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55776/new/ https://reviews.llvm.org/D55776 ___ lldb-commi

[Lldb-commits] [lldb] r349371 - [Driver] Fix --repl argument.

Author: jdevlieghere Date: Mon Dec 17 10:11:48 2018 New Revision: 349371 URL: http://llvm.org/viewvc/llvm-project?rev=349371&view=rev Log: [Driver] Fix --repl argument. The --repl option was incorrectly defined as "Separate" (option and value separated by a space). This resulted in the option not

[Lldb-commits] [PATCH] D55736: build.py: inherit environment in the gcc builder

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. This does fix the issues. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55736/new/ https://reviews.llvm.org/D55736 _

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. It would be nice to see context when you submit diffs. with SVN: svn diff -x -U999 ... Or git: git diff -U999 Comment at: include/lldb/Core/Archi

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

This revision was automatically updated to reflect the committed changes. Closed by commit rL349366: Make crashlog.py work when a .dSYM is present, but a binary is missing (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[Lldb-commits] [PATCH] D55608: Make crashlog.py work or binaries with spaces in their names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL349367: Make crashlog.py work or binaries with spaces in their names (authored by adrian, committed by ). Herald added a s

[Lldb-commits] [lldb] r349366 - Make crashlog.py work when a .dSYM is present, but a binary is missing

Author: adrian Date: Mon Dec 17 09:25:57 2018 New Revision: 349366 URL: http://llvm.org/viewvc/llvm-project?rev=349366&view=rev Log: Make crashlog.py work when a .dSYM is present, but a binary is missing Often users have a crash log an d a .dSYM bundle, but not the original application binary. It

[Lldb-commits] [lldb] r349367 - Make crashlog.py work or binaries with spaces in their names

Author: adrian Date: Mon Dec 17 09:26:04 2018 New Revision: 349367 URL: http://llvm.org/viewvc/llvm-project?rev=349367&view=rev Log: Make crashlog.py work or binaries with spaces in their names This is a little dangerous since the crashlog files aren't 100% unambiguous, but the risk is mitigated

[Lldb-commits] [PATCH] D55724: [ARC] Add SystemV ABI

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55724/new/ https://reviews.llvm.org/D55724 ___ l

[Lldb-commits] [PATCH] D55761: lldb-test ir-memory-map: Use IntervalMap::contains

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55761/new/ https://reviews.llvm.org/D55761 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D55608: Make crashlog.py work or binaries with spaces in their names

clayborg accepted this revision. clayborg added a comment. Looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55608/new/ https://reviews.llvm.org/D55608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D55608: Make crashlog.py work or binaries with spaces in their names

aprantl updated this revision to Diff 178476. aprantl added a comment. Got rid of the no_uuid regex and added even more testcases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55608/new/ https://reviews.llvm.org/D55608 Files: examples/python/crashlog.py lit/Python/crashlog.test I

[Lldb-commits] [PATCH] D55757: ELF: Don't create sections for section header index 0

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. See inline comment and fix if you agree. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1993 SymbolType symbol_type = eSymbolTypeInvalid;

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

zturner added a comment. I thought about what my "ideal" design would look like. I'm not suggesting anyone should actually go off and do this, but since we're brainstorming design anyway, it doesn't hurt to consider what an optimal one should look like (and for the record, there may be things

[Lldb-commits] [lldb] r349360 - [Clang AST Context] Add a few helper functions.

Author: zturner Date: Mon Dec 17 08:15:13 2018 New Revision: 349360 URL: http://llvm.org/viewvc/llvm-project?rev=349360&view=rev Log: [Clang AST Context] Add a few helper functions. The first one allows us to add an enumerator to an enum if we already have an APSInt, since ultimately the implemen

[Lldb-commits] [PATCH] D55761: lldb-test ir-memory-map: Use IntervalMap::contains

labath created this revision. labath added a reviewer: vsk. Simplify the code by using the contains implementation in IntervalMap. There is a slight change of behavior here: We now treat an allocation of size 0, as if it was size 1. This guarantees that the returned addresses will be unique, wher

[Lldb-commits] [PATCH] D55757: ELF: Don't create sections for section 0

labath created this revision. labath added reviewers: clayborg, krytarowski, joerg. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. The first section header does not define a real section. Instead it is used for various elf extensions. This patch skips creation o