zturner added a subscriber: stella.stamenova.
zturner added a comment.
Well msvc implies system-windows, but i can have both
https://reviews.llvm.org/D54567
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Well msvc implies system-windows, but i can have both
On Fri, Nov 16, 2018 at 7:37 PM Stella Stamenova via Phabricator <
revi...@reviews.llvm.org> wrote:
> stella.stamenova accepted this revision.
> stella.stamenova added a comment.
> This revision is now accepted and ready to land.
>
> Feel free
stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.
Feel free to check this in. At this point this will only improve the results on
Windows and it works correctly on Linux.
Comment at: lldb/lit/SymbolFile/
Author: adrian
Date: Fri Nov 16 17:27:47 2018
New Revision: 347125
URL: http://llvm.org/viewvc/llvm-project?rev=347125&view=rev
Log:
Just don't even attempt to invoke sed on Windows.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
Modified: lldb/trunk/packages/Python/
Author: adrian
Date: Fri Nov 16 17:27:46 2018
New Revision: 347124
URL: http://llvm.org/viewvc/llvm-project?rev=347124&view=rev
Log:
Revert "Makefile.rules: Fix the windows-sed-quoting issue harder."
Modified:
lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
Modified: lldb/trunk
Author: jmolenda
Date: Fri Nov 16 17:08:01 2018
New Revision: 347122
URL: http://llvm.org/viewvc/llvm-project?rev=347122&view=rev
Log:
add PdbSymUid.cpp
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm-p
Author: adrian
Date: Fri Nov 16 16:45:58 2018
New Revision: 347120
URL: http://llvm.org/viewvc/llvm-project?rev=347120&view=rev
Log:
Makefile.rules: Fix the windows-sed-quoting issue harder.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
Modified: lldb/trunk/packages
Author: friss
Date: Fri Nov 16 16:40:31 2018
New Revision: 347117
URL: http://llvm.org/viewvc/llvm-project?rev=347117&view=rev
Log:
Make TestAppleSimulatorOSType.py more flexible
Different versions of Xcode have different outputs for the simctl command
Modified:
lldb/trunk/packages/Python/l
Author: zturner
Date: Fri Nov 16 16:05:06 2018
New Revision: 347114
URL: http://llvm.org/viewvc/llvm-project?rev=347114&view=rev
Log:
Add missing triple from llvm-mc command line.
Modified:
lldb/trunk/lit/SymbolFile/NativePDB/s_constant.cpp
Modified: lldb/trunk/lit/SymbolFile/NativePDB/s_con
zturner updated this revision to Diff 174473.
zturner added a comment.
Herald added a subscriber: ki.stfu.
- Added an `__init__.py` to the helper directory. This is required on Python 2
to make the import work.
- Changed a bunch of `%cc` substitutions to `%clang`.
- Changed the `%clang_cl` comma
Author: friss
Date: Fri Nov 16 15:07:28 2018
New Revision: 347109
URL: http://llvm.org/viewvc/llvm-project?rev=347109&view=rev
Log:
Rewrite stop-hook tests as a couple of FileCheck tests
Those tests were using pexpect and being flaky on some of ours bots.
This patch reimplmeents the tests usinf F
Author: adrian
Date: Fri Nov 16 14:44:57 2018
New Revision: 347104
URL: http://llvm.org/viewvc/llvm-project?rev=347104&view=rev
Log:
Makefile.rules: Degrade gracefully on Windows machines without sed.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
Modified: lldb/trun
JDevlieghere added a comment.
Looks like the sed expression is not working on Windows:
http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1418/steps/test/logs/stdio
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54601
___
lldb-com
Did this fix the bitfield problem too? I didn’t fix that one.
On Fri, Nov 16, 2018 at 11:56 AM Davide Italiano wrote:
> I saw you partially fixed this.
>
> I addressed the remaining problem in:
> Davides-Mac-Pro:lldb davide$ git llvm push
> Pushing 1 commit:
> b6fd30d9119 [Cocoa] Prefer llvm::S
I saw you partially fixed this.
I addressed the remaining problem in:
Davides-Mac-Pro:lldb davide$ git llvm push
Pushing 1 commit:
b6fd30d9119 [Cocoa] Prefer llvm::SignExtend64. Pointed out by zturner.
Sendinglldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
Transmitting file data .done
Author: davide
Date: Fri Nov 16 11:53:00 2018
New Revision: 347087
URL: http://llvm.org/viewvc/llvm-project?rev=347087&view=rev
Log:
[Cocoa] Prefer llvm::SignExtend64. Pointed out by zturner.
Modified:
lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
Modified: lldb/trunk/source/Plugins/Lang
Author: davide
Date: Fri Nov 16 11:48:23 2018
New Revision: 347084
URL: http://llvm.org/viewvc/llvm-project?rev=347084&view=rev
Log:
[SymbolFile] Remove unused function. NFCI.
Modified:
lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
Modified: lldb/trunk/source/Plugins
JDevlieghere updated this revision to Diff 174416.
https://reviews.llvm.org/D54616
Files:
include/lldb/API/SBDebugger.h
include/lldb/Core/Debugger.h
include/lldb/Utility/Reproducer.h
scripts/interface/SBDebugger.i
source/API/SBDebugger.cpp
source/Commands/CommandObjectReproducer.cpp
sgraenitz added a comment.
My change for lldb-server (https://reviews.llvm.org/D5) became obsolete,
but two small pieces of it are required in general/here.
Added them post-approval with the update above. It's the two additions to
`cmake/modules/AddLLDB.cmake` and `CMakeLists.txt`. Will leav
sgraenitz abandoned this revision.
sgraenitz added a comment.
Ok, I will close this then. Added the remaining part of the patch to
https://reviews.llvm.org/D54476
https://reviews.llvm.org/D5
___
lldb-commits mailing list
lldb-commits@lists.llvm
JDevlieghere updated this revision to Diff 174407.
JDevlieghere added a comment.
Simplify code a little, as per Stefan's (offline) suggestion.
https://reviews.llvm.org/D54616
Files:
include/lldb/API/SBDebugger.h
include/lldb/Utility/Reproducer.h
scripts/interface/SBDebugger.i
source/API
sgraenitz updated this revision to Diff 174405.
sgraenitz added a comment.
Set global LLVM_CODESIGNING_IDENTITY from LLDB_CODESIGN_IDENTITY (if given).
Pass through ENTITLEMENTS from add_lldb_executable to add_llvm_executable.
https://reviews.llvm.org/D54476
Files:
CMakeLists.txt
cmake/modu
JDevlieghere added a comment.
In https://reviews.llvm.org/D54567#1300670, @zturner wrote:
> In https://reviews.llvm.org/D54567#1300641, @JDevlieghere wrote:
>
> > Makes sense. Just to be clear, I'm not advocating running a product for the
> > lit suite, just having one option that controls both
Author: adrian
Date: Fri Nov 16 10:43:16 2018
New Revision: 347071
URL: http://llvm.org/viewvc/llvm-project?rev=347071&view=rev
Log:
Make path more robust so it also works with out-of-tree builds.
Modified:
lldb/trunk/lit/lit.cfg.py
Modified: lldb/trunk/lit/lit.cfg.py
URL:
http://llvm.org/v
JDevlieghere updated this revision to Diff 174399.
JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.
Missed a comment; fixed now.
https://reviews.llvm.org/D54616
Files:
include/lldb/API/SBDebugger.h
include/lldb/Utility/Reproducer.h
scripts/interface/SBDebugger.
JDevlieghere updated this revision to Diff 174398.
JDevlieghere marked 4 inline comments as done.
JDevlieghere added a comment.
Address Stefan's review feedback.
https://reviews.llvm.org/D54616
Files:
include/lldb/API/SBDebugger.h
include/lldb/Utility/Reproducer.h
scripts/interface/SBDebu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347068: [CMake] Accept ENTITLEMENTS in add_llvm_executable
and llvm_codesign (authored by stefan.graenitz, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D54443
Files:
llvm/trunk/CMake
Sorry Zach, I was sick for the past few days. I'll look into this one now.
--
Davide
On Wed, Nov 14, 2018 at 9:16 AM Zachary Turner wrote:
>
>
>
> On Tue, Nov 13, 2018 at 11:46 AM Davide Italiano via lldb-commits
> wrote:
>>
>> Author: davide
>> Date: Tue Nov 13 11:43:43 2018
>> New Revision: 3
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D54443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
sgraenitz added a comment.
Thanks. Waiting for https://reviews.llvm.org/D54443
https://reviews.llvm.org/D54476
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sgraenitz added a comment.
Tested on macOS and Linux with the use-cases mentioned.
Repository:
rL LLVM
https://reviews.llvm.org/D54443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
sgraenitz added a comment.
Looks pretty good to me, but added my 2¢ on minor things.
Comment at: include/lldb/Utility/Reproducer.h:169
+ llvm::Error SetCapture(bool value, FileSpec root = {});
+ llvm::Error SetReplay(bool value, FileSpec root = {});
Are the
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB347057: Use a shared module cache directory for LLDB.
(authored by adrian, committed by ).
Herald added a subscriber: teemperor.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54602
Files:
lit/
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB347056: Makefile.rules: Use a shared clang module cache
directory. (authored by adrian, committed by ).
Herald added a subscriber: teemperor.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54601
Author: adrian
Date: Fri Nov 16 08:19:07 2018
New Revision: 347056
URL: http://llvm.org/viewvc/llvm-project?rev=347056&view=rev
Log:
Makefile.rules: Use a shared clang module cache directory.
Just to be safe, up until now each test used its own Clang module
cache directory. Since the compiler wit
Author: adrian
Date: Fri Nov 16 08:19:07 2018
New Revision: 347057
URL: http://llvm.org/viewvc/llvm-project?rev=347057&view=rev
Log:
Use a shared module cache directory for LLDB.
This saves about 3 redundant gigabytes from the Objective-C test build
directories. Tests that must do unsavory things
Author: adrian
Date: Fri Nov 16 08:19:08 2018
New Revision: 347058
URL: http://llvm.org/viewvc/llvm-project?rev=347058&view=rev
Log:
Typo
Modified:
lldb/trunk/test/CMakeLists.txt
Modified: lldb/trunk/test/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/test/CMakeLists.txt
37 matches
Mail list logo
