malaperle added a comment.
In https://reviews.llvm.org/D52953#1268810, @MaskRay wrote:
> And there is no reviewers set :)
I don't know who to add.
Repository:
rL LLVM
https://reviews.llvm.org/D52953
___
lldb-commits mailing list
lldb-commits@l
MaskRay added a comment.
And there is no reviewers set :)
Repository:
rL LLVM
https://reviews.llvm.org/D52953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
MaskRay added inline comments.
Comment at: tools/lldb-mi/MICmdCmdGdbSet.cpp:447
+bool CMICmdCmdGdbSet::OptionFnBreakpoint(
+ const CMIUtilString::VecString_t
&vrWords) {
+bool bPending = false;
clang-format
Reposito
malaperle added a comment.
Gentle ping?
Repository:
rL LLVM
https://reviews.llvm.org/D52953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
stella.stamenova created this revision.
stella.stamenova added reviewers: asmith, vsk.
Herald added subscribers: lldb-commits, abidh.
These tests fail on Windows because of known limitations (a.k.a. bugs) with the
current implementation of GetFrameAtIndex
Repository:
rLLDB LLDB
https://revie
cameron314 created this revision.
cameron314 added reviewers: zturner, clayborg.
Herald added a subscriber: lldb-commits.
This patch changes the order that mutexes are acquired in SBProcess such that
the target API mutex is now always acquired before the public run lock mutex is
acquired.
This
Hey Vedant,
I’ve attached the logs from Linux.
Most of the tests now pass on Windows with the exception of
TestSteppingOutWithArtificialFrames and TestTailCallFrameSBAPI. Both of these
attempt to get a specific frame by calling GetFrameAtIndex which only works
partially on Windows right now. I
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344746: [SymbolFileNativePDB] Fix missing linkage to
DebugInfoCodeView (authored by mgorny, committed by ).
Herald added a
Author: mgorny
Date: Thu Oct 18 08:39:22 2018
New Revision: 344746
URL: http://llvm.org/viewvc/llvm-project?rev=344746&view=rev
Log:
[SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView
Differential Revision: https://reviews.llvm.org/D53402
Modified:
lldb/trunk/source/Plugins/Symbo
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB344744: [lldbsuite] Mark the TestScriptedResolver tests
as XFAIL on Windows (authored by stella.stamenova, committed by
Author: stella.stamenova
Date: Thu Oct 18 08:30:31 2018
New Revision: 344744
URL: http://llvm.org/viewvc/llvm-project?rev=344744&view=rev
Log:
[lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows
Summary: They fail similarly to some of the other breakpoint tests on Windows,
so I s
zturner added a subscriber: mgorny.
zturner added a comment.
Lgtm
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53402
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Lgtm
On Thu, Oct 18, 2018 at 8:03 AM Michał Górny via Phabricator <
revi...@reviews.llvm.org> wrote:
> mgorny created this revision.
> mgorny added a reviewer: zturner.
> Herald added a subscriber: JDevlieghere.
>
> Repository:
> rLLDB LLDB
>
> https://reviews.llvm.org/D53402
>
> Files:
> sour
mgorny created this revision.
mgorny added a reviewer: zturner.
Herald added a subscriber: JDevlieghere.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53402
Files:
source/Plugins/SymbolFile/NativePDB/CMakeLists.txt
Index: source/Plugins/SymbolFile/NativePDB/CMakeLists.txt
==
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D53086#1267988, @labath wrote:
> The thing that's not clear to me is: are you specifically interested in
> unwinding from these kinds of functions **without debug info**? Because it
> sounds to me like the info Zachary provided is en
grimar updated this revision to Diff 170050.
grimar added a comment.
- Rebased, resolved conflicts.
https://reviews.llvm.org/D53140
Files:
lit/Breakpoint/Inputs/debug_rnglist_offset_pair.yaml
lit/Breakpoint/debug_rnglist_offset_pair.test
source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344729: [Windows] Fix threads comparison on Windows
(authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53357?vs=16
Author: aleksandr.urakov
Date: Thu Oct 18 00:52:56 2018
New Revision: 344729
URL: http://llvm.org/viewvc/llvm-project?rev=344729&view=rev
Log:
[Windows] Fix threads comparison on Windows
Summary:
This patch makes Windows threads to compare by a thread ID, not by a handle.
It's because the same th
aleksandr.urakov added a comment.
Thank you!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
19 matches
Mail list logo
