[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

2018-10-14 Thread Dávid Bolvanský via Phabricator via lldb-commits
xbolva00 added a comment. In our case (yes, we have some "additional dwarf", we are gonna fix it on our side), it crashed with "process launch -s". Repository: rLLDB LLDB https://reviews.llvm.org/D53255 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

2018-10-14 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In https://reviews.llvm.org/D53255#1264782, @xbolva00 wrote: > reproducer archive - 404 not found Fixed, sorry. Repository: rLLDB LLDB https://reviews.llvm.org/D53255 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

2018-10-14 Thread Dávid Bolvanský via Phabricator via lldb-commits
xbolva00 added a comment. reproducer archive - 404 not found Repository: rLLDB LLDB https://reviews.llvm.org/D53255 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D46810: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

2018-10-14 Thread Jan Kratochvil via lldb-commits
On Thu, 27 Sep 2018 18:21:13 +0200, Greg Clayton via lldb-commits wrote: > One fix that would work it to make the DWARFDebugInfoEntry* inside the > DWARFDie to be mutable and allow it to "fix" itself when a call is made. So > the flow would be: > > auto CUDie = cu->GetUnitDIEOnly(); > for (auto

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

2018-10-14 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:179 + if (!m_die_array.empty()) { +lldbassert(!m_first_die || m_first_die == m_die_array.front()); +m_first_die = m_die_array.front(); labath wrote:

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

2018-10-14 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, aprantl. xbolva00 bugreported $subj It can happen only from the line: m_die_array.back().S

[Lldb-commits] [PATCH] D52404: Prevent double import of _lldb module

2018-10-14 Thread Vadim Chugunov via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL344474: Fix double import of _lldb module. (authored by vadimcn, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52404?vs=166627&id=169595#toc

[Lldb-commits] [lldb] r344474 - Fix double import of _lldb module.

2018-10-14 Thread Vadim Chugunov via lldb-commits
Author: vadimcn Date: Sun Oct 14 00:24:56 2018 New Revision: 344474 URL: http://llvm.org/viewvc/llvm-project?rev=344474&view=rev Log: Fix double import of _lldb module. Fix llvm.org/pr39054: - Register _lldb as a built-in module during initialization of script interpreter, - Reverse the order of