stella.stamenova updated this revision to Diff 169515.
https://reviews.llvm.org/D53226
Files:
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
Index:
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
stella.stamenova created this revision.
stella.stamenova added reviewers: davide, asmith.
Herald added a subscriber: lldb-commits.
This test is failing on Windows because lldb does not support JIT on Windows.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53226
Files:
packages/Python/ll
Yep, thanks!
% bin/lldb-test symbols ../f.obj
Module: ../f.obj
Module ../f.obj
0x7fb795587320: ObjectFileMachO64, file = '../f.obj', triple =
x86_64-apple-macosx10.14.0
SectID Type File Address Perm
File Off. File Size Flags Section Name
-
Author: zturner
Date: Fri Oct 12 16:07:32 2018
New Revision: 344431
URL: http://llvm.org/viewvc/llvm-project?rev=344431&view=rev
Log:
Add REQUIRES: lld to SymbolFileNativePDB tests.
Modified:
lldb/trunk/lit/SymbolFile/NativePDB/disassembly.cpp
lldb/trunk/lit/SymbolFile/NativePDB/simple-br
Candidate fix submitted in r344429. Thanks for reporting.
On Fri, Oct 12, 2018 at 3:54 PM Zachary Turner wrote:
> Yea that part is clear, I just wonder what it's trying to parse. It
> sounds like an actual PDB file, because otherwise it shouldn't have made it
> that far in the code. But if it
Author: zturner
Date: Fri Oct 12 15:57:40 2018
New Revision: 344429
URL: http://llvm.org/viewvc/llvm-project?rev=344429&view=rev
Log:
Try to fix some failures on MacOSX with the NativePDB patch.
This adds -- before any filenames, so that /U doesn't get interpreted
as a command line.
It also adds
stella.stamenova updated this revision to Diff 169509.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53208
Files:
packages/Python/lldbsuite/test/decorators.py
Index: packages/Python/lldbsuite/test/decorators.py
===
--- pack
Yea that part is clear, I just wonder what it's trying to parse. It sounds
like an actual PDB file, because otherwise it shouldn't have made it that
far in the code. But if it's an actual PDB file, it shouldn't be failing.
Anyway, the code definitely has a bug in that it doesn't correctly handle
Adrian suggests that parseFileHeaders is returning an error and that needs to
be cleared?
> On Oct 12, 2018, at 3:27 PM, Jason Molenda wrote:
>
> Ah, mystery solved. The lit test specifies REQUIRES Darwin.
>
>> On Oct 12, 2018, at 3:22 PM, Jason Molenda wrote:
>>
>>
>>
>>> On Oct 12, 2
It's strange though, I wonder how it's even getting to this code path. If
it makes it this far we've already confirmed that whatever the input is,
it's an actual PDB file. So I don't know why it would fail to parse.
On Fri, Oct 12, 2018 at 3:29 PM Zachary Turner wrote:
> I think we just need t
I think we just need to add an llvm::consumeError(EC); on both of those
lines before they return failure. Sorry for missing this.
On Fri, Oct 12, 2018 at 3:27 PM Jason Molenda wrote:
> Ah, mystery solved. The lit test specifies REQUIRES Darwin.
>
> > On Oct 12, 2018, at 3:22 PM, Jason Molenda
Ah, mystery solved. The lit test specifies REQUIRES Darwin.
> On Oct 12, 2018, at 3:22 PM, Jason Molenda wrote:
>
>
>
>> On Oct 12, 2018, at 12:47 PM, Zachary Turner via lldb-commits
>> wrote:
>>
>> Resubmit "Add SymbolFileNativePDB plugin."
>>
>> This was originally reverted due to som
> On Oct 12, 2018, at 12:47 PM, Zachary Turner via lldb-commits
> wrote:
>
> Resubmit "Add SymbolFileNativePDB plugin."
>
> This was originally reverted due to some test failures on
> Linux. Those problems turned out to require several additional
> patches to lld and clang in order to fix, w
jingham added a comment.
We do compose the decorators in a bunch of places (like Shafik's usage here).
That will work more naturally if the categories that the decorators assert are
as decoupled as possible. So the statement about macos version should only
skip the test if the os is macos, an
Author: jingham
Date: Fri Oct 12 14:27:49 2018
New Revision: 344418
URL: http://llvm.org/viewvc/llvm-project?rev=344418&view=rev
Log:
Change the default handling for SIGPIPE to pass/,no-stop/no-notify.
Most of the time SIGPIPE is just annoying, and so we should
pass it on silently it by default.
I will update the master tonight.
Thanks
Galina
On Fri, Oct 12, 2018 at 12:36 PM Stella Stamenova
wrote:
> + Galina,
>
>
>
> Galina, is there anything we need to do for the buildbots to pick up the
> change that Vedant made?
>
>
>
> Thanks,
>
> -Stella
>
>
>
> *From:* v...@apple.com
> *Sent:*
stella.stamenova added inline comments.
Comment at: packages/Python/lldbsuite/test/decorators.py:194
py_version[0], py_version[1], sys.version_info)
-skip_for_macos_version = (macos_version is None) or (
+skip_for_macos_version = (macos_version is Non
Sorry for the trouble, hopefully it sticks this time.
On Fri, Oct 12, 2018 at 1:55 PM Jason Molenda via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: jmolenda
> Date: Fri Oct 12 13:53:21 2018
> New Revision: 344414
>
> URL: http://llvm.org/viewvc/llvm-project?rev=344414&view=rev
>
shafik added inline comments.
Comment at: packages/Python/lldbsuite/test/decorators.py:194
py_version[0], py_version[1], sys.version_info)
-skip_for_macos_version = (macos_version is None) or (
+skip_for_macos_version = (macos_version is None) or
(pl
Author: jmolenda
Date: Fri Oct 12 13:53:21 2018
New Revision: 344414
URL: http://llvm.org/viewvc/llvm-project?rev=344414&view=rev
Log:
Add NativePDB subdir again.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/vie
Progress! The tests are running again and only a handful fail (some because of
FileCheck, others for various other reasons).
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/29816
It looks like there a number of tests that have failures unrelated to
FileCheck, so anyone w
Author: stella.stamenova
Date: Fri Oct 12 13:00:20 2018
New Revision: 344410
URL: http://llvm.org/viewvc/llvm-project?rev=344410&view=rev
Log:
Fix failure in get_filecheck_path when filecheck is None
If the path was not specified (and it's None), lexists throws an exception
rather than returning
stella.stamenova added a comment.
In https://reviews.llvm.org/D49271#1263842, @shafik wrote:
> @stella.stamenova Thank you for catching this. I fixed the test names, I am
> looking into the best way to fix the skipif now.
@shafik I send a change for review this morning that I think should do t
shafik marked 2 inline comments as done.
shafik added a comment.
@stella.stamenova Thank you for catching this. I fixed the test names, I am
looking into the best way to fix the skipif now.
https://reviews.llvm.org/D49271
___
lldb-commits mailing l
> On Oct 12, 2018, at 12:52 PM, Stella Stamenova via Phabricator
> wrote:
>
> stella.stamenova added a comment.
>
> The bots are now failing because lexists doesn't handle NoneType correctly:
>
>File
> "/lldb-buildbot/lldbSlave/buildWorkingDir/llvm/tools/lldb/packages/Python/lldbsuite/t
stella.stamenova added a comment.
The bots are now failing because lexists doesn't handle NoneType correctly:
File
"/lldb-buildbot/lldbSlave/buildWorkingDir/llvm/tools/lldb/packages/Python/lldbsuite/test/configuration.py",
line 191, in get_filecheck_path
if os.path.lexists(filecheck):
Author: zturner
Date: Fri Oct 12 12:47:13 2018
New Revision: 344409
URL: http://llvm.org/viewvc/llvm-project?rev=344409&view=rev
Log:
Resubmit "Add SymbolFileNativePDB plugin."
This was originally reverted due to some test failures on
Linux. Those problems turned out to require several additiona
Author: shafik
Date: Fri Oct 12 12:46:17 2018
New Revision: 344407
URL: http://llvm.org/viewvc/llvm-project?rev=344407&view=rev
Log:
Changing test names in TestDataFormatterLibcxxVariant.py and
TestStdFunctionStepIntoCallable.py to be unique, NFC
Modified:
lldb/trunk/packages/Python/lldbsui
They have to restart the master, Galina just did it yesterday so it might
happen again in a couple days
On Fri, Oct 12, 2018 at 12:36 PM Stella Stamenova
wrote:
> + Galina,
>
>
>
> Galina, is there anything we need to do for the buildbots to pick up the
> change that Vedant made?
>
>
>
> Thanks,
+ Galina,
Galina, is there anything we need to do for the buildbots to pick up the change
that Vedant made?
Thanks,
-Stella
From: v...@apple.com
Sent: Friday, October 12, 2018 12:34 PM
To: Stella Stamenova
Cc: Zachary Turner ; lldb-commits@lists.llvm.org;
reviews+d53175+public+09519a8f992e0.
Ah gotcha. For the public Darwin bots, we needed to specifically trigger a
Jenkins job to distribute Zorg updates to all our builders. This can be a bit
of a manual process, because you need to kill the jobs on the builders’ queues
to make sure they run the Zorg_Distribute job asap.
I’m not sur
Author: vedantk
Date: Fri Oct 12 12:29:59 2018
New Revision: 344401
URL: http://llvm.org/viewvc/llvm-project?rev=344401&view=rev
Log:
[dotest] Make a missing FileCheck binary a warning, not an error
This allows bots which haven't updated to pass in --filecheck to
dotest.py to run more tests. File
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344401: [dotest] Make a missing FileCheck binary a warning,
not an error (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
Thanks, I’ve been monitoring the bots also and it looks like they haven’t
picked up the zorg change yet. I don’t know if that’s supposed to just happen
or if there’s something that needs to be done or if there’s a schedule for when
they update.
Thanks,
-Stella
From: v...@apple.com
Sent: Frida
stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.
Thanks!
https://reviews.llvm.org/D53175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
vsk updated this revision to Diff 169471.
vsk added a comment.
- Address comments from @stella.stamenova
https://reviews.llvm.org/D53175
Files:
lldb/packages/Python/lldbsuite/test/configuration.py
lldb/packages/Python/lldbsuite/test/dotest.py
lldb/packages/Python/lldbsuite/test/lldbtest.p
Author: jingham
Date: Fri Oct 12 11:46:02 2018
New Revision: 344397
URL: http://llvm.org/viewvc/llvm-project?rev=344397&view=rev
Log:
Add "v" as well as "var" as an alias for "frame var".
Modified:
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Modified: lldb/trunk/source/Interpreter
All right, Committed r344396, I’ll keep an eye out for failures.
vedant
> On Oct 12, 2018, at 9:58 AM, Stella Stamenova wrote:
>
> Those changes look reasonable, but I don't know how to test it either. I
> would be in favor of checking it in because the buildbots are currently
> broken and th
stella.stamenova added a comment.
This change has the same problem as https://reviews.llvm.org/D49271 - the class
name LibCxxFunctionTestCase is re-used from another test case. This will cause
issues when the tests report results and create logs. Please use unique names
for each class and test.
Author: stella.stamenova
Date: Fri Oct 12 10:56:01 2018
New Revision: 344386
URL: http://llvm.org/viewvc/llvm-project?rev=344386&view=rev
Log:
[lldbsuite] Fix the filecheck functionality to work with Python 3
Summary: This is another string/byte conversion issue between Python 2 and 3.
In Python
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB344386: [lldbsuite] Fix the filecheck functionality to
work with Python 3 (authored by stella.stamenova, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53166
Files:
packages/Pyt
stella.stamenova created this revision.
stella.stamenova added reviewers: labath, davide, asmith, shafik.
Herald added a subscriber: lldb-commits.
On non-mac platforms, mac_ver returns an empty string which when converted to
LooseVersion has no "version" property. This causes a failure when the
stella.stamenova added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:2247-2249
subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE)
cmd_stdout, cmd_stderr = subproc.communicate(input=output)
cmd_status = subpro
stella.stamenova updated this revision to Diff 169459.
stella.stamenova edited the summary of this revision.
stella.stamenova added a comment.
Force the comparison in filecheck to use text rather than bytes
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53166
Files:
packages/Python/lldbs
stella.stamenova added a comment.
I see this test failing on Linux right now (bots are down, so I can't confirm
that the official bots fail as well). The failure is because of the last
decorator which was not part of the review:
@skipIf(macos_version=["<", "10.14"])
It looks like this only w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344371: Adding support to step into the callable wrapped by
libc++ std::function (authored by shafik, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
Author: shafik
Date: Fri Oct 12 10:20:39 2018
New Revision: 344371
URL: http://llvm.org/viewvc/llvm-project?rev=344371&view=rev
Log:
Adding support to step into the callable wrapped by libc++ std::function
rdar://problem/14365983
Differential Revision: https://reviews.llvm.org/D52851
Added:
stella.stamenova requested changes to this revision.
stella.stamenova added a comment.
This revision now requires changes to proceed.
@vsk Could you also make the filecheck function explicitly fail when it doesn't
have a path to the binary? That way it will be fairly obvious what the problem
is
stella.stamenova added a comment.
@jasonmolenda That's not a bad idea. If you have a change ready, you could send
it for review ;)
https://reviews.llvm.org/D53175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Those changes look reasonable, but I don't know how to test it either. I would
be in favor of checking it in because the buildbots are currently broken and
this can't make it worse, right?
-Original Message-
From: v...@apple.com
Sent: Thursday, October 11, 2018 3:56 PM
To: Stella Stame
grimar created this revision.
grimar added reviewers: LLDB, clayborg.
Herald added subscribers: JDevlieghere, aprantl.
DWARF5 describes DW_RLE_start_end as:
> This is a form of bounded range entry that has two target address operands.
> Each operand is the same size as used in DW_FORM_addr. T
grimar added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h:51-55
+ struct RngListEntry {
+uint8_t encoding;
+uint64_t value0;
+uint64_t value1;
+ };
clayborg wrote:
> Do we really need to store all this? Can't we ju
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB344328: [LLDB] - Add support for DW_FORM_implicit_const.
(authored by grimar, committed by ).
Herald added a subscriber: abidh.
Changed prior to commit:
https://reviews.llvm.org/D52689?vs=169209&id=1
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D53086#1263002, @zturner wrote:
> Do we have access to the current instruction pointer? That's what you need
> to find the correct FPO record.
No, it seems that we haven't. But if there's the only one
`S_DEFRANGE_FRAMEPOINTER_REL`
54 matches
Mail list logo
