[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

2018-10-05 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB343900: Add support for artificial tail call frames (authored by vedantk, committed by ). Herald added subscribers: teemperor, abidh. Changed prior to commit: https://reviews.llvm.org/D50478?vs=16815

[Lldb-commits] [lldb] r343900 - Add support for artificial tail call frames

2018-10-05 Thread Vedant Kumar via lldb-commits
Author: vedantk Date: Fri Oct 5 16:23:15 2018 New Revision: 343900 URL: http://llvm.org/viewvc/llvm-project?rev=343900&view=rev Log: Add support for artificial tail call frames This patch teaches lldb to detect when there are missing frames in a backtrace due to a sequence of tail calls, and to

[Lldb-commits] [lldb] r343899 - Relax a data formatter test

2018-10-05 Thread Vedant Kumar via lldb-commits
Author: vedantk Date: Fri Oct 5 16:14:13 2018 New Revision: 343899 URL: http://llvm.org/viewvc/llvm-project?rev=343899&view=rev Log: Relax a data formatter test Before inspecting the contents of a list, make sure that we've stepped past the push_back() that inserts the element we're interested i

[Lldb-commits] [PATCH] D52941: NativeProcessProtocol: Simplify breakpoint setting code

2018-10-05 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: krytarowski, zturner, clayborg. Herald added a subscriber: mgorny. A fairly simple operation as setting a breakpoint (writing a breakpoint opcode) at a given address was going through three classes: NativeProcessProtocol which called NativeBrea

[Lldb-commits] [PATCH] D52270: TestMultilineExpr: validate evaluation for expressions spread over multiple lines

2018-10-05 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343860: TestMultilineExpr: validate evaluation for expressions that span multiple lines (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

2018-10-05 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343859: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the… (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://r

[Lldb-commits] [lldb] r343860 - TestMultilineExpr: validate evaluation for expressions that span multiple lines

2018-10-05 Thread Stefan Granitz via lldb-commits
Author: stefan.graenitz Date: Fri Oct 5 09:49:53 2018 New Revision: 343860 URL: http://llvm.org/viewvc/llvm-project?rev=343860&view=rev Log: TestMultilineExpr: validate evaluation for expressions that span multiple lines Summary: When LLDB successfully parses a command (like "expression" in this

[Lldb-commits] [lldb] r343859 - Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

2018-10-05 Thread Stefan Granitz via lldb-commits
Author: stefan.graenitz Date: Fri Oct 5 09:49:47 2018 New Revision: 343859 URL: http://llvm.org/viewvc/llvm-project?rev=343859&view=rev Log: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings. Summary: Add set

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

2018-10-05 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz updated this revision to Diff 168478. sgraenitz marked an inline comment as done. sgraenitz added a comment. Rename folder lit/Settings/Resources to lit/Settings/Inputs https://reviews.llvm.org/D52788 Files: include/lldb/API/SBCommandInterpreter.h include/lldb/Interpreter/CommandI

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

2018-10-05 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. One final inline comment but otherwise I think this is good to go. Thanks! Comment at: lit/Settings/Resources/EchoCommandsAll.out:1 +# CHECK: (lldb) command source -s {{.*\

[Lldb-commits] [PATCH] D52270: TestMultilineExpr: validate evaluation for expressions spread over multiple lines

2018-10-05 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz marked an inline comment as done. sgraenitz added a comment. Requires: https://reviews.llvm.org/D52788 (Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings) https://reviews.llvm.org/D52270 ___

[Lldb-commits] [PATCH] D52270: TestMultilineExpr: validate evaluation for expressions spread over multiple lines

2018-10-05 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz updated this revision to Diff 168466. sgraenitz added a comment. Simplify test as proposed in review https://reviews.llvm.org/D52270 Files: lit/Expr/TestMultilineExpr.test packages/Python/lldbsuite/test/expression_command/multiline/Makefile packages/Python/lldbsuite/test/expres

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

2018-10-05 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz marked an inline comment as done. sgraenitz added a comment. IMO Ready now. Comment at: source/Interpreter/CommandInterpreter.cpp:2417 flags |= eHandleCommandFlagPrintResult; } sgraenitz wrote: > Could reduce boilerplate in the code

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

2018-10-05 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz updated this revision to Diff 168453. sgraenitz added a comment. Enable interpreter.echo-comment-commands in lit-lldb-init. All tests still passing. https://reviews.llvm.org/D52788 Files: include/lldb/API/SBCommandInterpreter.h include/lldb/Interpreter/CommandInterpreter.h lit/

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

2018-10-05 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz updated this revision to Diff 168450. sgraenitz added a comment. Minor fixes https://reviews.llvm.org/D52788 Files: include/lldb/API/SBCommandInterpreter.h include/lldb/Interpreter/CommandInterpreter.h lit/Settings/Resources/EchoCommandsAll.out lit/Settings/Resources/EchoComma