[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

2018-09-22 Thread Alexander Polyakov via Phabricator via lldb-commits
apolyakov added a comment. AFAIR, adding an `exit(...)` to `ConnectToRemote` won't solve this problem. The test will still be failing on Arch. https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

2018-09-22 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Yes, the `writeSocketIdToPipe(unnamed_pipe_fd, socket_id);` fails in this method/file. https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

2018-09-22 Thread Greg Clayton via lldb-commits
> On Sep 21, 2018, at 1:20 PM, Leonard Mosescu wrote: > > Great. Do you think that having an abstracted stream I/O tunneled through DAP > would lose anything compared to the direct file handle? I can see a few > problems using a native platform file handle: > > 1. It's specific to the platf

[Lldb-commits] [lldb] r342804 - Change type of m_user_expression_start_pos to size_t

2018-09-22 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat Sep 22 06:33:08 2018 New Revision: 342804 URL: http://llvm.org/viewvc/llvm-project?rev=342804&view=rev Log: Change type of m_user_expression_start_pos to size_t AbsPosToLineColumnPos is the only reader of m_user_expression_start_pos and actually treats it like a size_t