jingham updated this revision to Diff 165614.
jingham added a comment.
I think this should address your concerns, though I did so more by reworking
the presentation, so you won't find inserts exactly at the places you pointed
out.
But I tried to make it clear that you only write the Resolver, a
vsk updated this revision to Diff 165613.
vsk marked 6 inline comments as done.
vsk added a comment.
Herald added a subscriber: mgorny.
Sorry for the delay, I was busy with other work. I think I've addressed the
review feedback. PTAL.
https://reviews.llvm.org/D50751
Files:
lldb/CMakeLists.tx
clayborg added a comment.
See inlined comments.
Comment at: www/python-reference.html:324
+
+Another use of the Python API's in lldb is to create a
custom breakpoint resolver. This
+ allows you to implement your own logic to search the space
Author: davide
Date: Fri Sep 14 13:48:34 2018
New Revision: 342280
URL: http://llvm.org/viewvc/llvm-project?rev=342280&view=rev
Log:
[IRInterpreter] Minor cleanups, add comments. NFCI.
Modified:
lldb/trunk/source/Expression/IRInterpreter.cpp
Modified: lldb/trunk/source/Expression/IRInterpret
Author: xiaobai
Date: Fri Sep 14 12:41:20 2018
New Revision: 342266
URL: http://llvm.org/viewvc/llvm-project?rev=342266&view=rev
Log:
Fix lldb-vscode README.md
Summary: The readme was missing "-" characters to enable links
Patch by Nathan Lanza
Differential Revision: https://reviews.llvm.org/D
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Thanks, that looks like a safe change.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52101
___
lldb-commits mailing list
lldb-commits@lis
Author: davide
Date: Fri Sep 14 11:55:31 2018
New Revision: 342262
URL: http://llvm.org/viewvc/llvm-project?rev=342262&view=rev
Log:
[IRInterpreter] Fall back to JIT with 128-bit values.
They're not that common, and falling back is definitely
better than throwing an error instead of the result. I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342259: Make the eSearchDepthFunction searches work, add
tests (authored by jingham, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52111?vs
Author: jingham
Date: Fri Sep 14 11:41:40 2018
New Revision: 342259
URL: http://llvm.org/viewvc/llvm-project?rev=342259&view=rev
Log:
Make the eSearchDepthFunction searches work, add tests
using the scripted breakpoint resolver.
Differential Revision: https://reviews.llvm.org/D52111
Modified:
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Very nice. You got it right.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52111
___
lldb-commits mailing list
lldb-commits@lists.llvm.
jingham created this revision.
jingham added a reviewer: clayborg.
Herald added a subscriber: lldb-commits.
I hadn't needed eSearchDepthFunction for anything so it was stubbed out. Greg
indicated he would be interested in using this for the scripted resolvers, so I
got it to work with this patc
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM now, thanks for the patch!
https://reviews.llvm.org/D51520
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
shafik updated this revision to Diff 165540.
shafik added a comment.
Applying clang-format to files I missed earlier
https://reviews.llvm.org/D51520
Files:
lldb.xcodeproj/project.pbxproj
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/Makefil
shafik added a comment.
@teemperor Thanks for the catch!
https://reviews.llvm.org/D51520
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
LibCxx.h/.cpp are still not clang-formatted. I ran clang-format over the patch
and pushed it here that this patch doesn't get stuck on this minor detail:
https://github.com/Tee
shafik updated this revision to Diff 165536.
shafik added a comment.
Applying clang-format
https://reviews.llvm.org/D51520
Files:
lldb.xcodeproj/project.pbxproj
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/Makefile
packages/Python/lldbs
teemperor created this revision.
teemperor added a reviewer: LLDB.
Herald added a subscriber: lldb-commits.
Completing inside the expression command now uses the new description API
to also provide additional information to the user. For now this information
are the types of variables/fields and t
shafik added inline comments.
Comment at: source/Commands/CommandObjectTarget.cpp:153
+static OptionDefinition g_dependents_options[1] = {
+{LLDB_OPT_SET_1, false, "no-dependents", 'd',
+ OptionParser::eOptionalArgument, nullptr, g_dependents_enumaration, 0,
-
apolyakov added a comment.
I've created this revision to be sure that you don't think that this approach
is some kind of hack.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52101
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
apolyakov created this revision.
apolyakov added reviewers: tatyana-krasnukha, aprantl, clayborg.
Herald added a subscriber: ki.stfu.
The test failed in case of compiling a test suite with
gcc (checked versions are 5.2.0 and 7.3.0) because it
adds one more line entry comparing to clang. It doesn't
teemperor added a comment.
This test is timing out for me on Arch Linux. Any idea why?
bash -x
./tools/lldb/lit/tools/lldb-mi/target/Output/target-select-so-path.test.script
+ set -o pipefail
+ set -x
+ : 'RUN: at line 3'
+ /data/llvm/dbg-build/./bin/clang -o
/data/llvm/dbg-build/tools/lldb/lit
tatyana-krasnukha added a comment.
symbol-list-lines.test fails on Linux too, input is compiled with gcc.
Comment at: lldb/trunk/lit/tools/lldb-mi/symbol/inputs/symbol-list-lines.c:6
+ return 0;
+}
The check doesn't count this line
Comment a
Author: aleksandr.urakov
Date: Fri Sep 14 00:46:06 2018
New Revision: 342208
URL: http://llvm.org/viewvc/llvm-project?rev=342208&view=rev
Log:
[PDB] Use the raw PDB symbol interface more accurately
Summary:
This patch adds some symbol tag checks before using the `IPDBRawSymbol`
interface to impro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342208: [PDB] Use the raw PDB symbol interface more
accurately (authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
aleksandr.urakov added a comment.
That would be great, thank you!
https://reviews.llvm.org/D51967
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
25 matches
Mail list logo
