[Lldb-commits] [PATCH] D51830: Add a way to make scripted breakpoints

2018-09-07 Thread Jim Ingham via Phabricator via lldb-commits
jingham created this revision. Herald added subscribers: lldb-commits, teemperor, abidh, jfb, srhines. This change allows you to make a breakpoint resolver kernel in Python. The breakpoint search mechanism in lldb works on top of a generic mechanism that uses a pair of Searcher - with its associ

[Lldb-commits] [lldb] r341732 - [XCodeproj] Remove extra whitespace in SBAPI path.

2018-09-07 Thread Davide Italiano via lldb-commits
Author: davide Date: Fri Sep 7 16:49:05 2018 New Revision: 341732 URL: http://llvm.org/viewvc/llvm-project?rev=341732&view=rev Log: [XCodeproj] Remove extra whitespace in SBAPI path. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [PATCH] D51816: Fix raw address breakpoints not resolving

2018-09-07 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision as: jingham. jingham added a comment. This revision is now accepted and ready to land. Looks good to me. https://reviews.llvm.org/D51816 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D51816: Fix raw address breakpoints not resolving

2018-09-07 Thread Ted Woodward via Phabricator via lldb-commits
ted updated this revision to Diff 164533. ted added a comment. Added a test to TestAddressBreakpoints.py that sets an address breakpoint before launch, launches, and checks to see if the breakpoint was hit. https://reviews.llvm.org/D51816 Files: include/lldb/Core/Address.h packages/Python

[Lldb-commits] [PATCH] D51816: Fix raw address breakpoints not resolving

2018-09-07 Thread Ted Woodward via Phabricator via lldb-commits
ted added a comment. Yes, I'll add a new test to TestAddressBreakpoints.py. Repository: rLLDB LLDB https://reviews.llvm.org/D51816 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D51816: Fix raw address breakpoints not resolving

2018-09-07 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. Can you add a test for this behavior? Repository: rLLDB LLDB https://reviews.llvm.org/D51816 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r341714 - [Disassembler] Run ARM-specific tests only if the ARM backend is built.

2018-09-07 Thread Davide Italiano via lldb-commits
On Fri, Sep 7, 2018 at 2:37 PM Davide Italiano via lldb-commits wrote: > > Author: davide > Date: Fri Sep 7 14:36:21 2018 > New Revision: 341714 > > URL: http://llvm.org/viewvc/llvm-project?rev=341714&view=rev > Log: > [Disassembler] Run ARM-specific tests only if the ARM backend is built. > > >

[Lldb-commits] [lldb] r341714 - [Disassembler] Run ARM-specific tests only if the ARM backend is built.

2018-09-07 Thread Davide Italiano via lldb-commits
Author: davide Date: Fri Sep 7 14:36:21 2018 New Revision: 341714 URL: http://llvm.org/viewvc/llvm-project?rev=341714&view=rev Log: [Disassembler] Run ARM-specific tests only if the ARM backend is built. Modified: lldb/trunk/unittests/Disassembler/CMakeLists.txt Modified: lldb/trunk/unitt

[Lldb-commits] [PATCH] D51816: Fix raw address breakpoints not resolving

2018-09-07 Thread Ted Woodward via Phabricator via lldb-commits
ted created this revision. ted added reviewers: jingham, LLDB. Herald added a subscriber: lldb-commits. An address breakpoint of the form "b 0x1000" won't resolve if it's created while the process isn't running. This patch deletes Address::SectionWasDeleted, renames Address::SectionWasDeletedPri

[Lldb-commits] [lldb] r341696 - Add the Disassembler unit test dir.

2018-09-07 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Sep 7 11:51:10 2018 New Revision: 341696 URL: http://llvm.org/viewvc/llvm-project?rev=341696&view=rev Log: Add the Disassembler unit test dir. Modified: lldb/trunk/unittests/CMakeLists.txt Modified: lldb/trunk/unittests/CMakeLists.txt URL: http://llvm.org/viewvc/

[Lldb-commits] [lldb] r341690 - NFC: Move Searcher::Depth into lldb-enumerations as SearchDepth.

2018-09-07 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Sep 7 11:43:04 2018 New Revision: 341690 URL: http://llvm.org/viewvc/llvm-project?rev=341690&view=rev Log: NFC: Move Searcher::Depth into lldb-enumerations as SearchDepth. In a subsequent commit, I will need to expose the search depth to the SB API's, so I'm moving this

[Lldb-commits] [PATCH] D51772: Check if a terminal supports colors on Windows properly

2018-09-07 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Thanks! Repository: rLLDB LLDB https://reviews.llvm.org/D51772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

Re: [Lldb-commits] [lldb] r341682 - [Scalar] Fix undefined behaviour when converting double to long.

2018-09-07 Thread Davide Italiano via lldb-commits
Correct patch recommitted (sorry, it's been a long week :() Pushing 1 commit: 5789b904aa5 [Scalar] Commit the correct patch, forgot `git add`. Sendinglldb/trunk/source/Utility/Scalar.cpp Transmitting file data .done Committing transaction... Committed revision 341685. Committed 5789b904a

[Lldb-commits] [lldb] r341685 - [Scalar] Commit the correct patch, forgot `git add`.

2018-09-07 Thread Davide Italiano via lldb-commits
Author: davide Date: Fri Sep 7 11:22:27 2018 New Revision: 341685 URL: http://llvm.org/viewvc/llvm-project?rev=341685&view=rev Log: [Scalar] Commit the correct patch, forgot `git add`. Modified: lldb/trunk/source/Utility/Scalar.cpp Modified: lldb/trunk/source/Utility/Scalar.cpp URL: http

Re: [Lldb-commits] [lldb] r341682 - [Scalar] Fix undefined behaviour when converting double to long.

2018-09-07 Thread Davide Italiano via lldb-commits
Note that we already have tests for this (that were failing [and hopefully they're not anymore]) On Fri, Sep 7, 2018 at 11:04 AM Davide Italiano via lldb-commits wrote: > > Author: davide > Date: Fri Sep 7 11:03:43 2018 > New Revision: 341682 > > URL: http://llvm.org/viewvc/llvm-project?rev=34168

[Lldb-commits] [lldb] r341683 - Add input files to the "prepare swig bindings" step.

2018-09-07 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Sep 7 11:10:26 2018 New Revision: 341683 URL: http://llvm.org/viewvc/llvm-project?rev=341683&view=rev Log: Add input files to the "prepare swig bindings" step. This build phase had no inputs, so you always had to manually delete LLDBWrapPython.cpp to get it to rebuild.

[Lldb-commits] [lldb] r341682 - [Scalar] Fix undefined behaviour when converting double to long.

2018-09-07 Thread Davide Italiano via lldb-commits
Author: davide Date: Fri Sep 7 11:03:43 2018 New Revision: 341682 URL: http://llvm.org/viewvc/llvm-project?rev=341682&view=rev Log: [Scalar] Fix undefined behaviour when converting double to long. This showed up in an Ubsan build of lldb (inside the CFAbsoluteTime data formatter). As we only car

[Lldb-commits] [PATCH] D51594: [ARC] Make char unsigned by default

2018-09-07 Thread Alexander Polyakov via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341667: [ARC] Make char unsigned by default (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51594?vs=163710&id=164419#

[Lldb-commits] [PATCH] D51772: Check if a terminal supports colors on Windows properly

2018-09-07 Thread Dávid Bolvanský via Phabricator via lldb-commits
xbolva00 created this revision. xbolva00 added reviewers: stella.stamenova, zturner. Herald added subscribers: lldb-commits, abidh. Previously we SetUseColor(true) wrongly when output was not a terminal so it broken some (not public) bots. Thanks for issue report, @stella.stamenova Repository: