vsk accepted this revision.
vsk added a comment.
Looks great, thanks!
Comment at: source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp:176
bool got_op = false;
-std::shared_ptr disasm_sp(GetDisassembler());
-if (disasm_sp) {
- const ArchSpec &arch = disasm_s
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM if Vedant is happy with this.
https://reviews.llvm.org/D51319
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
teemperor updated this revision to Diff 162775.
teemperor retitled this revision from "Use a RAII guard to lock/unlock
DisassemblerLLVMC [NFC]" to "Use a RAII guard to control access to
DisassemblerLLVMC.".
teemperor edited the summary of this revision.
teemperor added a comment.
- Got rid of Lo
Author: adrian
Date: Mon Aug 27 16:06:38 2018
New Revision: 340792
URL: http://llvm.org/viewvc/llvm-project?rev=340792&view=rev
Log:
Make the DYLD_INSERT_LIBRARIES workaround for SIP more robut for the various
configurations that bots are running
Modified:
lldb/trunk/lit/Suite/lldbtest.py
M
Author: adrian
Date: Mon Aug 27 16:06:37 2018
New Revision: 340791
URL: http://llvm.org/viewvc/llvm-project?rev=340791&view=rev
Log:
Add a mkdir -p to builddir into lldbtest.py
Based on how it is executed, it may not have been yet created.
Modified:
lldb/trunk/lit/Suite/lldbtest.py
Modified
Author: adrian
Date: Mon Aug 27 14:46:18 2018
New Revision: 340779
URL: http://llvm.org/viewvc/llvm-project?rev=340779&view=rev
Log:
Fix typo
Modified:
lldb/trunk/test/CMakeLists.txt
Modified: lldb/trunk/test/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/test/CMakeLists
vsk added inline comments.
Comment at: source/Plugins/Disassembler/llvm/DisassemblerLLVMC.h:81
+ struct Guard {
+DisassemblerLLVMC *m_instance;
+Guard(DisassemblerLLVMC *instance, InstructionLLVMC *inst,
This is nice. Do you think it might be even safer
teemperor created this revision.
teemperor added a reviewer: LLDB.
Herald added a subscriber: lldb-commits.
The manual lock/unlock calls make my LazyBool refactoring tricky (because now
`return` potentially
cause deadlocks), so this patch just replaces them with a much safer lock guard
that is u
dblaikie added a comment.
>> But if LLDB has different performance characteristics, or the default should
>> be different for other reasons - I'm fine with that. I think I left it on
>> for Apple so as not to mess with their stuff because of the MachO/dsym sort
>> of thing that's a bit differen
EugeneBi marked an inline comment as done.
EugeneBi added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py:215
+# /home/labath/test/a.out)
+tmp_sysroot = "/tmp/lldb_i386_mock_sysroot"
+execut
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340748: Let the CompilerInstance create our clang ASTContext
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51253?vs=
Author: teemperor
Date: Mon Aug 27 08:18:33 2018
New Revision: 340748
URL: http://llvm.org/viewvc/llvm-project?rev=340748&view=rev
Log:
Let the CompilerInstance create our clang ASTContext
Summary:
Now that we moved the BuiltinContext and SelectorTable to the
CompilerInstance, we can also get rid
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340747: Disable use-color if the output stream is not a
terminal with color support. (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
Author: teemperor
Date: Mon Aug 27 08:16:25 2018
New Revision: 340747
URL: http://llvm.org/viewvc/llvm-project?rev=340747&view=rev
Log:
Disable use-color if the output stream is not a terminal with color support.
Summary:
LLDB currently only checks the output terminal for color support by looking
14 matches
Mail list logo
