[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

aprantl added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s stella.stamenova wrote: > apolyakov wrote: > > stella.stamenova wrote: >

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t <

[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

sgraenitz updated this revision to Diff 160014. sgraenitz added a comment. Show allowed cases in ConstStringTest.UpdateMangledCounterpart and format https://reviews.llvm.org/D50536 Files: source/Utility/ConstString.cpp unittests/Utility/ConstStringTest.cpp Index: unittests/Utility/ConstStr

[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

sgraenitz created this revision. sgraenitz added reviewers: jingham, friss, labath. This issue came up because it caused problems in our unit tests. The StringPool did connect counterparts only once and silently ignored the values passed in subsequent calls. The simplest solution for the unit te

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/target-list.test:18 +target list +# CHECK: ~"Current targets:\n* target #0: {{.*}}a.exe{{.*}}\n" + aprantl wrote: > Does lldb-mi echo the comment lines? If yes, you need to be

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

aprantl added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/target-list.test:5 +# We should hardcode executable name since at the moment of running of +# lldb-mi the name must be known. +# RUN: %cxx -o a.exe %p/inputs/main.cpp -g That's t

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s stella.stamenova wrote: > apolyakov wrote: > > stella.stamenova wrote:

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

stella.stamenova added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s apolyakov wrote: > stella.stamenova wrote: > > One thing to cons

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s stella.stamenova wrote: > One thing to consider here is that any extra

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

stella.stamenova added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s One thing to consider here is that any extra parameters passed w

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov created this revision. apolyakov added reviewers: aprantl, clayborg, jingham, labath. Herald added a subscriber: ki.stfu. In this patch I move some of interpreter tests from python to LIT(I will move all interpreter test if these are OK). It's a WIP since I want to get your opinion abo

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

apolyakov added a comment. I think those options don't fit. I'm looking for behavior like this: ~/workspace/gsoc/build/bin/lldb-server gdbserver --pipe 1 localhost:0 36251 Here lldb-server prints out the port number he is listening on and continues running. If debugserver can choose a tcp

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

jingham added a subscriber: apolyakov. jingham added a comment. It looks like lots of options to debugserver were added without also adding them to the --help output. Probably because there are so few clients they already know the options (the same person added & used them...) But if you look

Re: [Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

It looks like lots of options to debugserver were added without also adding them to the --help output. Probably because there are so few clients they already know the options (the same person added & used them...) But if you look at the actual options in debugserver.cpp, you will see: {"u

Re: [Lldb-commits] [lldb] r339178 - [lldb-mi] Re-implement target-select command

On Thu, 9 Aug 2018 at 16:28, Davide Italiano wrote: > Feel free to revert this in the meanwhile, Tim, if you need to get the > bots going again. Thanks Davide. I've marked it unsupported after some discussion with Александр, as a slightly less intrusive solution. Tim. ___

[Lldb-commits] [PATCH] D50473: [Demangle] Add another test for ItaniumPartialDemangler

clayborg added a comment. BTW: warning I saw during recent build: [98/790] Building CXX object tools/lldb/source/Core/CMakeFiles/lldbCore.dir/RichManglingContext.cpp.o /home/gclayton/local/src/llvm/svn/llvm/tools/lldb/source/Core/RichManglingContext.cpp: In member function ‘bool lldb_priva

[Lldb-commits] [lldb] r339353 - Added missing null checks to fix r339351

Author: teemperor Date: Thu Aug 9 08:57:43 2018 New Revision: 339353 URL: http://llvm.org/viewvc/llvm-project?rev=339353&view=rev Log: Added missing null checks to fix r339351 Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/packages/Python/lldbsuite/test

Re: [Lldb-commits] [lldb] r339328 - Remove unused type Either from Utility library.

On Thu, Aug 9, 2018 at 4:42 AM Tatyana Krasnukha via lldb-commits wrote: > > Author: tkrasnukha > Date: Thu Aug 9 04:42:28 2018 > New Revision: 339328 > > URL: http://llvm.org/viewvc/llvm-project?rev=339328&view=rev > Log: > Remove unused type Either from Utility library. > I might be missing th

[Lldb-commits] [PATCH] D50492: Also display the output and error output of a failed command

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB339351: Also display the output and error output of a failed command (authored by teemperor, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D50492 Files: packages/Python/lldbsuit

[Lldb-commits] [lldb] r339351 - Also display the output and error output of a failed command

Author: teemperor Date: Thu Aug 9 08:29:32 2018 New Revision: 339351 URL: http://llvm.org/viewvc/llvm-project?rev=339351&view=rev Log: Also display the output and error output of a failed command Summary: Instead of just printing the current "False is not True, ..." message when we fail to run a

Re: [Lldb-commits] [lldb] r339178 - [lldb-mi] Re-implement target-select command

Feel free to revert this in the meanwhile, Tim, if you need to get the bots going again. -- Davide On Thu, Aug 9, 2018 at 3:35 AM Tim Northover via lldb-commits wrote: > > Hi, > > I think this is causing the lldb-cmake test to hang on Green Dragon. > The build revision numbers don't exactly match

Re: [Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

> On Aug 8, 2018, at 5:52 PM, Leonard Mosescu wrote: > > The LLDB MI plugin didn't work very well as was quite flaky when I tested it > a while back. > > Just curious, what was the flaky part, the debug adapter or the LLDB MI > interface? Not sure. Debugging wasn't rock solid. Don't know w

[Lldb-commits] [lldb] r339343 - Darwin: mark test unsupported while we sort out how to make it generic.

Author: tnorthover Date: Thu Aug 9 06:21:05 2018 New Revision: 339343 URL: http://llvm.org/viewvc/llvm-project?rev=339343&view=rev Log: Darwin: mark test unsupported while we sort out how to make it generic. This test relies on communicating with debugserver via an unnamed (pre-opened) pipe, but

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

apolyakov added a subscriber: t.p.northover. apolyakov added a comment. It seems that `target-select-so-path.test` hangs on macOS. Thanks to @t.p.northover for noting this. The debugserver doesn't have `--pipe` option, so on macOS it fails to start and the test hangs waiting for output from de

[Lldb-commits] [lldb] r339328 - Remove unused type Either from Utility library.

Author: tkrasnukha Date: Thu Aug 9 04:42:28 2018 New Revision: 339328 URL: http://llvm.org/viewvc/llvm-project?rev=339328&view=rev Log: Remove unused type Either from Utility library. Modified: lldb/trunk/include/lldb/Utility/Either.h lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

Re: [Lldb-commits] [lldb] r339178 - [lldb-mi] Re-implement target-select command

Hi, I think this is causing the lldb-cmake test to hang on Green Dragon. The build revision numbers don't exactly match up for reasons I don't quite understand, but when I locally run check-lldb this is the test that spins for ages, and reverting this change doesn't move the timeout elsewhere. I