[Lldb-commits] [PATCH] D48868: [LLDB] In ProcessGDBRemote::UpdateThreadIDList(), the thread PCs should not be cleared after they are updated from the stop reply packet

ramana-nvr added a comment. Sorry, I wasn't clear in my previous comment. In https://reviews.llvm.org/D48868#1158236, @jasonmolenda wrote: > I don't have strong feelings about removing the m_thread_pcs() in > UpdateThreadIDList(), but I think I would prefer leaving it in to changing it > unles

[Lldb-commits] [PATCH] D48868: [LLDB] In ProcessGDBRemote::UpdateThreadIDList(), the thread PCs should not be cleared after they are updated from the stop reply packet

jasonmolenda added a comment. I think the m_thread_pcs.clear() in UpdateThreadIDList() is to clear out any old thread pc values that we might have populated in the past. The only way I can see this happening is if the remote stub SOMETIMES returned the thread-pcs: list in the stop packet. Upd

[Lldb-commits] [PATCH] D48659: Allow specifying an exit code for the 'quit' command

teemperor added a comment. @clayborg was quite specific about the requested changes (which are all applied now), so I assume this is good to go. https://reviews.llvm.org/D48659 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

[Lldb-commits] [PATCH] D48339: Refactor ClangUserExpression::Parse [NFC]

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL336734: Refactor ClangUserExpression::Parse [NFC] (authored by teemperor, committed by ). Herald added a subscriber: llvm-

[Lldb-commits] [lldb] r336734 - Refactor ClangUserExpression::Parse [NFC]

Author: teemperor Date: Tue Jul 10 15:12:39 2018 New Revision: 336734 URL: http://llvm.org/viewvc/llvm-project?rev=336734&view=rev Log: Refactor ClangUserExpression::Parse [NFC] Summary: This patch splits out functionality from the `Parse` method into different methods. This benefits the code co

[Lldb-commits] [lldb] r336732 - [windows] LLDB shows the wrong values when register read is executed at a frame other than zero

Author: stella.stamenova Date: Tue Jul 10 15:05:33 2018 New Revision: 336732 URL: http://llvm.org/viewvc/llvm-project?rev=336732&view=rev Log: [windows] LLDB shows the wrong values when register read is executed at a frame other than zero Summary: This is a clean version of the change suggested

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

krytarowski added a comment. Through pkgsrc a user can install LLDB with either style of distribution, including GCC with libstdc++ one (I'm using this myself also for the development of LLVM related code). BTW. NetBSD uses GPLv3 GNU toolchain. Repository: rL LLVM https://reviews.llvm.org/

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

krytarowski added a comment. Probably the former with ship GDB at least for long time, the latter will switch to LLDB. Repository: rL LLVM https://reviews.llvm.org/D49110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

krytarowski added a comment. NetBSD ships with GCC style and Clang style userland. The former one ships with GNU libstdc++, the latter with libc++. Repository: rL LLVM https://reviews.llvm.org/D49110 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor updated this revision to Diff 154885. teemperor added a comment. - Now using the new API for extracting the raw string from the option list. https://reviews.llvm.org/D48465 Files: include/lldb/Expression/ExpressionParser.h include/lldb/Expression/UserExpression.h packages/Python

[Lldb-commits] [PATCH] D49155: [IRInterpreter] Fix misevaluation of interpretation expressions with `urem`

davide created this revision. davide added reviewers: jingham, jasonmolenda, friss. `Scalar::MakeUnsigned` was implemented incorrectly so it didn't really change the sign of the type (leaving signed types signed). This showed up as a misevaluation when IR-interpreting `urem` but it's likely to a

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL336724: [testsuite] Implement a category to skip libstdcxx tests (authored by davide, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49110?vs

[Lldb-commits] [lldb] r336724 - [testsuite] Implement a category to skip libstdcxx tests

Author: davide Date: Tue Jul 10 13:37:24 2018 New Revision: 336724 URL: http://llvm.org/viewvc/llvm-project?rev=336724&view=rev Log: [testsuite] Implement a category to skip libstdcxx tests On systems where it's not supported. As far as I understand Linux is the only systems which now ships with

[Lldb-commits] [PATCH] D49106: Refactor parsing of option lists with a raw string suffix.

This revision was automatically updated to reflect the committed changes. Closed by commit rL336723: Refactor parsing of option lists with a raw string suffix. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D491

[Lldb-commits] [lldb] r336723 - Refactor parsing of option lists with a raw string suffix.

Author: teemperor Date: Tue Jul 10 13:17:38 2018 New Revision: 336723 URL: http://llvm.org/viewvc/llvm-project?rev=336723&view=rev Log: Refactor parsing of option lists with a raw string suffix. Summary: A subset of the LLDB commands follows this command line interface style: [arguments] --

[Lldb-commits] [PATCH] D49106: Refactor parsing of option lists with a raw string suffix.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That looks good. https://reviews.llvm.org/D49106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D49106: Refactor parsing of option lists with a raw string suffix.

teemperor updated this revision to Diff 154862. teemperor retitled this revision from "Refactor parsing of argument lists with a raw string suffix." to "Refactor parsing of option lists with a raw string suffix.". teemperor edited the summary of this revision. teemperor added a comment. - Rename

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

davide added a comment. Thank you Pavel! https://reviews.llvm.org/D49110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

labath accepted this revision. labath added a comment. Sorry for the slow response, I am OOO officially :P. I think this is fine in general. As for the list of platforms, android should be on that list but not for long (which is why one of the things I was planning to do next week was to implem

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D49110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

davide added a comment. @labath this is breaking several bots for us internally so I would really love to get this in. As this seems to be reasonably close to what you ask, I might consider checking this in before end of day (PST) today and we can iterate from there. https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D48868: [LLDB] In ProcessGDBRemote::UpdateThreadIDList(), the thread PCs should not be cleared after they are updated from the stop reply packet

ramana-nvr added a comment. In https://reviews.llvm.org/D48868#1156416, @jasonmolenda wrote: > If jThreadsInfo isn't implemented, we fall back to looking for the > thread-pcs: and threads: key-value pairs in the stop packet that we received. > > We look for the threads: list and if it is pres

[Lldb-commits] [PATCH] D48960: Use an unwinder to get register contexts of frames other than zeroth under Windows

aleksandr.urakov abandoned this revision. aleksandr.urakov added a comment. Thank you! Yes, https://reviews.llvm.org/D49111 is more like other targets, so I think it will be a better choice. So I will abandon the current revision. https://reviews.llvm.org/D48960