[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

2018-06-24 Thread Alexander Polyakov via Phabricator via lldb-commits
apolyakov added a comment. You are right about python tests. Let's remove them. https://reviews.llvm.org/D48520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

2018-06-24 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. Nice. Since you are adding new lit-based tests for these commands, does that mean that the old python tests become redundant and could we remove them? IIRC the python tests don't set synchronous mode so they are prone to fail under load. https://reviews.llvm.org/D4852

[Lldb-commits] [lldb] r335432 - [FileSpec] Always normalize

2018-06-24 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Sun Jun 24 06:31:44 2018 New Revision: 335432 URL: http://llvm.org/viewvc/llvm-project?rev=335432&view=rev Log: [FileSpec] Always normalize Removing redundant components from the path seems pretty harmless. Rather than checking whether this is necessary and then actuall

[Lldb-commits] [lldb] r335431 - Make testcase classnames unique

2018-06-24 Thread Jan Kratochvil via lldb-commits
Author: jankratochvil Date: Sun Jun 24 03:36:44 2018 New Revision: 335431 URL: http://llvm.org/viewvc/llvm-project?rev=335431&view=rev Log: Make testcase classnames unique Filenames with test results contain only the class name which makes it more difficult to find it if the same class name is pr

[Lldb-commits] [lldb] r335430 - [FileSpec] Refactor append and prepend implemenetations. NFC

2018-06-24 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Sun Jun 24 03:18:01 2018 New Revision: 335430 URL: http://llvm.org/viewvc/llvm-project?rev=335430&view=rev Log: [FileSpec] Refactor append and prepend implemenetations. NFC Replaces custom implementations of append and prepend with calls to llvm's path library. This is