[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

polyakov.alex added inline comments. Comment at: lit/Breakpoint/break-insert.test:5 +# cmd: -break-insert breakpoint +# CHECK: ^done,bkpt={number="1" + polyakov.alex wrote: > aprantl wrote: > > Very nice! > > > > What does the actual output format of lldb-mi loo

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

polyakov.alex added inline comments. Comment at: lit/Breakpoint/break-insert.test:5 +# cmd: -break-insert breakpoint +# CHECK: ^done,bkpt={number="1" + aprantl wrote: > Very nice! > > What does the actual output format of lldb-mi look like? > If every reply is o

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl accepted this revision. aprantl added a comment. Thanks, LGTM. Repository: rL LLVM https://reviews.llvm.org/D46588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

polyakov.alex updated this revision to Diff 146693. polyakov.alex added a comment. Added more comments about the test. Repository: rL LLVM https://reviews.llvm.org/D46588 Files: lit/Breakpoint/Inputs/break-insert.c lit/Breakpoint/Inputs/break-insert.input lit/Breakpoint/break-insert.te

[Lldb-commits] [lldb] r332293 - [lit] Fix several tests that fail when using Python 3 or on Windows

Author: stella.stamenova Date: Mon May 14 14:04:24 2018 New Revision: 332293 URL: http://llvm.org/viewvc/llvm-project?rev=332293&view=rev Log: [lit] Fix several tests that fail when using Python 3 or on Windows Summary: 1) In logtest.cpp, the name of the file that is reported is not always capit

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks for converting the test! Comment at: lit/Breakpoint/break-insert.test:2 +# RUN: %cc %p/Inputs/break-insert.c -g +# RUN: %lldb_mi < %p/Inputs/break-insert.input | Fi

[Lldb-commits] [lldb] r332261 - Revert "Remove Process references from the Host module"

Author: labath Date: Mon May 14 09:54:53 2018 New Revision: 332261 URL: http://llvm.org/viewvc/llvm-project?rev=332261&view=rev Log: Revert "Remove Process references from the Host module" The first fix wasn't enough, there is still a missing ProcessInstanceInfo include in Host.mm. I won't be abl

[Lldb-commits] [PATCH] D46810: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So this problem exists both in the LLDB and LLVM DWARF parsers. I am not sure this fix is safe. I would rather fix this by fixing DWARFDIE class to "do the right thing". We shoul

[Lldb-commits] [PATCH] D46783: FileSpec objects that resolve to "." should have "." in m_filename and m_directory empty.

clayborg added a comment. I agree, but we should still guard against it and test in in LLDB to ensure this doesn't regress. I'll be happy to make a LLVM patch. Many people have branches that link against older LLVMs and the check is cheap. https://reviews.llvm.org/D46783 ___

[Lldb-commits] [lldb] r332255 - Fix macosx build broken by r332250

Author: labath Date: Mon May 14 09:01:49 2018 New Revision: 332255 URL: http://llvm.org/viewvc/llvm-project?rev=332255&view=rev Log: Fix macosx build broken by r332250 Modified: lldb/trunk/source/Host/macosx/Host.mm Modified: lldb/trunk/source/Host/macosx/Host.mm URL: http://llvm.org/viewvc

[Lldb-commits] [PATCH] D46395: Remove Process references from the Host module

This revision was automatically updated to reflect the committed changes. Closed by commit rL332250: Remove Process references from the Host module (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46395 Files: lldb/t

[Lldb-commits] [lldb] r332250 - Remove Process references from the Host module

Author: labath Date: Mon May 14 08:13:13 2018 New Revision: 332250 URL: http://llvm.org/viewvc/llvm-project?rev=332250&view=rev Log: Remove Process references from the Host module The Process class was only being referenced because of the last-ditch effort in the process launchers to set a proces

[Lldb-commits] [PATCH] D46753: FileSpec: Remove PathSyntax enum and use llvm version instead

This revision was automatically updated to reflect the committed changes. Closed by commit rL332247: FileSpec: Remove PathSyntax enum and use llvm version instead (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46753

[Lldb-commits] [lldb] r332247 - FileSpec: Remove PathSyntax enum and use llvm version instead

Author: labath Date: Mon May 14 07:52:47 2018 New Revision: 332247 URL: http://llvm.org/viewvc/llvm-project?rev=332247&view=rev Log: FileSpec: Remove PathSyntax enum and use llvm version instead Summary: The llvm version of the enum has the same enumerators, with stlightly different names, so thi

[Lldb-commits] [PATCH] D46753: FileSpec: Remove PathSyntax enum and use llvm version instead

labath added a comment. We don't export the style right now. At some point we may need to teach SBFileSpec about path styles, but at that point I'd just do the translation at the SB level, and let everyone else use the llvm enum. https://reviews.llvm.org/D46753 _

Re: [Lldb-commits] [PATCH] D46810: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

On Mon, 14 May 2018 at 15:24, Jan Kratochvil via Phabricator < revi...@reviews.llvm.org> wrote: > jankratochvil added a comment. > In https://reviews.llvm.org/D46810#1097829, @labath wrote: > > I am not sure it's that simple. I've found at least one case (`SymbolFileDWARF::ParseImportedModuleswh

[Lldb-commits] [PATCH] D46810: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil added a comment. In https://reviews.llvm.org/D46810#1097829, @labath wrote: > I am not sure it's that simple. I've found at least one case > (`SymbolFileDWARF::ParseImportedModuleswhere we call GetFirstChild() on the > value returned by `GetUnitDIEOnly` OK, that is clearly a bug

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

labath added a comment. Sounds like a plan. https://reviews.llvm.org/D32167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D46810: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

labath added a comment. In https://reviews.llvm.org/D46810#1097740, @jankratochvil wrote: > In https://reviews.llvm.org/D46810#1097503, @labath wrote: > > > (If that is true, then I think this is workable, but there are still some > > details which need to be ironed out; e.g., `m_first_die.GetFi

[Lldb-commits] [PATCH] D46810: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil added a comment. In https://reviews.llvm.org/D46810#1097503, @labath wrote: > - if nothing has been parsed, m_die_array is empty and m_first_die is empty > - if the cu die has been parsed, m_die_array us empty and m_first_die is full > - if everything has been parsed m_first_die an

Re: [Lldb-commits] [lldb] r332162 - [LLDB] Support GNU-style compressed debug sections (.zdebug)

I would suggest testing this the way we have started testing all other ObjectFile changes -- yaml2obj + lldb-test (see tests in lit/Modules). A full-scale integration test is interesting, but I would consider it optional, as this patch touches no files outside the object layer. On Sat, 12 May 2018

[Lldb-commits] [PATCH] D46783: FileSpec objects that resolve to "." should have "." in m_filename and m_directory empty.

labath added a comment. Preserving the dot if it is the only path component is perfectly reasonable -- "" is not a valid path and we shouldn't convert a valid path into an invalid one. However, I think this should be done on the llvm side, in the `remote_dots` function and not as a workaround o

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

labath added inline comments. Comment at: cmake/modules/FindLibEdit.cmake:11-14 +# libedit_FOUND - true if libedit was found +# libedit_INCLUDE_DIRS - include search path +# libedit_LIBRARIES - libraries to link +# libedit_VERSION - version number -

[Lldb-commits] [PATCH] D46810: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

labath added a comment. I **think** I understand what is going on here, but I can't say for certain. Could you elaborate on the implementation details of this somewhere. It would be good to keep a note of this for future maintainers. My understanding of this is: - if nothing has been parsed, m