[Lldb-commits] [lldb] r328278 - [CommandObjectFrame] Remove dead code.

2018-03-22 Thread Davide Italiano via lldb-commits
Author: davide Date: Thu Mar 22 17:14:41 2018 New Revision: 328278 URL: http://llvm.org/viewvc/llvm-project?rev=328278&view=rev Log: [CommandObjectFrame] Remove dead code. Modified: lldb/trunk/source/Commands/CommandObjectFrame.cpp Modified: lldb/trunk/source/Commands/CommandObjectFrame.cpp

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread

2018-03-22 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek added a comment. > Are you planning to rewrite this the command part of this patch using the > changes from https://reviews.llvm.org/D44603 once that's approved? Yes. https://reviews.llvm.org/D43886 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread

2018-03-22 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Are you planning to rewrite this the command part of this patch using the changes from https://reviews.llvm.org/D44603 once that's approved? I like the fact that the part of this that prints exception objects gets access to them through the thread, not the frame. Even

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

2018-03-22 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. This seems like a good place to start. Certainly producing synthetic function arguments is one of the fixed things these recognizers can do, and we can build on that as we go. The inputs are all types that we know how to bind to Python, so it will be easy to make wrap

[Lldb-commits] [PATCH] D44739: [SymbolFileDWARF] Replace FixedFormSizes with llvm::dwarf::getFixedFormByteSize

2018-03-22 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. I would like to not lose any performance if possible. https://reviews.llvm.org/D44739 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44739: [SymbolFileDWARF] Replace FixedFormSizes with llvm::dwarf::getFixedFormByteSize

2018-03-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Hmm... how much is a "significant"? I tried `time optimized/lldb --file debug/clang -o "br set -n dump"` as a benchmark and I saw a 2-3% slowdown (the variance between individual samples is ~1%, so this is statistically significant). I tried playing around with this, an