Re: [Lldb-commits] [lldb] r326756 - Upstreaming avx512 register support in debugserver. These changes

2018-03-05 Thread Davide Italiano via lldb-commits
Thank you so much Jason! On Mon, Mar 5, 2018 at 4:27 PM, Jason Molenda via lldb-commits wrote: > Author: jmolenda > Date: Mon Mar 5 16:27:41 2018 > New Revision: 326756 > > URL: http://llvm.org/viewvc/llvm-project?rev=326756&view=rev > Log: > Upstreaming avx512 register support in debugserver.

[Lldb-commits] [lldb] r326756 - Upstreaming avx512 register support in debugserver. These changes

2018-03-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Mar 5 16:27:41 2018 New Revision: 326756 URL: http://llvm.org/viewvc/llvm-project?rev=326756&view=rev Log: Upstreaming avx512 register support in debugserver. These changes were originally written by Chris Bieneman, they've undergone a number of changes since then. Al

[Lldb-commits] [lldb] r326754 - LLDBStandalone.cmake: set path to llvm-lit inside of llvm build dir

2018-03-05 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Mon Mar 5 15:57:46 2018 New Revision: 326754 URL: http://llvm.org/viewvc/llvm-project?rev=326754&view=rev Log: LLDBStandalone.cmake: set path to llvm-lit inside of llvm build dir Modified: lldb/trunk/cmake/modules/LLDBStandalone.cmake Modified: lldb/trunk/cmake/modules/

[Lldb-commits] [lldb] r326743 - Fix the install location of LLDBWrapPython.cpp when building

2018-03-05 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Mon Mar 5 13:08:42 2018 New Revision: 326743 URL: http://llvm.org/viewvc/llvm-project?rev=326743&view=rev Log: Fix the install location of LLDBWrapPython.cpp when building LLDB.framework to point to the build directory where it is expected by the top-level CMakeLists.txt. Th

[Lldb-commits] [lldb] r326739 - [test] Skip pexpect-based lldb-mi tests on Darwin

2018-03-05 Thread Vedant Kumar via lldb-commits
Author: vedantk Date: Mon Mar 5 12:16:52 2018 New Revision: 326739 URL: http://llvm.org/viewvc/llvm-project?rev=326739&view=rev Log: [test] Skip pexpect-based lldb-mi tests on Darwin These tests fail with a relatively frequently on Darwin machines with errors such as: File ".../lldb/third_par

[Lldb-commits] [lldb] r326727 - Including for std::bind

2018-03-05 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Mar 5 09:54:23 2018 New Revision: 326727 URL: http://llvm.org/viewvc/llvm-project?rev=326727&view=rev Log: Including for std::bind Differential Revision: https://reviews.llvm.org/D44099 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/

[Lldb-commits] [PATCH] D44015: Fix std unique pointer not printing.

2018-03-05 Thread Alexandre Yukio Yamashita via Phabricator via lldb-commits
alexandreyy updated this revision to Diff 137022. alexandreyy added a comment. Fix std unique pointer not printing https://reviews.llvm.org/D44015 Files: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp Index: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp

[Lldb-commits] [PATCH] D44074: ObjectFileMachO: split CreateSections mega-function into more manageable chunks

2018-03-05 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. Fair, I don't have a strong opinion on whether this should be in an header or not. Probably Greg is right though, if this is not used anywhere else, we could make it somehow private. Thanks! https://reviews.llvm.org/D44074

[Lldb-commits] [PATCH] D44056: [lldb] Fix "code unreachable" warning in HostThreadPosix::Cancel

2018-03-05 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Yes we want to avoid ever using this function. It only leads to bad things happening. https://reviews.llvm.org/D44056 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D44074: ObjectFileMachO: split CreateSections mega-function into more manageable chunks

2018-03-05 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added inline comments. Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h:202 + UnifiedList(UnifiedList) {} + }; + void ProcessDysymtabCommand(const llvm::MachO::load_command &load_cmd, Because it is only used in internal functions

[Lldb-commits] [PATCH] D44074: ObjectFileMachO: split CreateSections mega-function into more manageable chunks

2018-03-05 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. LGTM Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h:191-202 + struct SegmentParsingContext { +const EncryptedFileRanges EncryptedRanges; +lldb_private::SectionList &UnifiedList; +uint32_t NextSe

[Lldb-commits] [PATCH] D44074: ObjectFileMachO: split CreateSections mega-function into more manageable chunks

2018-03-05 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. Would just move stuff from header into .cpp file for the SegmentParsingContext class. I'll leave that up to you. Comment at: source/Plugins/ObjectFile/Mach-O

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

2018-03-05 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In https://reviews.llvm.org/D42955#1026296, @labath wrote: > In https://reviews.llvm.org/D42955#1026216, @clayborg wrote: > > > AS for the ELF example where only debug info is around, it might not be > > running into issues if it doesn't contain a symbol table. If it do

[Lldb-commits] [lldb] r326687 - [test] Add dotest wrapper

2018-03-05 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Mar 5 02:03:44 2018 New Revision: 326687 URL: http://llvm.org/viewvc/llvm-project?rev=326687&view=rev Log: [test] Add dotest wrapper This adds a wrapper around dotest, similar to llvm-lit in llvm. The wrapper is created in the binary directory, next to LLDB and all