[Lldb-commits] [PATCH] D43215: Supply missing break in case statement.

asmith added a comment. Lgtm Repository: rL LLVM https://reviews.llvm.org/D43215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D43215: Supply missing break in case statement.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325188: Supply missing break in case statement. (authored by amccarth, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43215?vs=134252&id=1343

[Lldb-commits] [lldb] r325188 - Supply missing break in case statement.

Author: amccarth Date: Wed Feb 14 15:16:36 2018 New Revision: 325188 URL: http://llvm.org/viewvc/llvm-project?rev=325188&view=rev Log: Supply missing break in case statement. Summary: All the tests pass without hitting the situation mentioned in the FIXME, so, per Aaron Smith's suggestion, this c

Re: [Lldb-commits] [PATCH] D43215: Supply missing break in case statement.

No On Wed, Feb 14, 2018 at 2:46 PM Adrian McCarthy via Phabricator < revi...@reviews.llvm.org> wrote: > amccarth added a comment. > > Any remaining concerns? > > > https://reviews.llvm.org/D43215 > > > > ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D43215: Supply missing break in case statement.

amccarth added a comment. Any remaining concerns? https://reviews.llvm.org/D43215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D43215: Supply missing break in case statement.

amccarth updated this revision to Diff 134252. amccarth added a comment. Per Aaron's suggestion, I ran the tests with an unconditional return (and an assertion). There was no change in the test results, so I'm making this return unconditionally. https://reviews.llvm.org/D43215 Files: lldb/

[Lldb-commits] [PATCH] D43292: [dotest] Add ability to skip tests based on build configuration

davide added a comment. After all the work he did on the testsuite I think Adrian is in a good position to review this one. https://reviews.llvm.org/D43292 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] r325137 - Remove vestigial remnants of the test crash info hook

Author: labath Date: Wed Feb 14 08:08:26 2018 New Revision: 325137 URL: http://llvm.org/viewvc/llvm-project?rev=325137&view=rev Log: Remove vestigial remnants of the test crash info hook Modified: lldb/trunk/packages/Python/lldbsuite/test/configuration.py lldb/trunk/packages/Python/lldbsu

[Lldb-commits] [PATCH] D43292: [dotest] Add ability to skip tests based on build configuration

labath created this revision. labath added reviewers: zturner, jingham, davide. Herald added a subscriber: mgorny. Some lldb features depend on xml support. Tests exercising that functionality can only succeed if lldb was built with xml support. Right now we have one such test, and another waiting

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added inline comments. Comment at: source/Core/Module.cpp:1286 +if (SymbolVendor *vendor = GetSymbolVendor()) + vendor->CreateSections(*GetUnifiedSectionList()); } clayborg wrote: > should we pass "obj_file" down into the SymbolVendor::CreateSe