asmith added a comment.
That's a good question and I'm not sure. If all the tests pass you can make it
return unconditionally.
https://reviews.llvm.org/D43215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
By default the cmake build doesn't build LLDB.framework, but thanks for raising
the point, we can avoid the copy when that build setting is in place.
vedant
> On Feb 13, 2018, at 3:11 PM, Greg Clayton wrote:
>
> If "debugserver" isn't put into the LLDB.framework, then it falls back to
> using
If "debugserver" isn't put into the LLDB.framework, then it falls back to using
the one in the currently selected Xcode. We don't really need to copy it if we
just want to use the active system version?
> On Feb 13, 2018, at 3:08 PM, Vedant Kumar via lldb-commits
> wrote:
>
> @Davide I think
@Davide I think you ran into this issue yesterday, let me know if this resolves
it for you.
vedant
> On Feb 13, 2018, at 3:05 PM, Vedant Kumar via lldb-commits
> wrote:
>
> Author: vedantk
> Date: Tue Feb 13 15:05:46 2018
> New Revision: 325068
>
> URL: http://llvm.org/viewvc/llvm-project?re
Author: vedantk
Date: Tue Feb 13 15:05:46 2018
New Revision: 325068
URL: http://llvm.org/viewvc/llvm-project?rev=325068&view=rev
Log:
[cmake] Darwin: Copy in the system debugserver if needed
This makes the built debugger functional on Darwin when compiling
without code signing (as documented in d
zturner added a reviewer: asmith.
zturner added a comment.
Aaron, do you remember why you added a check for `width == 0` here? Would it
ever not be 0?
https://reviews.llvm.org/D43215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
First, I want to apologise for derailing the tab completion review.
However, now that the cat's out of the bag, let me elaborate on what I
meant.
For example, this is how a typical instruction emulation test looks right now:
TEST_F(Testx86AssemblyInspectionEngine, TestSimp
