Ah, no. Pavel suggested that the unwind plan unittests should be turned into
FileCheck tests, and then Davide suggested that he'd heard unwind testing is
difficult (he was conflating the unwind sources -> UnwindPlan IR conversions
and the runtime use of UnwindPlans to walk the stack & find spil
Sure I don’t think anyone disputes that, but I thought we were discussing
an ideal end state
On Mon, Feb 12, 2018 at 1:31 PM Jason Molenda wrote:
>
>
> > On Feb 12, 2018, at 12:59 PM, Zachary Turner wrote:
> >
> >
> >
> > On Mon, Feb 12, 2018 at 12:52 PM Jason Molenda
> wrote:
> >>
> >>
> >> >
> On Feb 12, 2018, at 12:59 PM, Zachary Turner wrote:
>
>
>
> On Mon, Feb 12, 2018 at 12:52 PM Jason Molenda wrote:
>>
>>
>> > On Feb 12, 2018, at 12:48 PM, Zachary Turner via Phabricator
>> > wrote:
>> >
>> > zturner added a comment.
>> >
>> > In https://reviews.llvm.org/D43048#1005513,
On Mon, Feb 12, 2018 at 12:52 PM Jason Molenda wrote:
>
>
> > On Feb 12, 2018, at 12:48 PM, Zachary Turner via Phabricator <
> revi...@reviews.llvm.org> wrote:
> >
> > zturner added a comment.
> >
> > In https://reviews.llvm.org/D43048#1005513, @jasonmolenda wrote:
> >
> > I don't think we'd nece
> On Feb 12, 2018, at 12:48 PM, Zachary Turner via Phabricator
> wrote:
>
> zturner added a comment.
>
> In https://reviews.llvm.org/D43048#1005513, @jasonmolenda wrote:
>
>> No, the unwind unittests that exist today should stay written as unit tests.
>> These are testing the conversion of
zturner added a comment.
In https://reviews.llvm.org/D43048#1005513, @jasonmolenda wrote:
> No, the unwind unittests that exist today should stay written as unit tests.
> These are testing the conversion of native unwind formats -- for instance,
> eh_frame, compact unwind, or instruction analy
jingham added a comment.
I also had to remove them from the Xcode project. With that done everything
looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D43202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org
jasonmolenda added a comment.
No, the unwind unittests that exist today should stay written as unit tests.
These are testing the conversion of native unwind formats -- for instance,
eh_frame, compact unwind, or instruction analysis -- into the intermediate
UnwindPlan representation in lldb. T
Author: jingham
Date: Mon Feb 12 12:25:37 2018
New Revision: 324930
URL: http://llvm.org/viewvc/llvm-project?rev=324930&view=rev
Log:
Remove the pubnames support from the Xcode project.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
UR
Thanks for laying this out. I don't think any of us have a brief for getopt,
it was the tool at hand. Getting some fuzzy match suggestions would be nice.
Your comment about getopts reminds me, a more fundamental problem with lldb's
command interpreter is that the CommandObject is stateful. So
Author: amccarth
Date: Mon Feb 12 11:19:04 2018
New Revision: 324925
URL: http://llvm.org/viewvc/llvm-project?rev=324925&view=rev
Log:
Remove dead code for handling DWARF pubnames
Summary:
LLDB doesn't use this code, the code has no tests, and the code does suspicious
things like hashing pointers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324925: Remove dead code for handling DWARF pubnames
(authored by amccarth, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43202?vs=133903&id
asmith updated this revision to Diff 133899.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43096
Files:
CMakeLists.txt
lit/CMakeLists.txt
lit/lit.site.cfg.in
Index: lit/lit.site.cfg.in
Author: davide
Date: Mon Feb 12 10:06:34 2018
New Revision: 324919
URL: http://llvm.org/viewvc/llvm-project?rev=324919&view=rev
Log:
[testsuite] Reintroduce test to check leaking.
It wasn't python leaking, it was lldb. Thanks to Pavel for the
explanation. Pointy-hat to me.
Added:
lldb/trunk
clayborg added inline comments.
Herald added a subscriber: arichardson.
Comment at: source/Core/Module.cpp:1286
+if (SymbolVendor *vendor = GetSymbolVendor())
+ vendor->CreateSections(*GetUnifiedSectionList());
}
should we pass "obj_file" down into th
davide added a comment.
In https://reviews.llvm.org/D43048#1004807, @labath wrote:
> (Btw, if you're looking for things to FileCheck-ify, I think the stuff under
> `lldb/unittests/UnwindAssembly` is a prime candidate and has a much higher
> bang/buck ratio.)
If you have ideas on how to FileCh
Apologies, I clearly misunderstood. I'll add this again.
On Mon, Feb 12, 2018 at 2:52 AM, Pavel Labath via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> I think you misunderstood the purpose the purpose of this test. The
> test was there to make sure that *lldb* does not leak file descript
labath added a comment.
(Btw, if you're looking for things to FileCheck-ify, I think the stuff under
`lldb/unittests/UnwindAssembly` is a prime candidate and has a much higher
bang/buck ratio.)
https://reviews.llvm.org/D43048
___
lldb-commits mail
labath added inline comments.
Comment at: CMakeLists.txt:73-80
+ if ("${LLDB_TEST_C_COMPILER}" STREQUAL "")
+set(LLDB_TESTING_DEFAULT_C_COMPILER ON)
+ endif()
+
+ if ("${LLDB_TEST_CXX_COMPILER}" STREQUAL "")
+set(LLDB_TESTING_DEFAULT_CXX_COMPILER ON)
+ endif()
---
I think you misunderstood the purpose the purpose of this test. The
test was there to make sure that *lldb* does not leak file descriptors
into the inferior (when I wrote it a couple of years ago, we were
leaking about half a dozen of them). The python version check was
added there just because we
labath added a comment.
There are several components in the "command line parsing"
1. argparse: parsing a single string into the individual words (processing
quotes, backslashes, etc.)
2. resolving the "command" part of the command line (the "frame variable" part
of "frame variable --raw-output
Author: labath
Date: Mon Feb 12 01:46:06 2018
New Revision: 324870
URL: http://llvm.org/viewvc/llvm-project?rev=324870&view=rev
Log:
Skip TestTargetXMLArch on non-darwin OSs
This test uses XML packets, but libxml is an optional dependency of
lldb, and this test fails if it is not present.
I'm le
22 matches
Mail list logo
